Repository navigation
Activate Codex voice for mobile DM huddles - #3048
Conversation
Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Signed-off-by: klopez4212 <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c16ab618a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| admissions = call.admissions; | ||
| publish({ | ||
| phase: "connected", | ||
| id: `remote:${call.room.id}:${call.agent}:${epoch}`, |
There was a problem hiding this comment.
For every remote mobile admission, this value becomes the id passed through createHuddleVoices to nativeHuddles.open, but the native huddle_open validation in src-tauri/src/relay/huddle.rs requires call.id to be a canonical UUID and rejects this remote:... string with Invalid Huddle destination. Consequently the advertised mobile-to-desktop voice path cannot open a native agent seat; the test misses this because its mocked bridge does not enforce the IPC contract. Generate and retain a UUID for each remote-call epoch instead.
AGENTS.md reference: AGENTS.md:L102-L106
Useful? React with 👍 / 👎.
kazemek21
left a comment
kazemek21
left a comment
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes. Approved, with the non-blocking hang-up handling comment below.
Posted by Codex (gpt-6.1-sol) on behalf of kylez
| nativeHuddles, | ||
| huddles.voiceError, | ||
| (call, error) => { | ||
| if (remoteVoices.snapshot().id === call) huddles.remoteVoiceError(error); |
There was a problem hiding this comment.
[P2] Treat normal remote departure as a clean stop
The relay broadcasts the audio left update before publishing the signed 48102 event. If that update reaches desktop first, voice.ts reports “The owner left the Huddle” while this remote call still matches, and this branch shows a connection-error toast after a normal phone hang-up. Could remote owner departure stop the seat silently, while retaining this notice for genuine voice failures?
Posted by Codex (gpt-6.1-sol) on behalf of kylez
Show the Huddle action in owned Codex agent DMs and invite the agent before connecting audio. Revalidate eligibility on starts/recovery, ask before inviting into an existing call, and distinguish pending invitations from connected audio peers with actionable timeout feedback. DM hangup leaves shared room cleanup to the relay so another owner device stays connected. Pairs with block/buzz-app#3048. Desktop and the Codex agent must remain running. Validated: 4,559 mobile tests, analysis, formatting, push hooks, and independent source review. Live phone-to-desktop audio and human trial remain pending. --------- Signed-off-by: kenny lopez <[email protected]> Signed-off-by: Tom Brow <[email protected]> Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz> Co-authored-by: Tom Brow <[email protected]> Co-authored-by: Tom Brow <[email protected]> Co-authored-by: Claude Opus 5.5 <[email protected]>
Activate desktop-hosted Codex voice when its owner joins the agent’s DM huddle from mobile. Reuses the existing voice connection and owner-only audio checks without opening the desktop microphone; handles device departures, rejoins, and relay generation changes.
Requires the companion mobile change in block/buzz#9269. Desktop and the Codex agent must remain running.
Validated: 240 huddle tests, TypeScript, lint, independent review, and push hooks. Live phone-to-desktop audio and human trial remain pending; remote voice failures currently appear on desktop.