Repository navigation
fix(attention): show the attention toggle when an agent has nothing yet - #2907
Merged
Merged
Conversation
kalvinnchau
marked this pull request as ready for review
November 6, 2026 22:40
attention starts off per agent and its tools refuse to run while off, so an agent with no interests or watches could never get its first one: the empty state hid the active/paused control. always render the attention settings card, keep the empty-state sonar, and only suggest messaging the agent once attention is active. Co-authored-by: peon <9ac6794b000690b7e814eb1805ad32405d0bec7d52838de3a86cf967565dacc0@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
kalvinnchau
force-pushed
the
fix/attention-empty-state-toggle
branch
from
November 6, 2026 22:42
ab58aae to
4a7ad7d
Compare
wpfleger96
approved these changes
Nov 6, 2026
wpfleger96
left a comment
wpfleger96
left a comment
Member
There was a problem hiding this comment.
🤖 Reviewed the diff at 4a7ad7d. The fix matches the cause: Attention is off unless saved as on (runner.ts:714), and the Active/Paused control lived inside the !empty block, so a new agent with no interests had no way to turn it on. Rendering the settings card unconditionally, dropping only the small sonar when the large empty-state one is showing, fixes that without changing the populated layout. The "Send a message" hint is now gated on active, and the updated test covers paused, the save-error retry, and the switch to active. No concerns.
3 tasks
wpfleger96
added a commit
that referenced
this pull request
Nov 6, 2026
…ion-and-status * origin/main: feat(agents): team instructions history and agent/team config tools (#2848) test(plugin-manager): use an immutable git socket fixture (#2665) fix(attention): show the attention toggle when an agent has nothing yet (#2907) fix(agents): stream the remote agent introduction 1.5× faster (#2902) fix(relay): stop holding a watched public channel that a read after a reconnect leaves out (#2889) feat(agents): squircle agent avatar previews (#2879) fix(todos): show Todos read-only without Canvas write access (#2799) fix(unread): leave mentions that arrive during catch-up unread (#2801) Show one working indicator while a message's live activity shows (#2851) fix(agents): ask before deleting a team (#2820) fix(dialog): keep stepped dialog cards top-anchored during crossfade (#2893) feat(attention): Interest titles, summaries and named people, and Activity and pause fixes (#2860) fix(messages): Enter on the outside-mention prompt invites again (#2897) feat(agents): keep open agent transcripts current while the agent works (#2844) perf(solo): render a sidebar chat row only when it changes (#2505) fix(solo): restore agent selection during slow background reads (#2751) feat(search): preview unread thread replies in cmd+k (#2743) fix(plugins): suggest SSH when a private HTTPS clone needs credentials (#2455) # Conflicts: # src/features/agents/team-ops.ts
tellaho
added a commit
that referenced
this pull request
Nov 7, 2026
Integrate the mainline sidebar geometry correction while retaining the dialog focus changes. Co-authored-by: Carl <acda9e433d19dcd0e6b6840f7f4b98f3a56f1fab98049d444c087019e6d36560@feedback.communities.buzz.xyz> * origin/main: fix(sidebar): give Drafts & sent the page rows' icon box (#2946) fix(sidebar): drop the draft pencil from channel and DM rows (#2943) feat(channels): create #general for the owner of an empty community (#2904) feat(agents): move local teams to the relay and show sync state (#2846) Preserve legacy emoji avatars during agent import (#2849) feat(communities): skip join consent covered by a Builderlab account (#2912) fix(mentions): keep @mentions tagged when punctuation or quotes follow the name (#2713) fix(sidebar): align Drafts & sent row with channel rows (#2733) test(navigation): split the plugin-settings return-path journey (#2800) fix(messages): let Escape close Forward and return focus to ⋯ (#2807) fix(messages): say older messages can load once Buzz reconnects, instead of an inert Load older button (#2810) fix(navigation): say when the open page's plugin is turned off, and open it in Manage plugins (#2817) fix(settings): reopen plugin details on Back and Forward (#2825) fix(agents): show agent card pictures without a backdrop (#2828) feat(agents): team instructions history and agent/team config tools (#2848) test(plugin-manager): use an immutable git socket fixture (#2665) fix(attention): show the attention toggle when an agent has nothing yet (#2907) Signed-off-by: Taylor Ho <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Attention starts off for each agent, and an agent's Attention tools refuse to run while it is off. The Attention tab hid the Active/Paused control whenever the agent had no interests, watches, orphans or skipped items, and showed only the empty state with "Send a message to get started." So a new agent could never create its first interest, and there was no way to turn Attention on from the UI.
Change
Tab.tsx: always render the Attention settings card (PreferenceRow+AttentionStatus). In the empty state, leave out the card's small sonar because the empty state already shows the large one.AttentionEmptyState.tsx: newactiveprop. Show "Send a message to get started." only when Attention is active.Tab.test.tsx: the empty-state test now turns Attention on from the empty state (including the save-error retry), checks the hint is hidden while paused, and checks it appears once active.Screenshots
Taken with the
tests/fixtures/agent-attention.htmlbrowser fixture (Chromium, 900px wide, light theme), after pausing Attention and deleting every watch and interest.Validation
vitest run src/bundled/watching/: 25/25 passedbiome check --error-on-warnings src/bundled/watching/: cleantsc --noEmit: cleandesign:checknot run. That is why this PR is a draft.🤖 Generated with Claude Code