fix(messages): Enter on the outside-mention prompt invites again by baxen · Pull Request #2897 · block/buzz-app

baxen · 2026-11-06T21:52:37Z

Problem

If you mention someone who isn't in the channel and press Send, Buzz asks "Mention people outside this channel?". Since #2021 that prompt opens with focus on Close. Pressing Enter again right away dismisses it and leaves the draft unsent, so to invite you have to reach for the mouse.

#825 had made Invite the default on purpose. #2021 changed it to Close as part of a broader "focus safe controls" pass.

Change

When you can add members, the prompt opens with focus on Invite again, so Send then Enter invites the person and sends.

Escape and Close still dismiss the prompt and keep the draft unsent.
If you can't add members to the channel, focus still starts on Close (no change).
The old-agent import prompt and the archive and delete confirmations keep fix(dialogs): focus safe controls and task inputs #2021's safe defaults. Only this prompt changes.

Testing

vitest run (full): 1020 files and 19336 tests passed.
Updated the MessageComposer tests:
- "Enter right after the prompt opens invites a nonmember and sends": Invite has focus when the prompt opens, and Enter adds the person and sends.
- The close/escape test now expects Invite to have initial focus and still checks that nothing is added or sent. Its old "enter" case was the exact behavior this PR reverses, so I removed it.
Not yet tried in the running app.

#2021 moved the mention-consent prompt's initial focus to Close, so Enter right after Send dismissed it and kept the draft unsent. Mentioning someone outside the channel almost always means you want them here, so start on Invite again (as #825 did). Escape and Close still keep the draft unsent, and a viewer who cannot add members still starts on Close. Co-authored-by: mbot <3754f8729004d95654c46dbab3129e4ab9ef05cc2534e2a3fbfc155983bd637b@buzz.block.builderlab.xyz> Signed-off-by: Bradley Axen <[email protected]>

chatgpt-codex-connector · 2026-11-06T22:01:18Z

Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-06T22:03:47.406582Z	`28e342e`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 28e342e71b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-11-06T22:03:44Z

 ) {
  const [pending, setPending] = useState<Pending>();
  const adding = useRef(false);
+  // Mentioning someone outside the channel usually means you want them here,


Add the required DCO sign-off to this commit

The reviewed commit message contains no Signed-off-by trailer, so the repository's hosted DCO check will reject it; recreate the commit with git commit --signoff before submitting it.

AGENTS.md reference: AGENTS.md:L268-L274

Useful? React with 👍 / 👎.

Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> * origin/main: (22 commits) feat(agents): squircle agent avatar previews (#2879) fix(todos): show Todos read-only without Canvas write access (#2799) fix(unread): leave mentions that arrive during catch-up unread (#2801) Show one working indicator while a message's live activity shows (#2851) fix(agents): ask before deleting a team (#2820) fix(dialog): keep stepped dialog cards top-anchored during crossfade (#2893) feat(attention): Interest titles, summaries and named people, and Activity and pause fixes (#2860) fix(messages): Enter on the outside-mention prompt invites again (#2897) feat(agents): keep open agent transcripts current while the agent works (#2844) perf(solo): render a sidebar chat row only when it changes (#2505) fix(solo): restore agent selection during slow background reads (#2751) feat(search): preview unread thread replies in cmd+k (#2743) fix(plugins): suggest SSH when a private HTTPS clone needs credentials (#2455) fix(browser-host): use the Buzz login variant for dev Builderlab sign-in (#2222) refactor(plugin-manager): move distributor values into build settings (#2649) fix(communities): let Cancel, × and Escape leave a Join lookup and name the host that didn't answer (#2821) fix(agents): let watches hear public channels the agent is not in (#1854) Preview and send Drafts & sent in place, with a shared count bubble (#2833) feat(terminal): add an Option as Meta key setting on macOS (#2850) fix(agents): restrict workflow requests in bb-block only (#2518) ... Signed-off-by: John Tennant <[email protected]> # Conflicts: # src/bundled/agents/AgentAvatarPicker.tsx # src/bundled/agents/AgentCreate.module.css

Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> * origin/main: (22 commits) feat(agents): squircle agent avatar previews (#2879) fix(todos): show Todos read-only without Canvas write access (#2799) fix(unread): leave mentions that arrive during catch-up unread (#2801) Show one working indicator while a message's live activity shows (#2851) fix(agents): ask before deleting a team (#2820) fix(dialog): keep stepped dialog cards top-anchored during crossfade (#2893) feat(attention): Interest titles, summaries and named people, and Activity and pause fixes (#2860) fix(messages): Enter on the outside-mention prompt invites again (#2897) feat(agents): keep open agent transcripts current while the agent works (#2844) perf(solo): render a sidebar chat row only when it changes (#2505) fix(solo): restore agent selection during slow background reads (#2751) feat(search): preview unread thread replies in cmd+k (#2743) fix(plugins): suggest SSH when a private HTTPS clone needs credentials (#2455) fix(browser-host): use the Buzz login variant for dev Builderlab sign-in (#2222) refactor(plugin-manager): move distributor values into build settings (#2649) fix(communities): let Cancel, × and Escape leave a Join lookup and name the host that didn't answer (#2821) fix(agents): let watches hear public channels the agent is not in (#1854) Preview and send Drafts & sent in place, with a shared count bubble (#2833) feat(terminal): add an Option as Meta key setting on macOS (#2850) fix(agents): restrict workflow requests in bb-block only (#2518) ... Signed-off-by: John Tennant <[email protected]> # Conflicts: # src/bundled/agents/AgentCreate.module.css

…ion-and-status * origin/main: feat(agents): team instructions history and agent/team config tools (#2848) test(plugin-manager): use an immutable git socket fixture (#2665) fix(attention): show the attention toggle when an agent has nothing yet (#2907) fix(agents): stream the remote agent introduction 1.5× faster (#2902) fix(relay): stop holding a watched public channel that a read after a reconnect leaves out (#2889) feat(agents): squircle agent avatar previews (#2879) fix(todos): show Todos read-only without Canvas write access (#2799) fix(unread): leave mentions that arrive during catch-up unread (#2801) Show one working indicator while a message's live activity shows (#2851) fix(agents): ask before deleting a team (#2820) fix(dialog): keep stepped dialog cards top-anchored during crossfade (#2893) feat(attention): Interest titles, summaries and named people, and Activity and pause fixes (#2860) fix(messages): Enter on the outside-mention prompt invites again (#2897) feat(agents): keep open agent transcripts current while the agent works (#2844) perf(solo): render a sidebar chat row only when it changes (#2505) fix(solo): restore agent selection during slow background reads (#2751) feat(search): preview unread thread replies in cmd+k (#2743) fix(plugins): suggest SSH when a private HTTPS clone needs credentials (#2455) # Conflicts: # src/features/agents/team-ops.ts

kalvinnchau approved these changes Nov 6, 2026

View reviewed changes

baxen marked this pull request as ready for review November 6, 2026 22:01

baxen requested a review from a team as a code owner November 6, 2026 22:01

chatgpt-codex-connector Bot reviewed Nov 6, 2026

View reviewed changes

baxen merged commit 49a05f8 into main Nov 6, 2026
59 checks passed

baxen deleted the mbot/nonmember-invite-default branch November 6, 2026 22:05

Navigation Menu

Repository navigation

fix(messages): Enter on the outside-mention prompt invites again - #2897

fix(messages): Enter on the outside-mention prompt invites again#2897
baxen merged 1 commit into
mainfrom
mbot/nonmember-invite-default

baxen commented Nov 6, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

chatgpt-codex-connector Bot Nov 6, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

baxen commented Nov 6, 2026

Problem

Change

Testing

Uh oh!

chatgpt-codex-connector Bot commented Nov 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Nov 6, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

chatgpt-codex-connector Bot commented Nov 6, 2026 •

edited

Loading