Repository navigation
fix(browser): silence a browser page once its tab goes away - #2721
Merged
Merged
Conversation
Closing a Builderlab app tab, or switching channels away from one, parks its page hidden for up to 10 minutes so the same page can come back as it was. The parked page kept running, so its audio kept playing with no visible tab to stop it. Detaching a view now suspends the page's media (WebKit setAllMediaPlaybackSuspended, which also holds Web Audio) at the same time as it hides the page, and a view that adopts the parked page resumes it. A page that cannot be silenced closes instead of parking, and a parked page that cannot resume is replaced by a fresh one. Signed-off-by: Logan Johnson <[email protected]> Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
Resuming a parked page's media now waits on a native call. A view that unmounted during it never received the page, so nothing would detach it and the page kept playing. Check the view again after resuming and close the page if it is gone. The view's own detach no longer leaves an unhandled rejection when hiding or silencing fails. Signed-off-by: Logan Johnson <[email protected]> Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
… resume Signed-off-by: Logan Johnson <[email protected]> Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
loganj
force-pushed
the
loganj/browser-tab-close-audio
branch
from
November 6, 2026 16:08
7c93a67 to
8ac9fb0
Compare
loganj
marked this pull request as ready for review
November 6, 2026 16:54
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment has been minimized.
This comment has been minimized.
kalvinnchau
approved these changes
Nov 6, 2026
kalvinnchau
left a comment
kalvinnchau
left a comment
Contributor
There was a problem hiding this comment.
🤖 Approved at 8ac9fb0. No actionable findings.
Reviewed immediate suspension, serialized re-adoption, suspend-failure cleanup, resume-failure replacement, disposal during resume, ten-minute retention, native command registration and permissions. The change stays within existing session/platform ownership. Background tabs and dialog occlusion intentionally preserve playback; removed views suspend it. Existing lifecycle tests protect meaningful failure and race boundaries and should be retained.
Validation includes 14 passing actual-app browser checks across Chromium and WebKit, covering removal/reopening, channel changes, failure recovery, blocked-queue suspension, disposal during resume and retention expiry. Same-commit CI passed, including JavaScript/Vitest and macOS Rust tests. The new command remains restricted to the main webview, with guest and remote-context denial represented in permission tests.
Validation limit: browser checks used modeled guest I/O and relay upstream, so they do not establish real WKWebView audio/video/Web Audio behavior or native completion ordering. The native API dispatches asynchronously without awaiting its completion callback. The author's reported native close/reopen audio test provides additional acceptance evidence; independent native playback and suspension persistence across navigation/process crashes remain unverified. No concrete defect was established in those areas.
tlongwell-block
added a commit
that referenced
this pull request
Nov 6, 2026
* origin/main: fix(sidebar): rename Remove from Team to Close conversation (#2845) perf(channels): cut header and name-matching work in large channels (#2726) fix(browser): silence a browser page once its tab goes away (#2721) Community Mesh: shared compute plugin (including agent type) (#941) perf(relay): cut main-thread work from profile updates (#2730) fix(composer): lead the channel placeholder with its sidebar icon (#2829) test(activity): scope preview assertions to the request row (#2843) perf(search): fold people names once across palette keystrokes (#2570) fix(github): keep PR watches running when localStorage is full (#2699) Make drafts and sent part of Messages (#2728) fix(canvas): render every Canvas within the save limit (#2839) Co-authored-by: Eva <011987e296fd5006292d2f930b574be47c7801048d1983c46c425d3c95f0cffd@buzz.block.builderlab.xyz> Co-authored-by: Tyler Longwell <[email protected]> Signed-off-by: Tyler Longwell <[email protected]>
wpfleger96
added a commit
that referenced
this pull request
Nov 6, 2026
…leanup * origin/main: feat(agents): let app-hosted agents read their owner's channels and members (#2745) NEXUS-4271: Expose installed plugin status (#2754) fix(menu): stop clipping lifecycle actions behind a hidden scrollbar (#2716) feat(agents): give approved external apps the selected agent's full Buzz tools (#2707) AIDA-2549: Keep Claude settings drafts in sync (#2841) fix(channels): keep a channel's side panels open when returning to it (#2838) fix(builderlab): clarify remote-agent account availability (#2764) fix(sidebar): rename Remove from Team to Close conversation (#2845) perf(channels): cut header and name-matching work in large channels (#2726) fix(browser): silence a browser page once its tab goes away (#2721) Community Mesh: shared compute plugin (including agent type) (#941) perf(relay): cut main-thread work from profile updates (#2730) fix(composer): lead the channel placeholder with its sidebar icon (#2829) test(activity): scope preview assertions to the request row (#2843) perf(search): fold people names once across palette keystrokes (#2570) fix(github): keep PR watches running when localStorage is full (#2699) Make drafts and sent part of Messages (#2728) fix(canvas): render every Canvas within the save limit (#2839) # Conflicts: # .github/workflows/release.yml
cheng-block
added a commit
to cheng-block/buzz-app
that referenced
this pull request
Nov 6, 2026
…ime-hint * upstream/main: ci: give the native job room for a cold Rust cache (block#2867) fix(pairing): refuse unknown communities natively and name the requesting process (block#2835) Add per-interest Attention pause and management controls (block#2847) feat(drafts): show where unsent drafts wait (block#2853) feat(agents): let app-hosted agents read their owner's channels and members (block#2745) NEXUS-4271: Expose installed plugin status (block#2754) fix(menu): stop clipping lifecycle actions behind a hidden scrollbar (block#2716) feat(agents): give approved external apps the selected agent's full Buzz tools (block#2707) AIDA-2549: Keep Claude settings drafts in sync (block#2841) fix(channels): keep a channel's side panels open when returning to it (block#2838) fix(builderlab): clarify remote-agent account availability (block#2764) fix(sidebar): rename Remove from Team to Close conversation (block#2845) perf(channels): cut header and name-matching work in large channels (block#2726) fix(browser): silence a browser page once its tab goes away (block#2721) Community Mesh: shared compute plugin (including agent type) (block#941) perf(relay): cut main-thread work from profile updates (block#2730) fix(composer): lead the channel placeholder with its sidebar icon (block#2829) test(activity): scope preview assertions to the request row (block#2843) perf(search): fold people names once across palette keystrokes (block#2570) fix(github): keep PR watches running when localStorage is full (block#2699) Signed-off-by: Cheng Peng <[email protected]> Co-authored-by: Cursor <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Details
setAllMediaPlaybackSuspended(macOS 12+, which matches the app's minimum). While suspended, the page cannot start playback again on its own. A new native command,browser_set_media_suspended, exposes it. It is registered in the command list, the main-window capability and the permission test.buzz-review-completed
🤖 Generated with Claude Code