Skip to content

perf(search): rank each palette name once per render - #2606

Merged
kalvinnchau merged 1 commit into
mainfrom
peon/rg-search-rank
Nov 5, 2026
Merged

perf(search): rank each palette name once per render#2606
kalvinnchau merged 1 commit into
mainfrom
peon/rg-search-rank

Conversation

@kalvinnchau

@kalvinnchau kalvinnchau commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Problem

Each SearchResults render ranks every channel name against the typed text more than once. It ranks them in the filter that builds the usage pick candidates, again in the filter that builds the matching channels, and once more in rankOf for every matching channel and DM row. matchRank runs the full matchName search, including its word-run memo, on every call. The palette re-renders on each keystroke and each lookup round, so with 128 DMs most of that work is repeated.

Change

A per-render Map remembers each label's rank for the current needle. The three channel ranking sites read it through rankName. People keep their own needle and ranking; they are not affected.

No behavior changes

matchRank is a pure function of the label and the needle, and the needle is fixed for the render. Every site therefore gets the same rank as before, including undefined for a non-match. The SearchResults, PageSearch and SearchChoices suites pass unchanged.

Evidence

Browser benchmark with 128 DMs, 1,001 participants and read state, at 4× CPU throttling in production Chromium:

  • Switch, quiet: open Cmd+K, type a channel name and press Enter, with no other traffic.
  • Switch: the same while another channel receives a message every 200 ms.
  • Switch 5k: the same into a 5,080-member channel.

Stock and this PR were interleaved on 8 Linux and 8 macOS workstations. Medians are per run.

scenario, metric Linux: stock Linux: this PR Linux Δ % macOS: stock macOS: this PR macOS Δ %
quiet, script 373.3 ms 350.1 ms −6.2% 253.9 ms 243.5 ms −4.1%
quiet, task 626.0 ms 604.0 ms −3.5% 418.5 ms 410.1 ms −2.0%
quiet, blocking 238.7 ms 229.4 ms −3.9% 123.7 ms 119.2 ms −3.6%
switch, script 643.1 ms 570.5 ms −11.3% 372.7 ms 356.7 ms −4.3%
switch, task 1,021.9 ms 944.6 ms −7.6% 610.3 ms 595.1 ms −2.5%
switch, blocking 287.6 ms 270.2 ms −6.1% 122.7 ms 119.2 ms −2.9%
switch 5k, script 685.7 ms 662.8 ms −3.3% 391.6 ms 387.8 ms −1.0%
switch 5k, blocking 330.5 ms 310.8 ms −6.0% 128.6 ms 128.7 ms +0.0%

Lower is better. Blocking is long-animation-frame blocking time. There are 96 samples per cell.

Checks: the SearchResults, PageSearch and SearchChoices suites pass (174 tests), along with tsc and biome.

🤖 Generated with Claude Code

@kalvinnchau @claude
perf(search): rank each palette name once per render
86588eb 
searchresults ranked every channel name against the typed text in the
usage pick filter, again in the matching-channels filter, and again in
rankof for each matching row. matchrank is pure in (label, needle) and
needle is fixed for the render, so a per-render map returns the same
ranks with one matchname call per distinct label.

Signed-off-by: Kalvin C <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
@kalvinnchau
kalvinnchau marked this pull request as ready for review November 5, 2026 16:04
@kalvinnchau
kalvinnchau requested a review from a team as a code owner November 5, 2026 16:04
wpfleger96
wpfleger96 approved these changes Nov 5, 2026
View reviewed changes

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Reviewed: the cache lives for one render with a fixed needle, Map.has correctly caches non-matches and rank 0, and destination-specific ordering stays outside the cache. No findings. Merges cleanly with #2605.

@wpfleger96 wpfleger96 mentioned this pull request Nov 5, 2026
Merged
@kalvinnchau
kalvinnchau merged commit 7c331af into main Nov 5, 2026
42 checks passed
@kalvinnchau
kalvinnchau deleted the peon/rg-search-rank branch November 5, 2026 16:44
johnmatthewtennant added a commit that referenced this pull request Nov 5, 2026
@johnmatthewtennant
Merge origin/main into jtennant/martha/history-floor-own-messages
36e1236 
Signed-off-by: John Tennant <[email protected]>

* origin/main: (47 commits)
  fix(messages): pass verified labels to the forward recipient picker (#2633)
  feat(messages): forward a message to a person (#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (#2620)
  Route debug sessions through the credential helper (#2541)
  perf(search): skip no-op slow-search resets on each keystroke (#2605)
  perf(agents): dedupe channel members only for dm connection setup (#2603)
  perf(search): keep the search tab row across palette keystrokes (#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (#2582)
  perf(search): rank each palette name once per render (#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (#2572)
  feat(settings): follow the system clock and let people hide message times (#2440)
  feat(plugins): repository access rules for Git imports (#2484)
  feat(desktop): add Settings to the macOS app menu (#2594)
  Preserve and renew external app approval (#2464)
  fix(direct-messages): show verified identity in new message recipient search (#2585)
  Offer plugin updates from the Buzz shell (#2491)
  fix(messages): keep decoded images across virtualized remounts (#2474)
  Keep /leave commands out of channel history (#2476)
  fix(agents): ask before switching or closing drops unsaved edits (#2503)
  fix(agents): keep the Model settings row full width (#2577)
  ...
wpfleger96 added a commit that referenced this pull request Nov 5, 2026
@wpfleger96
Merge remote-tracking branch 'origin/main' into elrond/cli-credential…
7e1d02a 
…-service

* origin/main:
  fix(messages): pass verified labels to the forward recipient picker (#2633)
  feat(messages): forward a message to a person (#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (#2620)
  Route debug sessions through the credential helper (#2541)
  perf(search): skip no-op slow-search resets on each keystroke (#2605)
  perf(agents): dedupe channel members only for dm connection setup (#2603)
  perf(search): keep the search tab row across palette keystrokes (#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (#2582)
  perf(search): rank each palette name once per render (#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (#2572)
cheng-block added a commit to cheng-block/buzz-app that referenced this pull request Nov 5, 2026
@cheng-block @cursoragent
Merge remote-tracking branch 'upstream/main' into cheng/fix-channel-s…
d652f6c 
…ettings-shift-esc

* upstream/main: (40 commits)
  feat(conversation): let plugin rows manage messages without visiting a channel (block#2512)
  feat(github): make side-panel link opening optional (block#2629)
  feat(messages): show a blurred thumbnail until an image loads (block#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (block#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (block#2384)
  fix(inbox): keep the list's place when returning in the same session (block#2134)
  fix(messages): pass verified labels to the forward recipient picker (block#2633)
  feat(messages): forward a message to a person (block#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (block#2620)
  Route debug sessions through the credential helper (block#2541)
  perf(search): skip no-op slow-search resets on each keystroke (block#2605)
  perf(agents): dedupe channel members only for dm connection setup (block#2603)
  perf(search): keep the search tab row across palette keystrokes (block#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (block#2582)
  perf(search): rank each palette name once per render (block#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (block#2572)
  feat(settings): follow the system clock and let people hide message times (block#2440)
  feat(plugins): repository access rules for Git imports (block#2484)
  feat(desktop): add Settings to the macOS app menu (block#2594)
  Preserve and renew external app approval (block#2464)
  ...

Signed-off-by: Cheng Peng <[email protected]>
Co-authored-by: Cursor <[email protected]>
johnmatthewtennant added a commit that referenced this pull request Nov 5, 2026
@johnmatthewtennant
Merge remote-tracking branch 'origin/main' into jtennant/simone/webp-…
55e4b30 
…thumbnails

* origin/main: (120 commits)
  feat(conversation): let plugin rows manage messages without visiting a channel (#2512)
  feat(github): make side-panel link opening optional (#2629)
  feat(messages): show a blurred thumbnail until an image loads (#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (#2384)
  fix(inbox): keep the list's place when returning in the same session (#2134)
  fix(messages): pass verified labels to the forward recipient picker (#2633)
  feat(messages): forward a message to a person (#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (#2620)
  Route debug sessions through the credential helper (#2541)
  perf(search): skip no-op slow-search resets on each keystroke (#2605)
  perf(agents): dedupe channel members only for dm connection setup (#2603)
  perf(search): keep the search tab row across palette keystrokes (#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (#2582)
  perf(search): rank each palette name once per render (#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (#2572)
  feat(settings): follow the system clock and let people hide message times (#2440)
  feat(plugins): repository access rules for Git imports (#2484)
  feat(desktop): add Settings to the macOS app menu (#2594)
  Preserve and renew external app approval (#2464)
  ...

Signed-off-by: John Tennant <[email protected]>

# Conflicts:
#	src-tauri/src/relay.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpfleger96 wpfleger96 wpfleger96 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kalvinnchau @wpfleger96