Skip to content

feat(github): rework the GitHub settings page - #2450

Merged
johnmatthewtennant merged 10 commits into
mainfrom
jtennant/damon/github-settings-name
Nov 5, 2026
Merged

johnmatthewtennant merged 10 commits into
mainfrom
jtennant/damon/github-settings-name

Conversation

@johnmatthewtennant

@johnmatthewtennant johnmatthewtennant commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Why

The GitHub plugin's settings page was named "GitHub comment authors", after its one setting. The rules on it also depend on an account the page never showed: author:@me and the default deny author:@me prefix:🤖 rule mean whichever account gh is signed in to.

What

  • Main (feat(github): make side-panel link opening optional #2629) now groups Links and Comment authors under one GitHub settings page. This PR keeps that layout and routes gh through it.
  • The Comment authors section says which account gh is signed in to ("Signed in to GitHub as octocat through gh."). If gh can't read the account, it gives gh's reason, such as a sign-in error or, in the browser app, that plugins can't start processes. The page's card id stays authors, so existing links still open it.
  • The section is concise: the rule syntax sits behind a Rule syntax disclosure under a one-line hint, the open-rules notice is one line, and When no rule matches is an inline select.

Screenshots

GitHub settings with Links and Comment authors, where gh can't read an account (browser harness)

GitHub settings page

Validation

  • In the browser harness at the merged head, the GitHub page shows Links and Comment authors, and the account line reads "gh couldn’t read your GitHub account: Processes require an installed desktop plugin" (screenshot above).
  • With a stubbed gh answering viewer{login} as octocat, the page reads "Signed in to GitHub as octocat through gh." after one query.
  • A GitHubError("Bad credentials") from gh reads "gh couldn’t read your GitHub account: Bad credentials".
  • Not yet exercised: the signed-in line against a real gh sign-in in the desktop app.

🤖 Generated with Claude Code

johnmatthewtennant and others added 2 commits November 4, 2026 12:45
…count

The page was named for its one setting, the comment author rules. It is now the GitHub plugin's page, and it says which account gh is signed in to, the account author:@me and the default 🤖 rule mean.

Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: John Tennant <[email protected]>
Signed-off-by: John Tennant <[email protected]>
Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>

* origin/main:
  feat(agents): identify plugins in native hook output (#2299)
  [4/5] Add protection to the Codex harness plugin (#1879)
  feat(search): show member counts on channel results (#2333)
  Fix the mute icon flashing when selecting a channel (#2287)
  feat(agents): open a working agent's transcript from its activity (#2276)
  test(agents): refuse a real relay workflow mention in the harness kit (#2444)
  fix(agents): catch up every event watch on the kinds it watches (#1852)
  Keep local artifact collections current (#1507)
  feat(members): add several people to a chat in one write (#2010)
@johnmatthewtennant
johnmatthewtennant marked this pull request as ready for review November 4, 2026 19:29
@johnmatthewtennant
johnmatthewtennant requested a review from a team as a code owner November 4, 2026 19:29

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Two non-blocking consistency issues: distinguish unsupported/non-auth failures from signed-out state, and finish the settings rename in the watch tool description.

Comment thread src/bundled/github/AuthorSettings.tsx Resolved
Comment thread docs/agents.md Resolved
johnmatthewtennant and others added 3 commits November 4, 2026 14:48
The account line told every failure to run gh auth login, including the
browser app, where plugins can't start processes, and offline or API
errors. Show gh's own reason instead.

Signed-off-by: John Tennant <[email protected]>
Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: John Tennant <[email protected]>
Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Move the rule syntax behind a Rule syntax disclosure, keep the
open-rules notice to one line, and choose what happens when no rule
matches from an inline select instead of two radios.

Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: John Tennant <[email protected]>

@kalvinnchau kalvinnchau left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 One non-blocking design-system conformance issue. The exercised browser flows passed.

Comment thread src/bundled/github/AuthorSettings.tsx Resolved
johnmatthewtennant and others added 3 commits November 4, 2026 16:43
Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: John Tennant <[email protected]>
* origin/main: (38 commits)
  fix(browser): load scheme-less address input over https, falling back to http (#2467)
  fix(identity): stop one-click key unlinks and show the linked backed-up key (#2486)
  fix(test): observe coordination transition events (#2297)
  fix(profiles): keep the next view's profile reads through a shrink (#2395)
  fix(channels): show Add and Send message errors above the Manage members list (#2421)
  fix(threads): keep reply hooks off agent activity bubbles (#2422)
  fix(channels): offer only Copy link in a not-joined preview's sidebar actions (#2425)
  test: scope row menu placement checks to active section rows (#2493)
  feat(relay): detach channel windows to a point in history (#2042)
  feat(identity): decide a missing backup choice from community membership (#2378)
  Offer Builderlab decisions in FI builds (#2227)
  feat(inbox): preview recent Inbox activity when hovering the sidebar row (#2347)
  Add collapsible Solo and Team sidebar sections (#2296)
  fix(codex): open long Codex transcripts a page of items at a time (#2259)
  Keep Solo model and effort choices per chat (#2342)
  feat(sidebar): smooth channel reordering with bounded motion (#2108)
  Connect legacy agents from DMs and channel mentions (#2423)
  fix: exclude muted channels from sidebar unread scroll indicators (#2335)
  fix(claude-code): open long Claude transcripts a page at a time (#2428)
  feat(solo): share chats as view only (#2375)
  ...
* origin/main:
  fix(messages): keep the hover toolbar while its menu is open (#2439)
  feat(workflows): suggest channel members for @ in Send Message text (#2309)
  AIDA-2344: Exclude muted channels from Dock (#2313)
  feat(search): add slack-style message search operators on desktop (#2463)
  test: fix invitation and coordination checks on main (#2517)
  perf(search): name searched people from the profile search response (#2353)
  Use the merge queue for pull requests that require it (#2452)
@johnmatthewtennant johnmatthewtennant changed the title feat(github): name its settings page GitHub and show the signed-in account feat(github): rework the GitHub settings page Nov 5, 2026
johnmatthewtennant and others added 2 commits November 5, 2026 13:25
Keep main's GitHub settings page (Links and Comment authors under one
GitHub header) and route gh through GitHubSettings so the Comment
authors section still shows the signed-in account.

Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude <[email protected]>
Signed-off-by: John Tennant <[email protected]>
Co-authored-by: Damon <8a08290d889f1c68921542bfe9631d4cd671be9bea5f1114951f386819e4c10a@buzz.block.builderlab.xyz>
Co-Authored-By: Claude <[email protected]>
Signed-off-by: John Tennant <[email protected]>
@johnmatthewtennant
johnmatthewtennant merged commit 4bb94e2 into main Nov 5, 2026
43 checks passed
@johnmatthewtennant
johnmatthewtennant deleted the jtennant/damon/github-settings-name branch November 5, 2026 19:26
wpfleger96 added a commit that referenced this pull request Nov 5, 2026
* commit '4bb94e259':
  feat(github): rework the GitHub settings page (#2450)
  fix(mcp): accept create scopes in durable approvals (#2650)
  feat(bestie): Bestie tab and Remembers you for a hosted Bestie (#2478)
  fix(relay): p-tag a one-to-one DM's agent partner on new messages (#2475)
  fix(agents): show each message author's username and display name (#2628)
  fix(agents): preserve visible edits in conversation history (#2355)
  fix(canvas): keep todo edits from approving unrelated instructions (#2350)
  fix(messages): keep messages in their canonical channel (#2349)
  NEXUS-4165: Add Thinking to agent creation (#2409)
  feat(plugins): let a plugin paint a backdrop behind the shell (#2437)
  feat(search): lead empty quick open with unread conversations (#2634)
  NEXUS-4170: Allow external apps to create private Solo chats (#2411)
wpfleger96 added a commit that referenced this pull request Nov 5, 2026
…leanup

* origin/main:
  fix(goose): track every replaced protected worker and check its security gate (#2528)
  docs(agents): say Pi agents don't take plugin notes yet (#2534)
  feat(agents): reorder agent cards with hold and drag (#1837)
  fix(messages): keep own sends from before the loaded history off the timeline (#2525)
  feat(github): rework the GitHub settings page (#2450)

# Conflicts:
#	src/bundled/github/watcher.test.ts
wpfleger96 added a commit that referenced this pull request Nov 5, 2026
…-service

* origin/main: (29 commits)
  Normalize profile names for verified-name matching (#2348)
  Add BuzzTerm font settings and compact glyph spacing (#2502)
  feat(plugins): let a host command run only verified bytes (#2535)
  NEXUS-4228: Add plugin toolbar actions and panel links (#2645)
  Keep plugin update controls stable and spaced (#2636)
  feat(inbox): rename to Activity and simplify the filter bar (#2543)
  fix(goose): track every replaced protected worker and check its security gate (#2528)
  docs(agents): say Pi agents don't take plugin notes yet (#2534)
  feat(agents): reorder agent cards with hold and drag (#1837)
  fix(messages): keep own sends from before the loaded history off the timeline (#2525)
  feat(github): rework the GitHub settings page (#2450)
  fix(mcp): accept create scopes in durable approvals (#2650)
  feat(bestie): Bestie tab and Remembers you for a hosted Bestie (#2478)
  fix(relay): p-tag a one-to-one DM's agent partner on new messages (#2475)
  fix(agents): show each message author's username and display name (#2628)
  fix(agents): preserve visible edits in conversation history (#2355)
  fix(canvas): keep todo edits from approving unrelated instructions (#2350)
  fix(messages): keep messages in their canonical channel (#2349)
  NEXUS-4165: Add Thinking to agent creation (#2409)
  feat(plugins): let a plugin paint a backdrop behind the shell (#2437)
  ...

# Conflicts:
#	src/bundled/goose/runtime.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants