Repository navigation
fix(bestie): stub page navigation position in PinnedBestie test - #2169
Merged
Merged
Conversation
Co-authored-by: hax <[email protected]> Signed-off-by: Kalvin Chau <[email protected]>
wesbillman
reviewed
Nov 2, 2026
wesbillman
left a comment
wesbillman
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
Verdict: no blockers.
- The stub now satisfies every required member of
PageNavigationat this head (src/features/navigation/service.ts:15-39); it is the only hand-builtPageNavigationliteral inPinnedBestie.test.tsx. - No-op
position/savePositionis behavior-neutral here: nothing undersrc/bundled/bestie/(non-test) reads or writes positions, and it matches the existing stub inAgentsPage.test.tsx. - Branch is 1 ahead / 0 behind
main(2c2286b82), which still lacks the stub.
Merge criterion: PR CI green (JavaScript shards were pending at review time).
wesbillman
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainCI is red: all fourJavaScript (n/4)jobs fail attsc --noEmit(e.g. run 41491229758 onbaeefef1e):Cause
Semantic merge conflict between two PRs that were each green on their own:
dd898a7c6) madeposition(key)andsavePosition(key, value)required members ofPageNavigation(src/features/navigation/service.ts) so pages can restore the reader's place on Back.baeefef1e, pin the saved Bestie DM) added a hand-builtPageNavigationstub inPinnedBestie.test.tsxthat was written against the older shape.Fix
Add
position: () => undefinedandsavePosition() {}to the stub. This is the same no-op stub used by the other page tests (e.g.src/bundled/agents/AgentsPage.test.tsx:678). Test-only change, no production code touched. Pinned Bestie doesn't use saved positions, so a no-op stub keeps the test's behavior as-is.Validation
bin/pnpm exec tsc --noEmit: cleanbin/pnpm exec vitest run src/bundled/bestie/PinnedBestie.test.tsx: 14/14 passNot run locally: the full Vitest shards and browser suites. This PR's CI covers those.