fix(inbox): keep the list's place when returning in the same session - #2134

When an Inbox filter choice left the list empty, most empty views
offered no way back. Two examples are Filters → **DMs** on an Inbox with
no DMs, and Status → **Archived** with nothing archived. Only Archived +
Unread only had a button, "Show all archived conversations". It cleared
Unread only and left the user in an empty Archived view. Otherwise the
user had to reopen the filter menu and work out which choice to undo.
With this change, every empty view caused by a filter or by Archived
offers a reset.

This is one of two independent PRs split from one branch. The Inbox
scroll-position fix is in #2134. Either can merge first.

## Before and after


https://github.com/user-attachments/assets/2ff6e6df-badf-4aac-809d-9fb98fa1aa60

Left: `main` @ `67e404917`. Right: this branch @ `e532565c2`. Both run
the same scripted take on the local fixture app and relay (Chromium,
1100×720, light theme): Filters → **DMs**, then reset; Status →
**Archived**, then return to Inbox. Before has no button, so its half
resets through the filter menu at the same moments.

| | Before | After |
|---|---|---|
| Empty DMs view | text only | **Clear filters** |
| Empty Archived view | text only | **Show Inbox** |
| Focus after the reset | Inbox filters trigger (via the menu) | Inbox
filters trigger |

## What the user sees

- **Clear filters:** any non-default Type, From or Unread only choice
that empties the list now offers **Clear filters**. It resets those
three and keeps Status.
- **Show Inbox:** an empty Archived view without those filters offers
**Show Inbox**. It goes through the same handler as Status → Inbox in
the menu.
- **Focus:** either button returns focus to the Inbox filters trigger.
- **No action when there is nothing to reset:** an unfiltered, empty
Inbox still shows text only.
- **Replaced button:** "Show all archived conversations" (Archived +
Unread only) is gone. That state now offers Clear filters.

## What changed

- `src/bundled/inbox/InboxPage.tsx` (`+22/−9`):
- The Status menu's inline handler becomes `showView`, which the menu
and Show Inbox share. It cancels a pending Retry, clears the selection
and sets `show`.
- `filtered` is true when `activity !== "all"`, `senderFilter !==
"everyone"` or `unreadOnly` is set.
- The `EmptyState` action renders when `filtered || show ===
"archived"`. Clear filters resets activity, sender and attention. Show
Inbox calls `showView("inbox")`. Both then focus the filters trigger
(`fallbackControl`).
- **Design system:** this reuses the existing `EmptyState` action slot
and the same `Button size="sm" variant="ghost"` that the removed reset
used. There is no new component, token or variant.
- `docs/inbox.md`: the sentence describing the old single reset now
describes the new ones.

## How it was tested

All runs were local (macOS) on `e532565c2`, unless noted:

- **Vitest:** `bin/pnpm exec vitest run
src/bundled/inbox/InboxPage.test.tsx` passed 127/127. That is main's
124, with one case rewritten and 3 added:
- **Rewritten:** the archive test now walks Archived + filters → **Clear
filters** (Status stays Archived, focus on the trigger). It then
restores the last row → empty Archived → **Show Inbox** (focus on the
trigger, Status back to Inbox). Finally it empties an unfiltered Inbox
and checks there is no action.
- **Added:** an `it.each` that clears each of DMs (Type), Agents (From)
and Unread only from an emptied Inbox, checking focus and that every
filter is reset.
- **Typecheck:** `bin/pnpm typecheck` (`tsc --noEmit`) is clean.
- **Browser:** `bin/pnpm test:browser --project=chromium
--project=webkit --no-deps tests/browser/inbox*.spec.mjs` ran the ten
Inbox suites in both engines. 64/64 passed. That is the same suites
without the scroll PR's ten new cases, and includes WebKit
`inbox-archive.spec.mjs:520`, a case that is flaky on main because
Playwright's WebKit `fill()` can drop text (see the scroll PR). No
browser case was added or changed. The behaviour is the empty-state
matrix and focus, which the component tests cover in jsdom. No browser
journey referred to the removed button's label.
- **Fail-before:** I ran this branch's `InboxPage.test.tsx` against
main's `InboxPage.tsx`. All four new or rewritten cases fail: the three
`it.each` cases and the archive walk. Main has no Clear filters or Show
Inbox button.
- **Review:** five agent review rounds ran on the pre-split branch (tip
`80e26c473`). The last found no blockers. This commit and #2134
recombine to that reviewed tree exactly; the only difference is where
one existing Vitest case sits in the file.
- **Exercised:** the recording above, in the fixture app.

## Known caveats

- **Two-step reset in an empty filtered Archived view:** Clear filters
always keeps Status. Suppose Archived plus a Type, From or Unread only
filter is empty, and the archive itself is also empty. Then Clear
filters lands on an empty Archived view, and **Show Inbox** is a second
click. That matches the agreed behaviour, where Clear filters never
changes Status, but it takes two clicks to get back to a populated
Inbox.
- **Design checks not done:** the recording is Chromium, light theme,
1100×720. Dark theme, narrow widths, enlarged text and keyboard-only use
were not checked in the app.
- **Not covered:** the desktop app (WKWebView) was not exercised.

## Status

Draft. A human has not tried it yet, so `buzz-review-completed` is not
set. To try it in the app:

1. In Inbox, choose a Type or From that matches nothing. **Clear
filters** should appear. Click it: rows return and focus lands on the
filters trigger.
2. Turn on Unread only after everything is read. **Clear filters**
should appear and reset it.
3. Choose Status → **Archived** with nothing archived. **Show Inbox**
should appear. Click it to return to Inbox.
4. Choose Archived plus a filter that matches nothing. Clear filters
should keep you in Archived.
5. With no filters, archive everything. The empty Inbox should show no
button.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Matt Toohey <[email protected]>
Co-authored-by: Claude Fable 5.1 <[email protected]>

…2138)

## Problem

`tests/browser/reactions-polish.spec.mjs:110` "reaction emojis and hit
areas grow together without clipping" failed on PR #2134 (run
[41412759993](https://github.com/block/buzz-app/actions/runs/41412759993),
Chromium shard 8/9) at line 208:

```
expect(await pill.boundingBox()).toEqual(hitArea)
- "y": 203.9375
+ "y": 247.6875     (x, width, height unchanged)
```

The failure screenshot and every screencast frame before and after the
read show the 👍 pill at y ≈ 204. The diff in that PR touches only Inbox
files, and the test passed 16/16 in the other failed-job logs of the
previous 11 hours and 30/30 locally.

## Cause

The emoji fixture's custom-emoji media is not served, so each
custom-emoji `<img>` fails on load and `CustomEmoji` retries it 2 s
later (`RETRY_DELAYS_MS[0]`). The retried `<img>` briefly sits in
Chromium's broken-image state (`complete`, `naturalWidth 0`): its alt
text wraps inside the 16 px inline-block, whose baseline then follows
its last internal line, so the message text and the reaction row beneath
drop by several lines until React swaps the image for its literal.

The CI trace lines this up: first emoji-media requests at :20.93, the
hover's dynamic import of `reaction-name` + emoji data at :22.13 (a ~400
ms page stall), the retry's second round of emoji-media requests at
:23.02, and the failing `boundingBox` read resolving at :22.97–23.00,
inside that window.

A probe (`MutationObserver` reading the pill's rect after each DOM
mutation, 8× CDP CPU throttling) reproduced the shift in 4/4 runs ~1.0 s
after the hover: the paragraph grew 23 → 89 px while the re-inserted
`<img>` was in the broken state; the shift reverted when React replaced
it with `:party:`.

## Fix

Same remedy #2068 applied to "reaction previews center above each emoji
bubble": serve artwork for `**/emoji-media/**` and wait for the first
reaction image to load before measuring, so no retry runs while the test
reads layout. Test-only; 10 lines.

## Validation

- Probe with the route: 0 shifts in 6/6 throttled runs (vs 4/4 without).
- `bin/pnpm test:browser --project=chromium --project=webkit --no-deps
tests/browser/reactions-polish.spec.mjs`: 18 passed (9 tests × 2
engines) at ed17dc6.
- Biome clean; `git diff --check` clean.
- The assertion failure itself does not reproduce locally under
throttling alone (the read lands ~1 s before the retry without CI's
import stall), so fail-then-pass evidence is for the mechanism via the
probe, not for line 208.

Deferred: hosted CI on this branch; human run of the spec.

## Follow-up (not in this PR)

The layout jump is a product behaviour, not only a fixture artefact:
whenever a custom emoji image fails (and on each 2 s / 10 s / 30 s
retry) the message's line box grows for a frame or more. `overflow:
hidden` on `.customEmoji` would make the broken-image inline-block's
baseline its bottom edge and remove the jump; left out to keep this
change test-only. Two other journeys in this file (`:473`, `:551`) also
load the wrap fixture without a route and could hit the same class if
they ever read layout across a retry.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Matt Toohey <[email protected]>
Co-authored-by: Claude Fable 5.1 <[email protected]>

…ettings-shift-esc

* upstream/main: (40 commits)
  feat(conversation): let plugin rows manage messages without visiting a channel (block#2512)
  feat(github): make side-panel link opening optional (block#2629)
  feat(messages): show a blurred thumbnail until an image loads (block#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (block#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (block#2384)
  fix(inbox): keep the list's place when returning in the same session (block#2134)
  fix(messages): pass verified labels to the forward recipient picker (block#2633)
  feat(messages): forward a message to a person (block#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (block#2620)
  Route debug sessions through the credential helper (block#2541)
  perf(search): skip no-op slow-search resets on each keystroke (block#2605)
  perf(agents): dedupe channel members only for dm connection setup (block#2603)
  perf(search): keep the search tab row across palette keystrokes (block#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (block#2582)
  perf(search): rank each palette name once per render (block#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (block#2572)
  feat(settings): follow the system clock and let people hide message times (block#2440)
  feat(plugins): repository access rules for Git imports (block#2484)
  feat(desktop): add Settings to the macOS app menu (block#2594)
  Preserve and renew external app approval (block#2464)
  ...

Signed-off-by: Cheng Peng <[email protected]>
Co-authored-by: Cursor <[email protected]>

…thumbnails

* origin/main: (120 commits)
  feat(conversation): let plugin rows manage messages without visiting a channel (#2512)
  feat(github): make side-panel link opening optional (#2629)
  feat(messages): show a blurred thumbnail until an image loads (#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (#2384)
  fix(inbox): keep the list's place when returning in the same session (#2134)
  fix(messages): pass verified labels to the forward recipient picker (#2633)
  feat(messages): forward a message to a person (#2167)
  docs(agents): design relay-facing paths for the whole fleet at once (#2620)
  Route debug sessions through the credential helper (#2541)
  perf(search): skip no-op slow-search resets on each keystroke (#2605)
  perf(agents): dedupe channel members only for dm connection setup (#2603)
  perf(search): keep the search tab row across palette keystrokes (#2588)
  perf(sidebar): skip the hidden actions menu in solo and team headers (#2582)
  perf(search): rank each palette name once per render (#2606)
  perf(sidebar): skip re-rendering unchanged animated channel rows (#2572)
  feat(settings): follow the system clock and let people hide message times (#2440)
  feat(plugins): repository access rules for Git imports (#2484)
  feat(desktop): add Settings to the macOS app menu (#2594)
  Preserve and renew external app approval (#2464)
  ...

Signed-off-by: John Tennant <[email protected]>

# Conflicts:
#	src-tauri/src/relay.rs

* origin/main: (28 commits)
  fix(mcp): accept create scopes in durable approvals (block#2650)
  feat(bestie): Bestie tab and Remembers you for a hosted Bestie (block#2478)
  fix(relay): p-tag a one-to-one DM's agent partner on new messages (block#2475)
  fix(agents): show each message author's username and display name (block#2628)
  fix(agents): preserve visible edits in conversation history (block#2355)
  fix(canvas): keep todo edits from approving unrelated instructions (block#2350)
  fix(messages): keep messages in their canonical channel (block#2349)
  NEXUS-4165: Add Thinking to agent creation (block#2409)
  feat(plugins): let a plugin paint a backdrop behind the shell (block#2437)
  feat(search): lead empty quick open with unread conversations (block#2634)
  NEXUS-4170: Allow external apps to create private Solo chats (block#2411)
  fix(acp): count grouped thinking levels when checking a synced level (block#2640)
  feat(conversation): let plugin rows manage messages without visiting a channel (block#2512)
  feat(github): make side-panel link opening optional (block#2629)
  feat(messages): show a blurred thumbnail until an image loads (block#2556)
  fix(relay): give large roster and read-state reads a 30s deadline (block#2627)
  fix(user-status): show a status emoji's :name: on hover where the full status shows (block#2384)
  fix(inbox): keep the list's place when returning in the same session (block#2134)
  fix(messages): pass verified labels to the forward recipient picker (block#2633)
  feat(messages): forward a message to a person (block#2167)
  ...

# Conflicts:
#	tests/browser/settings.spec.mjs