Repository navigation
test(mcp): allow protection checks in bundled help fixture - #2061
Merged
Merged
Conversation
permit the optional protection hook while rejecting all other host access. cover help dispatch with and without protection. Co-authored-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz> Signed-off-by: Kalvin Chau <[email protected]>
kalvinnchau
marked this pull request as ready for review
October 31, 2026 00:12
wesbillman
approved these changes
Oct 31, 2026
shellz-n-stuff
added a commit
that referenced
this pull request
Oct 31, 2026
Picks up the month-boundary StatusEditor test fix (#2064). Co-Authored-By: Claude Opus 5.5 <[email protected]> * origin/main: (56 commits) perf(sidebar): subscribe to selected live and list facts (#1966) feat(desktop): align the sign-in callback page with web branding (#2038) Show linked PRs in Solo headers and move idle huddles to Chat actions (#1968) feat(messages): mark edited messages with "(edited)" (#2020) feat(desktop): bundle the buzz CLI in every package (#2027) feat(plugins): open a plugin page from buzz://plugin links (#2053) feat(plugins): managed plugin sources (#2052) test(browser): prevent sampled clock pause races (#1955) test: fix month-boundary and Sonner mount races in StatusEditor and RelayStaff tests (#2064) test: stop tests leaving temp dirs and a flake-check fixture behind (#1977) fix(messages): release Virtua's held range when scrolling stops (#2032) test(mcp): allow protection checks in bundled help fixture (#2061) fix(emoji): recover transient image failures without reopening chats (#2000) test: wait for dialog focus, reach a reading position, re-sign pair() (#1975) feat(plugins): sign builderlab in through the native fi session in fi builds (#1461) feat(agents): offer bundled Buzz help (#2033) fix(github): show pull request status for anchors and subpages (#2055) fix(dialogs): focus safe controls and task inputs (#2021) fix(composer): truncate workspace names at narrow widths (#2043) AIDA-2287: Refresh public channel search incrementally (#2023) ... Signed-off-by: Alex Rosenzweig <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled-help MCP test fails on main because its client Proxy rejects the shared session gate's optional
protectlookup. The help handler itself uses bundled Markdown and performs no host I/O.Allow only the protection hook in that fixture and exercise both protected and unprotected sessions. All other client access still throws, and the protected case requires both tool and result checks. Production code is unchanged.
Validation: reproduced the exact main failure at
8fd0d34ae55e565e75cbc1fd31bc97897b0385be; the affected test now passes both cases. Mandatory push hooks passed TypeScript, 124 related tests in two files, and design checks. Independent review found no actionable issues. Hosted CI run 41145309756 passed at repair heada1fc32286ed7f17a5033415f027d1fecb0ddc674, including the required gate, all three JavaScript shards, both Vitest flake jobs, and all 23 browser journey shards. Windows native validation and browser flake repetition were skipped by workflow selection. No full local suite was invoked. Human acceptance was not observed; this PR remains draft.Repairs the sole failing workload in main CI run 41143376903. No browser cases added or removed. Local targeted execution: before 462ms total/9ms tests; after 629ms total for two cases. These are single-run local measurements, not hosted performance evidence.