Wait for a resting pointer before hover content opens - #1641

… Back/Forward destination

Follow-up to cd78176 and d36df14, which kept channel Members and the
Agents provider dialog out of history. Settings was the last address-driven
dialog that still consumed Back: it pushed a visit on open, one per section
switch, and Close traversed back with `returnTo`. It now follows the same
rule: dialogs never create a history visit, Back while one is open leaves
the page, and reload/Forward restore the dialog from the address.

Design (option A of the plan): home, page and conversation targets gain an
optional `overlay: { kind: "settings", section?, scope? }`. `pageKey` strips
it (and keys the cold `kind: "settings"` form as one page), `targetKey`
keeps it, so the controller's existing forced in-place rule handles
Settings with no Settings knowledge. `provideNavigation` wraps `open`: a
`kind: "settings"` intent opened while a page visit is current is rewritten
to that visit plus the overlay (scope recorded only when it differs from the
page's), so every existing caller - shortcut, Cmd+K, pickers, section
switch, plugins - complies unchanged. The bare `kind: "settings"` target
remains the cold form of saved addresses; Close there still falls back to
Messages, now with `replace`.

- `useAppNavigation`: `settings`/`section`/scope come from `settingsOf` and
  `targetScope`; page availability is not checked for the page beneath
  Settings (Close re-checks it). `leaveSettings` opens
  `stripOverlay(current)` with `{ replace: true, focus: "preserve" }`;
  `lastNonSettings` is gone. Legacy Home/Inbox/Bestie/Messages-settings
  resolutions carry the overlay. A retained workspace is only shown and
  kept when it is the page the Settings visit covers.
- `App.tsx`: focus restore keys on the covered page's target, not a visit
  id. `openSettingsSection` opens a fresh `{ Messages, scope: null,
  overlay }` visit when the community beneath is no longer joined (the
  post-departure Profile), since that page can't be returned to.
- `Settings.tsx` reads its section via `settingsOf`.
- `returnTo` is deleted: the option, the controller's deferred return, and
  both drivers' `returnTo` (plus the browser driver's visit index).

One deviation from the plan, forced by evidence: the plan recommended
dropping `resume` and handing the page a fresh request on Close. The
App.profile tests showed ChannelsPage treats any new request as a new visit
(`open(undefined)` dismisses the New-message composer; `enterVisit` resets
selection), so Close lost the draft and its focus. Instead, a
presentation-only write now goes through `history.resolve`, so the visit
keeps its identity (Members and Agents included; their tests flip from
"new id" to "same id"), and the existing `resume`/replay keyed on
id+target stays, keyed on `settingsOf`. That also removes the plan's
objection to resuming (a stale `entryId` for the Members guard).

Tests: targets (overlay stripping across kinds, rejection of bad overlays,
cold form), service (intent rewritten onto the page, scope dedupe,
cross-community scope kept, cold form stays bare; retained workspace
resumes through a replace Close), controller (Settings overlay in place
with `replace: false`, Back leaves, Forward restores, Close in place,
another page pushes, cold sections replace), App-level
(entity-navigation: open/section/Close leave `history.length` and
canGoForward unchanged, Back lands before the page, Forward restores
page+Settings, Close keeps the visit; Close over a failed destination keeps
that visit; departure opens a new Personal Profile visit; cross-community
Back case now travels via a page). Notifications tests expect the
presented form. New `tests/browser/settings-history.spec.mjs` covers real
history.length, Back/Forward and reload; `launch-home` Closes instead of
goBack. Docs: shell-design and plugin-architecture state the rule and the
`overlay` contract.

Validation: `tsc --noEmit` clean; biome check clean on changed files.
vitest: navigation, notifications, entity-navigation, navigation.test,
App.profile, Settings, NotificationSettings, SearchSettings,
ChannelsPage.test, agents: 36 files, 515 passed. Playwright
settings-history, channel-members, launch-home, navigation-repairs,
settings specs: chromium 31/31, webkit 31/31 (the four-spec set also
passed 18/18 on both engines before the resume change). Full `vitest run`
twice under a load average of 47-61 from other work on this machine: run
one 7 failed / 11859 passed (App.profile x2, notifications x4 fixed above;
WorkflowEditor passed alone 22/22); run two 33 failed / 11835 passed, all
5-20 s timeouts in codex-sh, claude-sh, project-git, reminders and other
files this change does not touch; rerunning those ten files alone still
left 7 shell-spawn timeouts, so they are not shown green here. Not
exercised: the native desktop app or a human walkthrough. Known gap: on a
cold overlay visit (reload with Settings open, or Forward into one) the
shell beneath the modal is empty until Close, as it was for cold Settings
links before.

Rebase note: main (#1641) added a Navigation.open `dismiss` option, the
history snapshot `previous` entry and the browser driver's visit index so
Members could traverse back on close. After the earlier commits Members
writes in place and nothing calls `dismiss`, and this commit deletes the
driver `returnTo` it relied on, so that option, `previous`, the
controller's returning focus and their tests are removed with it.

Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>