Repository navigation
fix(settings): keep the chosen plugin row in place when details open or close - #1551
Merged
Merged
Conversation
…or close Since #1475 the Settings modal shows plugin details beside the catalog instead of over it. The catalog column narrows, rows above the chosen plugin reflow, and only browser scroll anchoring kept the row in view. That anchoring is not reliable: on close the Usage row jumped 286 px (from 312 px to 26 px in the scrollport), and the scrollTop check in settings.spec failed on main in both engines. Settings now records where the activated row sits before the details toggle and corrects the catalog scrollport by the whole-pixel drift in the next layout effect. The journey now checks the row's position in the scrollport, which is what the user sees, instead of a raw scrollTop that must change when the column narrows. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <[email protected]>
kalvinnchau
approved these changes
Oct 22, 2026
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 22, 2026
Co-authored-by: Aaron <f425b86c3b780d43f8d9cf1802429d04dd985bf92eac44fca9468b5ad3887c5e@buzz.block.builderlab.xyz> * origin/main: fix(channels): confirm a requested member when the relay stores bot (#1519) test(browser): settle dialog motion and startup errors before strict checks (#1492) perf(messages): measure read-tracking rows once per frame (#1527) fix(settings): keep the chosen plugin row in place when details open or close (#1551) fix(messages): polish reaction pills and mention badges (#1506) Signed-off-by: John Tennant <[email protected]>
This was referenced Oct 23, 2026
morgmart
added a commit
that referenced
this pull request
Oct 23, 2026
Signed-off-by: morgmart <[email protected]> Co-authored-by: Carl <c217fe6b9d958f41c3a5e030dccc7f626775a923089cb6491305eade75ea1f1b@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> * origin/main: (24 commits) Unify chat and channel access, tidy the Solo chat menu (#1446) fix(todos): render nested TODOs with collapsible hierarchy and Markdown (#1483) fix(agents): Allow agents to propose updates to agents (#1478) fix(composer): prevent plugins from updating the recipient on a WIP draft message (#1497) fix(agents): can't delete an agent belonging to an archived channel (#1560) Bump tokio to 1.53.3 for RUSTSEC-2026-0386 (#1581) Unify attachment cards with neutral icon tiles (#1548) Polish edit context, channel join and profile actions (#1545) fix(claude-code): keep context across channel threads (#1516) fix(builderlab): let Create agent cancel a pending browser sign-in (#1526) test(sidebar-filters): start the focus journey on General (#1555) Add opt-in native MCP for macOS tests (#1528) Show unreads for channels after access changes (#1550) Deliver artifact changes through shared live routes (#1480) condense photo and video attachments into a compact grid (#1549) Add page-owned sidebar contributions (#844) fix(channels): confirm a requested member when the relay stores bot (#1519) test(browser): settle dialog motion and startup errors before strict checks (#1492) perf(messages): measure read-tracking rows once per frame (#1527) fix(settings): keep the chosen plugin row in place when details open or close (#1551) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
settings.spec.mjsfailure on main ("plugin details preserves the catalog scroll position on open and close", Chromium and WebKit, run 39809018054).Why it broke
#1475 changed the Settings window so that plugin details appear beside the plugin list instead of over it. The list gets narrower, so the rows above the clicked row reflow and the list's scroll position must change to keep the row in place. Two things followed:
Details
Screenshots (WebKit, close right after open)