Skip to content

Drop the revision-check sentence from the Canvas intro - #1303

Open
jameskraus wants to merge 1 commit into
mainfrom
jkraus/canvas-intro-copy
Open

jameskraus wants to merge 1 commit into
mainfrom
jkraus/canvas-intro-copy

Conversation

@jameskraus

@jameskraus jameskraus commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Shorten the Canvas Edit intro to “Shared Markdown for this channel.”

Before After
Canvas intro with relay revision details Canvas intro with only the shared Markdown description

The captures crop the intro and predate the Canvas View tab; the copy is unchanged.

Bottom of a three-PR stack: this PR, then editor layout, then draft preview and unsaved status. The combined stack is exercised at the head of #1453.

Tried by the author in the native macOS app at the head of #1453.

buzz-review-completed

@jameskraus
jameskraus marked this pull request as ready for review October 21, 2026 01:09
@jameskraus
jameskraus requested a review from a team as a code owner October 21, 2026 01:09

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Star Lord’s automated source review via Wes’s account, integrating independent Rocket (systems/lifecycle), Mantis (correctness/security), and Groot (product/accessibility) reviews.

No actionable findings. 9/10 for this narrowly scoped copy change. The diff only shortens the introduction at src/bundled/canvas/CanvasEditor.tsx:229; revision arguments, conflict messages, draft retention, accessible labels, and recovery/focus handlers are unchanged. The description and both attached screenshots were inspected; no disclosure issue was found.

Reviewed head: 726d62246813d532345dd9be54d64371d90ebf8e
Base: d2f379f9a27a1917d65ccf27516c252b516d1cd6

Validation: pinned source/caller/test inspection and diff whitespace check only. No tests, builds, app execution, live relay checks, or CI assessment. Both-theme, narrow-width, enlarged-text and live keyboard/focus behavior remain unverified. This review covers this PR’s one-hunk diff and its surrounding behavior, not a complete re-audit of the stacked Canvas feature. This is a non-blocking COMMENT review, not approval or merge authorization.

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Reviewed head 726d62246 against base d2f379f9a. No findings. I checked that the removed sentence doesn't hide a caveat users can act on: canvas.save always pre-checks the loaded head and post-verifies the selected revision (capability.ts), whatever the relay supports, and conflicts already surface in the editor. No tests or other UI reference the old copy. Merge depends on #570 (red required CI and a docs conflict with main; see that review). This COMMENT is not an approval.

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Star Lord’s automated source review via Wes’s account, integrating independent Rocket (systems/lifecycle), Mantis (correctness/security/concurrency), and Groot (product/accessibility) lanes.

No new actionable findings. 9/10 for this narrowly scoped copy change. At src/bundled/channels/CanvasEditor.tsx:273, the intro now reads “Shared Markdown for this channel.” This follows the design guide’s Writing rule to remove detail that does not help someone decide or act. Revision preconditions, conflict alerts, draft preservation, archived read-only behavior, and recovery/focus handling remain intact in the current Channels-owned editor.

This follow-up checks the one-hunk PR diff and its relevant current integration after the Canvas move; it is not a complete re-audit of the stacked feature or all upstream changes. The public description and both attached screenshots were inspected; no disclosure finding.

Head: fa90597cf2134bd6b737d0602054b75913318683
Base: d580c242e386e9095ab29546a318bcb2782ca71e

Validation: pinned source/caller/test inspection and diff whitespace check only. No tests, builds, app execution, live relay checks, or CI assessment. Both themes, narrow/wide layout, enlarged text, native/browser keyboard and retry focus, performance, and human acceptance remain unverified. Non-blocking COMMENT only; not approval or merge authorization.

@jameskraus
jameskraus force-pushed the jkraus/canvas-intro-copy branch from fa90597 to 5a7b41b Compare October 21, 2026 19:36

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Star Lord’s automated source review via Wes’s account, integrating independent Rocket (systems/lifecycle), Mantis (correctness/security/concurrency), and Groot (product/accessibility) lanes.

No new actionable findings. 9/10 for this scoped copy change and its current integration. The one-hunk change at src/bundled/channels/CanvasEditor.tsx:273 follows DESIGN.md’s Writing guidance to remove detail that does not help someone decide or act. The Canvas editor and its capability/panel paths are unchanged from the previously reviewed fa90597cf2134bd6b737d0602054b75913318683; the newer endpoint changes add separate message-composer recipient commands. No interaction with the shortened Canvas introduction was found. Existing conflict messages, draft preservation, revision checks, and recovery/focus handling remain intact in source.

The public description and both attached screenshots were inspected; no disclosure finding. This is a review of the PR’s copy change and relevant integration, not a complete re-audit of the stacked feature or upstream composer changes.

Head: 5a7b41bf2e51e124c67a8227a0c13902aa6c070a
Base: 60ac65fc81eafcb2a7114e0cec478d87ce63010b

Validation: pinned source/caller/test inspection and diff whitespace check only. No tests, builds, app execution, live relay checks, or CI assessment. Native/browser behavior, both themes, narrow/wide layout, enlarged text, runtime keyboard/retry focus, performance, and human acceptance remain unverified. Non-blocking COMMENT only; not approval or merge authorization.

@jameskraus
jameskraus marked this pull request as draft October 26, 2026 18:10
@jameskraus
jameskraus force-pushed the jkraus/canvas-intro-copy branch 3 times, most recently from 4dd5777 to d984207 Compare October 27, 2026 18:44
@jameskraus
jameskraus changed the base branch from jkraus/canvas-tabs to main October 27, 2026 18:44
@jameskraus jameskraus closed this Oct 27, 2026
@jameskraus jameskraus reopened this Oct 27, 2026
@jameskraus
jameskraus marked this pull request as ready for review October 27, 2026 22:07

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Star Lord’s automated source review via Wes’s account: no changes requested. The intro-only patch is unchanged from the previous review, and its integration preserves the editor’s conflict/recovery messaging; both updated screenshots were inspected. Reviewed head d984207aeeb6b70beeb37bab67181685d5b38069 against base b0c92eaee3c0f4bbf2551ed6bf009b24ae4283de under the small unchanged-follow-up exception. Source and attachment review only: no tests or app execution, CI not independently assessed, and native/live-relay behavior and human acceptance remain unverified.

@jameskraus
jameskraus added this pull request to stack #3301 November 11, 2026 20:04
@jameskraus
jameskraus force-pushed the jkraus/canvas-intro-copy branch from d984207 to 3fdbfb6 Compare November 11, 2026 20:27
@jameskraus
jameskraus marked this pull request as draft November 11, 2026 20:27
@jameskraus
jameskraus marked this pull request as ready for review November 11, 2026 21:00

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

Reviewed head 3fdbfb6dd. No findings. The copy-only hunk is unchanged from the previous review, and it still merges cleanly onto current main (ab344439a). Stack-wide rebase notes are on #1304 and #1453. This COMMENT is not an approval.

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, approving via Wes's GitHub account at Wes's request. Approved at 3fdbfb6dd. No findings; merges cleanly onto main.

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Review from Will's agents (Paul and Thufir, reviewing independently, consolidated by Paul).

No findings at 3fdbfb6dd. It still merges cleanly onto current main after #3319, and the merged diff is still just the one intro paragraph. Nothing in src/, tests/ or docs/ depends on the removed sentence. The conflict, reload and read-only draft notices are unchanged.

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Approving on Will's behalf at 3fdbfb6dd. No findings; see the earlier review.

"Saves and restores check the loaded revision on supporting relays"
describes the relay compare-and-swap rather than anything a reader can
act on. When a save conflicts, the editor already says so and keeps the
draft.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: James Kraus <[email protected]>
@jameskraus
jameskraus force-pushed the jkraus/canvas-intro-copy branch from 3fdbfb6 to 2564d5d Compare November 13, 2026 01:46

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants