Repository navigation
test(browser): let dnd-kit see its first resize before text shrinks - #1150
Merged
Merged
Conversation
The group drag text-size test changed the root font size right after the drop edge appeared. dnd-kit starts each droppable's ResizeObserver when a drag starts and ignores the first notification as the initial size. On a slow WebKit runner no rendering update ran between drag start and the text change, so both arrived as one notification. dnd-kit ignored it, kept the 32px rects, and the pointer over Unavailable's new header never hit. Wait two animation frames before shrinking the text so the initial notification is delivered on its own. Holding ResizeObserver delivery across the change reproduces the CI failure locally; releasing it before the change passes. Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz> Signed-off-by: Logan Johnson <[email protected]>
loganj
marked this pull request as ready for review
October 15, 2026 00:02
kalvinnchau
approved these changes
Oct 15, 2026
kalvinnchau
left a comment
Contributor
There was a problem hiding this comment.
🤖 LGTM. Verified against @dnd-kit/core 6.3.1 useDroppable: handleResize drops the first ResizeObserver callback after observe(), so a coalesced initial+resize notification loses the remeasure. Double rAF guarantees one rendering update (and its RO delivery) before the font-size change. Matches the existing pattern in tests/browser/appearance.spec.mjs. Test-only change; CI green.
johnmatthewtennant
added a commit
that referenced
this pull request
Oct 15, 2026
…-drag * origin/main: (34 commits) fix(channels): resolve template agents from ready inventory (#922) [buzz-app] Fit uploaded videos to the relay's 4K envelope and name video rejections (#1129) feat(github): reveal the PR comment a link points at (#947) fix(messages): stop WebKit freeze from muted composer video previews (#1143) test(browser): fix route-unroute and virtua-hold webkit flakes (#1149) test(browser): let dnd-kit see its first resize before text shrinks (#1150) fix(previews): keep a hovered preview through scroll anchoring (#1138) Unify owned agent profile panels (#1083) feat(agents): import old Buzz teams from the Teams tab (#985) Mark Me chats as personal in the session description for remote agents (#1058) feat(messages): optional way to open buzz message links in a thread tab (#1113) Distinguish thread originals and tighten conversation spacing (#929) fix(buzz-mcp): page channel reads past the relay limit (#1131) fix(inbox): show a session's top-level timeline as one conversation (#1094) feat: reorder sidebar groups by dragging their headers (#1118) fix(avatars): request the cached relay thumbnail at every avatar site (#1054) fix(messages): soften quote styling and tighten spacing (#1098) fix(emoji): shrink and raise inline custom emoji (#1097) fix: follow host theme in media review chrome (#1117) Highlight an already-open thread tab when reopening it (#1050) ... Signed-off-by: John Tennant <[email protected]> Co-authored-by: Claude Worker <f425b86c3b780d43f8d9cf1802429d04dd985bf92eac44fca9468b5ad3887c5e@buzz.block.builderlab.xyz> # Conflicts: # src/features/channel-navigation/ChannelSidebarDnd.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
main(e10c4ee, run 38652866838) in the sidebar test that drags one group's header onto another while the text size changes. After the text shrank, the pointer sat over the target group's new header, but the drop line never showed up.Details
data-drop-edgestayed null at the same assertion). When I sent the held callback before the text change, the test passed.