Skip to content

Attention follow-ups: deferred review findings from #2860 #2903

Open

Description

@johnmatthewtennant

Follow-up to Attention follow-ups, which deferred these review findings (from Auto's review and Logan's inline notes). None blocked the merge.

  • Watch rows still label a nameless watch from the slug. WatchRow.tsx:99 uses title(watch.interest_id), so a card titled "Release checks" with id rel-ci has rows and aria-labels that say "rel ci" ("Delete rel ci"). Share the card's rule (title, then heading, then slug) from Tab.tsx:252.
  • Resuming a paused Interest drops a skipped watch's saved progress. When the Interest becomes readable again, store.ts:488 returns watch and discards interest_paused.{timer,history,completed}. An over-limit timer in a paused Interest loses used on resume, so a reader with a higher limit restarts its max_occurrences budget. (thread)
  • Route buzz: and nostr:nprofile links in Interest instructions in-app. Only nostr:npub1… opens in the app; everything else goes to target="_blank", though interest_set asks agents to link messages and channels. Activity already routes buzz: links with buzzLinkTarget. Treat nprofile like npub, route buzz: the same way, and show other nostr: links as text. (thread)
  • Keep title and summary when interest_set omits them. paused survives an instructions-only write, but an omitted title or summary is cleared (attention.ts:365), so an agent that only updates instructions silently turns its card back into the slug. Keep them when omitted; clear on an explicit "". (thread)
  • Timers that fired before feat(attention): Interest titles, summaries and named people, and Activity and pause fixes #2860 still say "No activity yet". Their history has only lastWokeAt. Fall back to "Last fired " when it is set (Activity.tsx:328). (thread)
  • Memoize Activity row text. plainText(entry.text) parses up to 4 KB of Markdown per row on every render. useMemo on entry.text covers it. (thread)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions