You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fbc3c57
Browse filesBrowse the repository at this point in the historyBrowse files
refactor(navigation): remove the buzz://open locator codec
`buzz://open?target=<json>` is no longer a Buzz link anywhere in buzz-app.
`parseBuzzLink` returns null for it, so in message content it is plain text
like any other unknown host, and the OS ingress fails it as `invalid-target`
through the same null check as `buzz://join` or `buzz://unknown` instead of a
dedicated refusal. The codec itself is gone from targets.ts: `SharedTarget`,
`parseSharedTarget`, `bindSharedTarget`, `targetLink` and `parseTargetLink`,
along with the `shared` format in buzz-links.ts and the `LocatorScope` type it
existed for; `OpenTarget` is now the only target shape and `parseOpenTarget`
binds scopes directly.
Behaviour change: existing in-app `buzz://open` links in old messages stop
opening and lose their preview and channel label, and `@buzz/author` no longer
exports the `SharedTarget` type. No in-repo plugin imported it. The `#buzz=`
browser address, `parseOpenTarget` and browser-history.ts are untouched; they
share the JSON target shape, not the URL codec. Copy link already emitted
`buzz://message`, so its comment is the only change there.
The original Buzz desktop client never had this form. It was introduced in
PR #18, refused at the OS boundary in PR #208, and is now removed. MessageLink
and ReferenceText keep their message and channel handling with the type
narrowing simplified; channelForLink/channelLinkLabel drop the scope parameter
they only used for locator community checks. Link Lab demonstrates the same
in-app links with `buzz://channel/general` and a `buzz://message` thread link,
and docs/deep-links.md, docs/plugin-architecture.md and the Link Lab README
describe unknown hosts as rejected everywhere rather than in-app only.
One negative test per parser layer pins the removal with a literal
`buzz://open?target=…` string: parseBuzzLink returns null, deepLinkStep fails
`invalid-target`, message-link-parts leaves it as plain text, and InlineLink
renders it as text. The open PR #401 adds a test in entity-navigation.test.tsx
that calls bindSharedTarget/parseTargetLink/targetLink; it will conflict with
this commit and needs rewriting against parseOpenTarget when it lands.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>
0 commit comments