Repository navigation
Commit f759d75
fix(channels): keep muted DM names from becoming bold (#2184)
## Problem
Muted channels stay quiet when new messages arrive, but muted DMs still
become bold. The two behave inconsistently.
## Solution
Apply the same confirmed-mute rule to DM name emphasis. Unmuting
restores unread emphasis, and manual unread still makes the name bold
without clearing unread evidence. The bells and hidden muted unread dots
from [#2175](#2175)
are already on `main` and remain in place.
## Test steps
- `bin/pnpm exec vitest run
src/bundled/channels/ChannelSidebarItem.test.tsx
src/app/shell/BestieNavigation.test.tsx`: 21 passed on `49afe73a9`.
Restoring the old DM rule makes the regression checks fail. No browser
test cases added or removed.
- Required push checks passed on `49afe73a9`, including TypeScript,
related unit tests, and design checks. Independent review found no
blockers.
- Production-component browser previews checked both themes,
390px/1200px widths, 200% text, keyboard/pointer selection, and
mute/unmute recovery. The muted DM loses boldness while its bell stays
visible and unread dots stay hidden.
- Human/native acceptance pending: mute a DM, receive a message, confirm
its name stays regular-weight, then unmute and confirm unread emphasis
returns.
## Videos and Screenshots
Production sidebar component with synthetic unread messages. Before is
`main` at `baea050c6`; after is `49afe73a9`, at identical dimensions.
Only the muted DM name’s weight changes. Live-account/native integration
remains unverified.
| Before | After |
| --- | --- |
| 
| 
|
---------
Signed-off-by: Laney Pouzet <[email protected]>
Co-authored-by: Codex <[email protected]>1 parent 39d61cd commit f759d75
6 files changed
Lines changed: 12 additions & 18 deletions
File tree
- docs
- src
- app/shell
- bundled/channels
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
123 | 123 | | |
124 | 124 | | |
125 | 125 | | |
126 | | - | |
| 126 | + | |
127 | 127 | | |
128 | 128 | | |
129 | 129 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
84 | 84 | | |
85 | 85 | | |
86 | 86 | | |
87 | | - | |
88 | | - | |
| 87 | + | |
| 88 | + | |
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
170 | 170 | | |
171 | 171 | | |
172 | 172 | | |
173 | | - | |
174 | | - | |
| 173 | + | |
| 174 | + | |
175 | 175 | | |
176 | 176 | | |
177 | 177 | | |
178 | 178 | | |
179 | 179 | | |
180 | | - | |
| 180 | + | |
181 | 181 | | |
182 | 182 | | |
183 | 183 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
422 | 422 | | |
423 | 423 | | |
424 | 424 | | |
425 | | - | |
426 | | - | |
427 | | - | |
428 | | - | |
| 425 | + | |
429 | 426 | | |
430 | 427 | | |
431 | 428 | | |
| |||
440 | 437 | | |
441 | 438 | | |
442 | 439 | | |
443 | | - | |
444 | | - | |
445 | | - | |
446 | | - | |
| 440 | + | |
447 | 441 | | |
448 | 442 | | |
449 | 443 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
631 | 631 | | |
632 | 632 | | |
633 | 633 | | |
634 | | - | |
| 634 | + | |
635 | 635 | | |
636 | | - | |
| 636 | + | |
637 | 637 | | |
638 | 638 | | |
639 | 639 | | |
| |||
651 | 651 | | |
652 | 652 | | |
653 | 653 | | |
654 | | - | |
| 654 | + | |
655 | 655 | | |
656 | 656 | | |
657 | 657 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
23 | | - | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
0 commit comments