Repository navigation
Commit f3906b9
fix(links): stop a message preview claiming a deletion it never saw
A well-formed message link whose ID wasn't in a readable channel said
"This message was deleted." readTarget in threads.ts returns
`unavailable` as soon as the exact read has no matching event, before it
reads any tombstone, and threadFailure maps that to `not-found`. A
nonexistent ID, or a message ID paired with the wrong channel, got the
same definite deletion claim as a deleted message.
The not-found text is now "This message isn't available. It may have
been deleted." No reader path tells an observed deletion apart from an
empty read: a tombstone that hides the target also ends as
`targetStatus: unavailable`. So no case keeps the definite wording, and
the reader is unchanged. MessageLink's tooltip uses only the withheld
text, and ThreadPanel passes the reason code to navigation, whose page
already says "This message isn't available.", so neither changes.
buzz-help follows.
The preview test for a readable channel without the message now checks
the wording itself. It fails with the old text.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>1 parent f3a29f3 commit f3906b9
3 files changed
Lines changed: 10 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
173 | 173 | | |
174 | 174 | | |
175 | 175 | | |
176 | | - | |
| 176 | + | |
| 177 | + | |
177 | 178 | | |
178 | 179 | | |
179 | 180 | | |
180 | 181 | | |
181 | 182 | | |
182 | 183 | | |
183 | | - | |
| 184 | + | |
| 185 | + | |
| 186 | + | |
184 | 187 | | |
185 | 188 | | |
186 | 189 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
25 | 25 | | |
26 | 26 | | |
27 | 27 | | |
28 | | - | |
| 28 | + | |
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
| |||
0 commit comments