You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit e607882
Browse filesBrowse the repository at this point in the historyBrowse files
fix(links): look up a public channel the viewer left before previewing its message
After the viewer joined and then left a public channel, hovering a link
to one of its messages failed. Discovery denies the old admission until
a fresh lookup confirms the channel is still open, but describeReference
answered `found` from its cached open metadata. lookUpReference skipped
found answers, and useChannelReference only demanded a lookup while an
answer wasn't found, so no lookup or read ever ran. The preview showed
"Couldn't load this preview." on every hover, while a click, which
resolves the channel, opened the message.
Admission now decides. A channel named only by its open metadata answers
`found` with `readable: false`, and `looking: true` while its lookup is
queued or in flight, so a link keeps the name. lookUpReference skips a
channel only when discovery admits it. useChannelReference demands a
lookup until the answer is readable. A lookup that still admits nothing
is kept in `withheld` for the usual five minutes, as a withheld answer
is.
BuzzLinkPreview keys its read on readability instead of `found`, so it
reads again when the lookup admits the channel, even though the metadata
is unchanged. It waits while that lookup is on the way.
A channel-only link to a left public channel now runs one background
lookup too. Once admitted, its hover card can show the member count, as
it already does for an unjoined channel that has been resolved.
The store test that expected no lookup for a left channel now covers
leave, refer, the found-and-looking answer, and readable recovery. A
preview test covers a left channel that the lookup admits again. Both
fail on the previous commit.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>
0 commit comments