@@ -31,6 +31,7 @@ const metadata = `<details><summary>before.mp4</summary><video src="${signedBefo
3131
3232afterEach ( ( ) => {
3333 cleanup ( ) ;
34+ vi . useRealTimers ( ) ;
3435 vi . unstubAllGlobals ( ) ;
3536 vi . restoreAllMocks ( ) ;
3637} ) ;
@@ -271,7 +272,7 @@ it("takes a signed link only when media's own link fails, renewing it when that
271272 expect ( container . querySelector ( "video" ) ) . toBe ( video ) ;
272273 expect ( video ) . toHaveAttribute ( "src" , before ) ;
273274 await act ( async ( ) => read . resolve ( ) ) ;
274- // A renewed link that fails before loading does not read again.
275+ // A renewed link that fails before loading does not read again at once .
275276 fireEvent . error ( screen . getByAltText ( "Screenshot" ) ) ;
276277 expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
277278} ) ;
@@ -312,6 +313,186 @@ it("reads again after a failed renewal, one read at a time", async () => {
312313 expect ( refresh ) . toHaveBeenCalledTimes ( 2 ) ;
313314} ) ;
314315
316+ const privateImage = ( jwt : string ) =>
317+ `<img src="${ signedImage ( jwt ) } " alt="Screenshot">` ;
318+ const privateBody = `` ;
319+ const settle = ( ) => act ( async ( ) => { } ) ;
320+ const wait = ( ms : number ) =>
321+ act ( async ( ) => {
322+ await vi . advanceTimersByTimeAsync ( ms ) ;
323+ } ) ;
324+ // Its own link fails, then its signed link: one read.
325+ const failTwice = ( ) => {
326+ fireEvent . error ( screen . getByAltText ( "Screenshot" ) ) ;
327+ fireEvent . error ( screen . getByAltText ( "Screenshot" ) ) ;
328+ } ;
329+
330+ it ( "reads again 30 seconds after a failed renewal, three times at most" , async ( ) => {
331+ vi . useFakeTimers ( ) ;
332+ const refresh = vi . fn ( ( ) => Promise . reject ( new Error ( "Not Found" ) ) ) ;
333+ render (
334+ < GitHubBody
335+ url = { url }
336+ body = { privateBody }
337+ bodyHtml = { privateImage ( "1" ) }
338+ refresh = { refresh }
339+ /> ,
340+ ) ;
341+ failTwice ( ) ;
342+ expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
343+ await settle ( ) ;
344+ await wait ( 29_999 ) ;
345+ expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
346+ await wait ( 1 ) ;
347+ expect ( refresh ) . toHaveBeenCalledTimes ( 2 ) ;
348+ await wait ( 30_000 ) ;
349+ await wait ( 30_000 ) ;
350+ expect ( refresh ) . toHaveBeenCalledTimes ( 4 ) ;
351+ // Then it stops, leaving the original link.
352+ await wait ( 5 * 60_000 ) ;
353+ expect ( refresh ) . toHaveBeenCalledTimes ( 4 ) ;
354+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
355+ expect ( screen . getByRole ( "link" , { name : "Screenshot" } ) ) . toHaveAttribute (
356+ "href" ,
357+ image ,
358+ ) ;
359+ } ) ;
360+
361+ it ( "stops retrying once a renewed link loads, and retries afresh after" , async ( ) => {
362+ vi . useFakeTimers ( ) ;
363+ let reads = 0 ;
364+ const refresh = vi . fn ( async ( ) => {
365+ reads += 1 ;
366+ if ( reads !== 2 ) throw new Error ( "Not Found" ) ;
367+ view . rerender (
368+ < GitHubBody
369+ url = { url }
370+ body = { privateBody }
371+ bodyHtml = { privateImage ( "2" ) }
372+ refresh = { refresh }
373+ /> ,
374+ ) ;
375+ } ) ;
376+ const view = render (
377+ < GitHubBody
378+ url = { url }
379+ body = { privateBody }
380+ bodyHtml = { privateImage ( "1" ) }
381+ refresh = { refresh }
382+ /> ,
383+ ) ;
384+ failTwice ( ) ;
385+ await settle ( ) ;
386+ await wait ( 30_000 ) ;
387+ expect ( refresh ) . toHaveBeenCalledTimes ( 2 ) ;
388+ expect ( screen . getByAltText ( "Screenshot" ) ) . toHaveAttribute (
389+ "src" ,
390+ signedImage ( "2" ) ,
391+ ) ;
392+ fireEvent . load ( screen . getByAltText ( "Screenshot" ) ) ;
393+ await wait ( 5 * 60_000 ) ;
394+ expect ( refresh ) . toHaveBeenCalledTimes ( 2 ) ;
395+ // When it expires later it reads at once, then has three retries again.
396+ fireEvent . error ( screen . getByAltText ( "Screenshot" ) ) ;
397+ expect ( refresh ) . toHaveBeenCalledTimes ( 3 ) ;
398+ await settle ( ) ;
399+ await wait ( 5 * 60_000 ) ;
400+ expect ( refresh ) . toHaveBeenCalledTimes ( 6 ) ;
401+ } ) ;
402+
403+ it ( "cancels a pending retry on unmount, and schedules none after it" , async ( ) => {
404+ vi . useFakeTimers ( ) ;
405+ const refresh = vi . fn ( ( ) => Promise . reject ( new Error ( "Not Found" ) ) ) ;
406+ const first = render (
407+ < GitHubBody
408+ url = { url }
409+ body = { privateBody }
410+ bodyHtml = { privateImage ( "1" ) }
411+ refresh = { refresh }
412+ /> ,
413+ ) ;
414+ failTwice ( ) ;
415+ await settle ( ) ;
416+ expect ( vi . getTimerCount ( ) ) . toBe ( 1 ) ;
417+ first . unmount ( ) ;
418+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
419+ await wait ( 60_000 ) ;
420+ expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
421+
422+ const read = deferred < void > ( ) ;
423+ const pending = vi . fn ( ( ) => read . promise ) ;
424+ const second = render (
425+ < GitHubBody
426+ url = { url }
427+ body = { privateBody }
428+ bodyHtml = { privateImage ( "1" ) }
429+ refresh = { pending }
430+ /> ,
431+ ) ;
432+ failTwice ( ) ;
433+ second . unmount ( ) ;
434+ await act ( async ( ) => read . reject ( new Error ( "Not Found" ) ) ) ;
435+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
436+ await wait ( 60_000 ) ;
437+ expect ( pending ) . toHaveBeenCalledOnce ( ) ;
438+ } ) ;
439+
440+ it ( "never schedules a retry for public media or media whose own link loads" , async ( ) => {
441+ vi . useFakeTimers ( ) ;
442+ const refresh = vi . fn ( ( ) => Promise . reject ( new Error ( "Not Found" ) ) ) ;
443+ render (
444+ < GitHubBody
445+ url = { url }
446+ body = { `\n\n` }
447+ bodyHtml = { `<img src="${ image } " alt="Asset"><img src="https://private-user-images.githubusercontent.com/1888043/2-dd1f7e4f-e2a4-4aec-b661-cb45032f29c5.png?jwt=1" alt="Screenshot">` }
448+ refresh = { refresh }
449+ /> ,
450+ ) ;
451+ fireEvent . error ( screen . getByAltText ( "Asset" ) ) ;
452+ fireEvent . load ( screen . getByAltText ( "Screenshot" ) ) ;
453+ expect ( screen . getByAltText ( "Screenshot" ) ) . toHaveAttribute ( "src" , after ) ;
454+ await settle ( ) ;
455+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
456+ await wait ( 5 * 60_000 ) ;
457+ expect ( refresh ) . not . toHaveBeenCalled ( ) ;
458+ } ) ;
459+
460+ it ( "tries a link a poll delivers before the retry instead of reading again" , async ( ) => {
461+ vi . useFakeTimers ( ) ;
462+ const refresh = vi . fn ( ( ) => Promise . reject ( new Error ( "Not Found" ) ) ) ;
463+ const { rerender } = render (
464+ < GitHubBody
465+ url = { url }
466+ body = { privateBody }
467+ bodyHtml = { privateImage ( "1" ) }
468+ refresh = { refresh }
469+ /> ,
470+ ) ;
471+ failTwice ( ) ;
472+ await settle ( ) ;
473+ await wait ( 10_000 ) ;
474+ // A PR poll brings a newer link; the failed image takes it.
475+ rerender (
476+ < GitHubBody
477+ url = { url }
478+ body = { privateBody }
479+ bodyHtml = { privateImage ( "2" ) }
480+ refresh = { refresh }
481+ /> ,
482+ ) ;
483+ expect ( screen . getByAltText ( "Screenshot" ) ) . toHaveAttribute (
484+ "src" ,
485+ signedImage ( "2" ) ,
486+ ) ;
487+ // Still loading when the retry is due: nothing is read.
488+ await wait ( 20_000 ) ;
489+ expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
490+ fireEvent . load ( screen . getByAltText ( "Screenshot" ) ) ;
491+ await wait ( 5 * 60_000 ) ;
492+ expect ( refresh ) . toHaveBeenCalledOnce ( ) ;
493+ expect ( vi . getTimerCount ( ) ) . toBe ( 0 ) ;
494+ } ) ;
495+
315496it ( "keeps public and raw media on their own links without reading again" , ( ) => {
316497 const raw = "https://raw.githubusercontent.com/block/buzz-app/main/icon.png" ;
317498 const refresh = vi . fn ( ) ;
0 commit comments