Skip to content

Commit db46f02

Browse files
author
Carl
committed
Keep keyboard activity previews open past stale hover dismissal
Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
1 parent b9ad8df commit db46f02

2 files changed

Lines changed: 20 additions & 0 deletions

File tree

‎src/bundled/channels/ChannelActivityPopover.tsx‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -196,6 +196,7 @@ export function ChannelActivityPopover({
196196
const agentIds = activeAgents.join(",");
197197
const [open, setOpen] = useState(false);
198198
const triggerPointerType = useRef<string | null>(null);
199+
const pressedOpen = useRef(false);
199200
const [now, setNow] = useState(() => Date.now());
200201
useEffect(() => {
201202
if (!open || !activeAgents.length) return;
@@ -253,6 +254,16 @@ export function ChannelActivityPopover({
253254
return;
254255
}
255256
}
257+
// A queued hover dismissal must not close a newer keyboard/touch opening.
258+
if (
259+
!next &&
260+
details.reason === "trigger-hover" &&
261+
pressedOpen.current
262+
) {
263+
details.cancel();
264+
return;
265+
}
266+
pressedOpen.current = next && details.reason === "trigger-press";
256267
setOpen(next);
257268
if (next) setNow(Date.now());
258269
if (next && items.length)

‎tests/browser/me-workspace.spec.mjs‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,17 @@ test("Me sidebar shares working activity, keyboard preview and local panel navig
156156
.getByRole("button", { name: "Close Agent Activity tab", exact: true })
157157
.click();
158158
await expect(alpha).toBeFocused();
159+
await page.clock.install();
160+
await page.clock.pauseAt(new Date());
161+
// Cross the closed trigger, then reopen by keyboard before hover dismissal.
162+
await alpha.hover();
159163
await page.mouse.move(0, 0);
160164
await alpha.press("Enter");
165+
await expect(alpha).toHaveAttribute("aria-expanded", "true");
166+
await expect(popup).toBeVisible();
167+
// Run past the 150ms hover-close deadline, not a wall-clock wait.
168+
await page.clock.runFor(200);
169+
await page.clock.resume();
161170
await expect(popup).toBeVisible();
162171
const activityAction = popup.getByRole("button", {
163172
name: /View .+ activity/,

0 commit comments

Comments
 (0)