@@ -28,8 +28,22 @@ pub struct Manifest {
2828 pub name : String ,
2929 pub api_version : u32 ,
3030 #[ serde( default , skip_serializing_if = "Option::is_none" ) ]
31+ pub description : Option < String > ,
32+ #[ serde( default , skip_serializing_if = "Option::is_none" ) ]
33+ pub discovery : Option < Discovery > ,
34+ #[ serde( default , skip_serializing_if = "Option::is_none" ) ]
3135 pub host : Option < HostGrants > ,
3236}
37+ /// Display-only metadata is deliberately forward-compatible. Unknown fields are
38+ /// ignored so adding a discovery hint does not make a plugin unloadable.
39+ #[ derive( Clone , Debug , Default , Deserialize , Serialize , PartialEq , Eq ) ]
40+ #[ serde( rename_all = "camelCase" ) ]
41+ pub struct Discovery {
42+ #[ serde( default , skip_serializing_if = "Option::is_none" ) ]
43+ pub category : Option < String > ,
44+ #[ serde( default , skip_serializing_if = "Vec::is_empty" ) ]
45+ pub tags : Vec < String > ,
46+ }
3347#[ derive( Clone , Debug , Default , Deserialize , Serialize , PartialEq , Eq ) ]
3448#[ serde( rename_all = "camelCase" , deny_unknown_fields) ]
3549pub struct HostGrants {
@@ -94,9 +108,41 @@ impl Manifest {
94108 if self . name . trim ( ) . is_empty ( ) || self . name . len ( ) > 80 {
95109 return Err ( "Name must contain 1–80 bytes of text" . into ( ) ) ;
96110 }
111+ if self
112+ . description
113+ . as_ref ( )
114+ . is_some_and ( |description| description. trim ( ) . is_empty ( ) || description. len ( ) > 280 )
115+ {
116+ return Err ( "Description must contain 1–280 bytes of text" . into ( ) ) ;
117+ }
97118 if self . api_version != 1 {
98119 return Err ( "Only page plugin API version 1 is supported" . into ( ) ) ;
99120 }
121+ if let Some ( discovery) = & self . discovery {
122+ if let Some ( category) = & discovery. category {
123+ valid_id ( category) ?;
124+ }
125+ if discovery. tags . len ( ) > 16 {
126+ return Err ( "Too many discovery tags" . into ( ) ) ;
127+ }
128+ let mut tags = std:: collections:: HashSet :: new ( ) ;
129+ for tag in & discovery. tags {
130+ if tag. trim ( ) . is_empty ( ) || tag. len ( ) > 80 || tag. chars ( ) . any ( char:: is_control) {
131+ return Err (
132+ "Discovery tags must contain 1–80 bytes of text without control characters"
133+ . into ( ) ,
134+ ) ;
135+ }
136+ let key = tag
137+ . split_whitespace ( )
138+ . collect :: < Vec < _ > > ( )
139+ . join ( " " )
140+ . to_lowercase ( ) ;
141+ if !tags. insert ( key) {
142+ return Err ( "Duplicate discovery tag" . into ( ) ) ;
143+ }
144+ }
145+ }
100146 if let Some ( host) = & self . host {
101147 if host. commands . len ( ) > 16
102148 || host. network_origins . len ( ) > 16
@@ -1303,6 +1349,123 @@ mod tests {
13031349 }
13041350 }
13051351
1352+ #[ test]
1353+ fn validates_discovery_metadata_and_old_manifests ( ) {
1354+ let old: Manifest =
1355+ serde_json:: from_str ( r#"{"id":"example.page","name":"Example","apiVersion":1}"# )
1356+ . unwrap ( ) ;
1357+ assert_eq ! ( old. description, None ) ;
1358+ assert_eq ! ( old. discovery, None ) ;
1359+ assert ! ( old. validate( ) . is_ok( ) ) ;
1360+ assert_eq ! (
1361+ serde_json:: to_value( & old) . unwrap( ) ,
1362+ serde_json:: json!( { "id" : "example.page" , "name" : "Example" , "apiVersion" : 1 } )
1363+ ) ;
1364+
1365+ let manifest = serde_json:: json!( {
1366+ "id" : "example.page" ,
1367+ "name" : "Example" ,
1368+ "apiVersion" : 1 ,
1369+ "description" : "Reconcile invoices without leaving Buzz." ,
1370+ "discovery" : {
1371+ "category" : "finance" ,
1372+ "tags" : [ "accounting" , "invoices" ] ,
1373+ "futureDisplayHint" : true
1374+ }
1375+ } ) ;
1376+ let parsed: Manifest = serde_json:: from_value ( manifest) . unwrap ( ) ;
1377+ assert ! ( parsed. validate( ) . is_ok( ) ) ;
1378+ assert_eq ! (
1379+ parsed. description. as_deref( ) ,
1380+ Some ( "Reconcile invoices without leaving Buzz." )
1381+ ) ;
1382+ assert_eq ! (
1383+ parsed. discovery. as_ref( ) . unwrap( ) . category. as_deref( ) ,
1384+ Some ( "finance" )
1385+ ) ;
1386+ assert_eq ! (
1387+ parsed. discovery. as_ref( ) . unwrap( ) . tags,
1388+ [ "accounting" , "invoices" ]
1389+ ) ;
1390+ assert ! ( !serde_json:: to_string( & parsed)
1391+ . unwrap( )
1392+ . contains( "futureDisplayHint" ) ) ;
1393+
1394+ for description in [ "" . into ( ) , " " . into ( ) , "x" . repeat ( 281 ) ] {
1395+ let mut invalid = parsed. clone ( ) ;
1396+ invalid. description = Some ( description) ;
1397+ assert ! ( invalid. validate( ) . is_err( ) ) ;
1398+ }
1399+ for category in [ "" , "Finance" , "finance_tools" ] {
1400+ let mut invalid = parsed. clone ( ) ;
1401+ invalid. discovery . as_mut ( ) . unwrap ( ) . category = Some ( category. into ( ) ) ;
1402+ assert ! ( invalid. validate( ) . is_err( ) ) ;
1403+ }
1404+ let mut duplicate = parsed. clone ( ) ;
1405+ duplicate. discovery . as_mut ( ) . unwrap ( ) . tags = vec ! [ "finance" . into( ) , "finance" . into( ) ] ;
1406+ assert ! ( duplicate. validate( ) . is_err( ) ) ;
1407+ let mut too_many = parsed. clone ( ) ;
1408+ too_many. discovery . as_mut ( ) . unwrap ( ) . tags =
1409+ ( 0 ..17 ) . map ( |index| format ! ( "tag-{index}" ) ) . collect ( ) ;
1410+ assert ! ( too_many. validate( ) . is_err( ) ) ;
1411+
1412+ let unknown_top_level = serde_json:: json!( {
1413+ "id" : "example.page" ,
1414+ "name" : "Example" ,
1415+ "apiVersion" : 1 ,
1416+ "futureSecurityField" : true
1417+ } ) ;
1418+ assert ! ( serde_json:: from_value:: <Manifest >( unknown_top_level) . is_err( ) ) ;
1419+ }
1420+
1421+ #[ test]
1422+ fn discovery_tags_accept_readable_text_and_preserve_display_spelling ( ) {
1423+ let text = serde_json:: json!( {
1424+ "id" : "example.page" , "name" : "Example" , "apiVersion" : 1 ,
1425+ "discovery" : {
1426+ "category" : "finance" ,
1427+ "tags" : [ "Programming Language" , " Café Tools " , "编程" , "C++" , "🛠️" ]
1428+ }
1429+ } ) ;
1430+ let manifest: Manifest = serde_json:: from_value ( text. clone ( ) ) . unwrap ( ) ;
1431+ assert ! ( manifest. validate( ) . is_ok( ) ) ;
1432+ assert_eq ! ( serde_json:: to_value( & manifest) . unwrap( ) , text) ;
1433+ let bytes = artifact_from_text ( & text. to_string ( ) , "export const code = 1" . into ( ) ) . unwrap ( ) ;
1434+ let artifact: super :: Artifact = serde_json:: from_slice ( & bytes) . unwrap ( ) ;
1435+ assert_eq ! ( artifact. manifest, manifest) ;
1436+
1437+ for tag in [ "x" . repeat ( 80 ) , "é" . repeat ( 40 ) ] {
1438+ let mut valid = manifest. clone ( ) ;
1439+ valid. discovery . as_mut ( ) . unwrap ( ) . tags = vec ! [ tag] ;
1440+ assert ! ( valid. validate( ) . is_ok( ) ) ;
1441+ }
1442+ for tag in [
1443+ "" . into ( ) ,
1444+ " " . into ( ) ,
1445+ "\u{a0} " . into ( ) ,
1446+ "x" . repeat ( 81 ) ,
1447+ "é" . repeat ( 41 ) ,
1448+ "Programming\n Language" . into ( ) ,
1449+ "Programming\t Language" . into ( ) ,
1450+ "Bad\0 Tag" . into ( ) ,
1451+ "Bad\u{7f} Tag" . into ( ) ,
1452+ ] {
1453+ let mut invalid = manifest. clone ( ) ;
1454+ invalid. discovery . as_mut ( ) . unwrap ( ) . tags = vec ! [ tag] ;
1455+ assert ! ( invalid. validate( ) . is_err( ) ) ;
1456+ }
1457+ for pair in [
1458+ [ "Programming Language" , "programming language" ] ,
1459+ [ "Programming Language" , " Programming Language " ] ,
1460+ [ "Programming Language" , "Programming\u{a0} Language" ] ,
1461+ [ "Café" , "CAFÉ" ] ,
1462+ ] {
1463+ let mut duplicate = manifest. clone ( ) ;
1464+ duplicate. discovery . as_mut ( ) . unwrap ( ) . tags = pair. map ( String :: from) . to_vec ( ) ;
1465+ assert ! ( duplicate. validate( ) . is_err( ) ) ;
1466+ }
1467+ }
1468+
13061469 #[ test]
13071470 fn validates_host_declarations_and_old_manifests ( ) {
13081471 let old: Manifest =
0 commit comments