You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit bc7c74b
Browse filesBrowse the repository at this point in the historyBrowse files
fix(channels): keep main-pane threads mounted under the image viewer
79f25bb guarded every thread host on showingMediaReview. hosts covers
both panes, so a thread moved to the main pane now unmounted during a
review and came back without its scroll place, reply target or expanded
branches. Before that commit it stayed mounted and attached: the main
PanelWorkspace was never gated on a review.
useConversationTabs takes hostPanes, the panes whose thread content
renders now, and ChannelsPage passes ["main"] during a review, so only
side thread tabs leave. The review state moves above the hook call,
which now reads it. keepMounted holds during a review only when there
is a panel to keep, instead of rendering an empty hidden dock.
The side-thread guard is not a no-op kept from main, as its comment and
the earlier message said. On main the side thread stayed React-mounted
in a detached portal subtree: TabSlot removed its node when the pane
children unmounted while hosts kept portaling into it, which is the
stale-draft state of the rejected keep-everything-mounted probe. The
guard is what makes the viewer's edits reach the thread composer, which
reads its draft only on mount; the comment now says so.
Tests: a hook case opens a side and a main thread and shows hostPanes
["main"] withholds only the side host and hosts it again afterwards.
The browser journey moves the side thread to the main pane, reviews the
image and asserts the same composer element stays connected and the
thread stays in the DOM while the viewer is up; it fails when a review
withholds both panes.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: mtoohey <[email protected]>
0 commit comments