Repository navigation
Commit bad2fec
fix(test): observe coordination transition events (#2297)
The coordination browser test can report `animated: false` after a real
disclosure transition completes between frame samples. Main [run
41693502039](https://github.com/block/buzz-app/actions/runs/41693502039),
WebKit job 126119613338, failed this assertion with no geometry failures
at `589c2a489fe87ab45315359014d7d46d2df4a240`.
Observe the panel's `grid-template-rows` transitionstart event before
clicking, and remove the observer in `finally`. Keep the existing
frame-by-frame clipping, alignment, settlement, and keyboard assertions.
No product changes or browser cases added/removed. Browser coverage
remains necessary for actual CSS transitions and rendered geometry.
Validation:
- At the failing main commit, delaying only test sampling by 350ms
reproduced the exact failure while recorded transition events proved
motion occurred. The original hosted trace does not record those events,
so its precise scheduling cause remains unproven.
- The repaired test passes with the same diagnostic delayed sampler in
Chromium and WebKit (8.1s / 8.3s test execution; 34.5s local runner).
Diagnostic instrumentation is excluded from this change.
- Disabled-motion control still fails the animation assertion (WebKit),
so an absent transition remains detectable.
- Normal repaired test: 2/2 per engine, Chromium 3.7–3.9s and WebKit
4.4–4.7s; 30.1s local runner. Only the affected case ran, with no
retries.
- At commit `8a53027b3`, the affected test passes in Chromium (4.3s) and
WebKit (4.8s), 18.1s runner; head verified before and after.
- Independent agent review approved with no findings. The reviewer's
reduced-motion control fails in both engines as intended. The review run
also inadvertently included measurement dependencies.
- Hosted coordination repetition checks passed 10/10 per engine in [run
41701145383](https://github.com/block/buzz-app/actions/runs/41701145383).
Attempt 1 hit the separate held-pointer travel test defect
(`history-loading.spec.mjs:347`, expected ≥6 steps, got 2), already
repaired by unmerged #2250. A single-job hosted retry passed at the
unchanged repair head. Attempt 2 completed successfully at 19:37:26 UTC:
39 successful checks, two expected skips, none pending. This PR does not
repair the held-pointer defect.
No full suite invoked locally; hosted CI supplies broader validation.
Native acceptance and a real relay are outside this test-only change.
Signed-off-by: Kalvin Chau <[email protected]>
Co-authored-by: am <6e30cd56c30e030cd31bb0939b94a7c257c9a09d5ba2d92cf2735da45629f248@buzz.block.builderlab.xyz>1 parent a34ba4f commit bad2fec
1 file changed
Lines changed: 37 additions & 22 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
51 | 51 | | |
52 | 52 | | |
53 | 53 | | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
54 | 64 | | |
55 | 65 | | |
56 | 66 | | |
| |||
78 | 88 | | |
79 | 89 | | |
80 | 90 | | |
81 | | - | |
82 | 91 | | |
83 | 92 | | |
84 | | - | |
85 | | - | |
86 | | - | |
87 | | - | |
88 | | - | |
89 | | - | |
90 | | - | |
91 | | - | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
105 | 120 | | |
106 | 121 | | |
107 | 122 | | |
| |||
0 commit comments