Skip to content

Commit b61b39a

Browse files
wesbillmanCarl
andauthored
feat(me): polish sharing and add the shared panel workspace (#793)
Signed-off-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz> Co-authored-by: Carl <32a2e2c9d428ee08902cab75d956da2c1d235a22d4766b0dd4138bf6e2e5db1d@buzz.block.builderlab.xyz>
1 parent 759abcf commit b61b39a

37 files changed

Lines changed: 3076 additions & 923 deletions

‎docs/sessions/README.md‎

Lines changed: 28 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,17 +16,35 @@ The earlier [channel-space proposal](spaces.md) is superseded design history.
1616
draft, channel ID, Canvas and group defaults in the existing pending-start
1717
receipt. Setup and Me placement must succeed before sending; retries reuse that
1818
ID. Draft settings remain local until first send and use Me's defaults namespace.
19-
- Move to Messages preserves the channel ID, history, Canvas and memberships. It
20-
removes Me placement and the obsolete Me group assignment; it does not import
21-
the Me group into Messages. This is organization, not a privacy transition.
22-
- Me sharing explicitly grants selected people access to the existing history and
23-
moves the conversation to Messages. Destination-link sharing in Messages remains
24-
a separate flow; see [sharing](sharing.md). Neither flow shares owner-private
25-
detailed agent activity or starts an agent merely by granting membership.
19+
- **Share** is the single Me-to-Messages flow, available in the heading and sidebar
20+
menus. It defaults to the current name, visibility and duration (new conversations
21+
are Private/Ongoing), with optional additional people. It preserves the channel
22+
ID, history, Canvas and existing agents/members. No conversation is copied.
23+
- Share confirms selected-person access, then applies channel settings, then removes
24+
Me placement and the obsolete Me group assignment. It does not import Me groups
25+
into Messages. Removing the legacy session marker makes this an ordinary Messages
26+
channel, even when other settings are unchanged. Public sharing explicitly
27+
confirms exposure of the full history; Temporary duration automatically archives
28+
the conversation without deleting its history. Settings changes require verified
29+
owner/admin authority and a details writer; there is no separate placement-only
30+
Move fallback.
31+
- Destination-link sharing in Messages remains a separate flow; see
32+
[sharing](sharing.md). Neither flow shares owner-private detailed agent activity
33+
or starts an agent merely by granting membership.
34+
- Me conversations and drafts use the full conversation pane. Right-click,
35+
Shift+F10 and overflow share one sidebar action list: Share, Rename, Move to a Me
36+
group, Copy and Session settings. Opening a row menu does not select the row.
2637
- Me uses the ordinary composer with selectable owner-scoped agent mentions. A
2738
send without a mention does not infer an agent. Existing Messages sessions keep
2839
their ordinary recipient rules. Saved placement must load before the Me reader
2940
enables sending; an unavailable preference read is not evidence of Messages.
41+
- Me reuses Messages' secondary conversation/tool/panel tabs and pane geometry,
42+
with separate per-conversation Me persistence. Its main timeline remains flat.
43+
A single working agent's Activity indicator opens its Activity panel locally;
44+
multiple agents or an unavailable panel retain the chooser. Hover previews are
45+
retained; Down Arrow on a single-agent indicator opens the chooser for keyboard
46+
access to its conversation actions. Secondary conversations placed in Me keep
47+
owner-scoped explicit recipients and wait for placement readiness before sending.
3048
- Canonical channel links still use the ordinary channel reader, and Me routes can
3149
refer to an accessible ordinary channel UUID. Routes and plugin views do not
3250
grant access. Disabling the Me view does not delete its channels or memberships.
@@ -67,5 +85,6 @@ browser fixtures exercise actual app wiring in Chromium and WebKit with syntheti
6785
identities. They do not prove native signing, live persistence/restart,
6886
cross-device/plugin fallback, real-agent effects or opening performance.
6987
Those checks and renewed human acceptance remain delivery gates where applicable.
70-
Me menu parity and Archive/Delete availability after Move are disclosed follow-ups,
71-
not completed behavior in this baseline.
88+
The polish browser journey covers menu/focus behavior, full-width saved/draft
89+
composers, and in-place Share through the real browser broker with synthetic relay
90+
responses. Native/live relay promotion and human acceptance remain unverified.

‎docs/sessions/sharing.md‎

Lines changed: 29 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,38 @@
22

33
The baseline uses ordinary channel membership and private client-side Me
44
organization; see [Me and sessions](README.md). This document describes the
5-
destination-link flow in Messages. Me uses direct selected-person sharing and
6-
Move to Messages instead. Both grant access to existing history, not a snapshot.
5+
destination-link flow in Messages and unified Me sharing. Both grant access to
6+
existing history, not a snapshot.
7+
8+
## Me: share in place
9+
10+
Me uses the existing channel-details controls: editable current name, Private/Open
11+
and Ongoing/Temporary, plus optional people. Existing agents remain members without
12+
being re-added or woken. Copy link and cancelling do not mutate access or placement.
13+
14+
Submission freezes the settings/base and people, confirms grants while the channel
15+
is still private, saves the settings with signed fresh authority/readback, then
16+
removes Me placement and opens Messages. The standalone session marker becomes an
17+
empty description so normal Messages behavior applies. A default Share therefore
18+
writes metadata once; unchanged visibility and TTL are omitted. Public sharing
19+
requires a second confirmation of history exposure. The Temporary control explains
20+
that expiry automatically archives the conversation; it does not delete history.
21+
22+
A settings or placement failure retains confirmed work and frozen Retry intent.
23+
Confirmed grants are skipped; an uncertain details save is checked, never blindly
24+
republished. A confirmed TTL is not resent, avoiding a reset of the cleanup deadline.
25+
Conflicting metadata stops the attempt. **Check channel settings status** remains
26+
available for an uncertain save, including after Start over. Closing/navigating does
27+
not cancel submitted work; completion cannot navigate a superseding visit.
28+
29+
This is not an atomic grant/settings/placement transaction. There is no separate
30+
placement-only Move fallback: Share requires verified owner/admin details authority
31+
and the connection’s existing details writer. Destination-link behavior below is
32+
unchanged.
733

834
## Current behavior
935

10-
- **Share** in a session heading opens a compact dialog. **Everyone in this channel** (default) means all *current* destination-channel roster keys, **including agents**. After optional invitations separately chosen for a new destination are confirmed, a strong fresh kind-39002 destination roster read freezes its exact non-viewer keys for this submitted attempt and retries. Missing/malformed/ineligible membership, archived identities, invalid keys or >100 recipients fail visibly; no namesake join or silent agent/archived filtering. Later destination joiners do not acquire session access. Known agents get the ordinary `role=bot` membership invitation but sharing does not notify, wake, start, configure or own a runner.
36+
- **Share** in a Messages session heading opens a compact dialog. **Everyone in this channel** (default) means all *current* destination-channel roster keys, **including agents**. After optional invitations separately chosen for a new destination are confirmed, a strong fresh kind-39002 destination roster read freezes its exact non-viewer keys for this submitted attempt and retries. Missing/malformed/ineligible membership, archived identities, invalid keys or >100 recipients fail visibly; no namesake join or silent agent/archived filtering. Later destination joiners do not acquire session access. Known agents get the ordinary `role=bot` membership invitation but sharing does not notify, wake, start, configure or own a runner.
1137
- **Selected people** is deliberate human selection by exact public key. The human picker hides identities *known* to be agents by existing profile/agent-choice evidence (unknown classification is not proof of humanity); submit rechecks known-agent and archive admission. Picking a person does not automatically include their agents. Already-access people can be shown as unavailable. In a new destination, **people to add to that channel** and **people to grant session access** are independent selections. With Everyone, confirmed new-destination invitees enter the fresh destination roster before the session audience is frozen. No general member-add behavior is widened.
1238
- All grants target the private session's own signed membership roster. They grant normal **read and participate** access, not read-only access. No parent/destination inheritance, future-member synchronization, or revocation on leaving the destination. The existing composer, notification/mention rules and agent recipient routing remain in charge of deliberate sends. Detailed owner-private ACP activity is not shared.
1339
- **Copy link** copies `buzz://channel/<session-id>` only: no grant, saved selection, post, channel creation, invitation or permission mutation. A recipient needs independent session access. Sharing posts one ordinary kind-9 destination message with the neutral `Session · short ID` link chip. An authorized click opens the existing live session transcript/composer in that destination's side panel while preserving the destination and the Sessions entry; unauthorized access does not expose transcript content. The link is bound to the selected community rather than portable across communities.

‎src/bundled/channels/ChannelPrivacyConfirmation.tsx‎

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ export function ChannelPrivacyConfirmation({
2323
visibility,
2424
checked,
2525
onCheckedChange,
26+
hidePreference = false,
2627
}: {
28+
hidePreference?: boolean;
2729
visibility: Visibility;
2830
checked: boolean;
2931
onCheckedChange(checked: boolean): void;
@@ -35,11 +37,13 @@ export function ChannelPrivacyConfirmation({
3537
? "Only channel members will have access."
3638
: "Everyone in this community will be able to view this channel’s full history."}
3739
</BaseDialog.Description>
38-
<Checkbox
39-
label="Don’t show me this again"
40-
checked={checked}
41-
onCheckedChange={onCheckedChange}
42-
/>
40+
{!hidePreference && (
41+
<Checkbox
42+
label="Don’t show me this again"
43+
checked={checked}
44+
onCheckedChange={onCheckedChange}
45+
/>
46+
)}
4347
</div>
4448
);
4549
}

0 commit comments

Comments
 (0)