@@ -933,6 +933,161 @@ it("returns unknown when a queue request's provider is replaced", async () => {
933933 replacement . dispose ( ) ;
934934} ) ;
935935
936+ it ( "reports a replaced provider retired only after disposal ends its queued and unopened reviews" , async ( ) => {
937+ const f = fixture ( ) ;
938+ const bridge = createPluginUpdateCapabilityBridge ( ) ;
939+ const original = createPluginUpdates ( f . manager , f . authorize ) ;
940+ bridge . register ( original ) ;
941+ const token = ( await bridge . capability . refresh ( ) ) . candidates [ 0 ] ?. token ;
942+ const ownerId = bridge . capability . ownerId ;
943+ if ( ! token || ! ownerId ) throw new Error ( "Expected a retained provider" ) ;
944+ const reviewing = bridge . capability . queueUpdates ( [ token ] ) ;
945+ const queued = bridge . capability . queueUpdates ( [ token ] ) ;
946+ const review = startReview ( original ) ;
947+ if ( ! reviewing || ! queued || ! review ) throw new Error ( "Expected a review" ) ;
948+
949+ const replacement = createPluginUpdates ( f . manager , f . authorize ) ;
950+ const unregisterReplacement = bridge . register ( replacement ) ;
951+ const nextOwnerId = bridge . capability . ownerId ;
952+ if ( ! nextOwnerId ) throw new Error ( "Expected a replacement provider" ) ;
953+ expect ( original . capability . getQueue ( reviewing . id ) ?. status ) . toBe ( "reviewing" ) ;
954+ expect ( original . capability . getQueue ( queued . id ) ?. status ) . toBe ( "queued" ) ;
955+ for ( const id of [ ownerId , nextOwnerId , "unseen" as typeof ownerId ] )
956+ expect ( bridge . capability . getOwnerStatus ?.( id ) ) . toBe ( "unknown" ) ;
957+
958+ original . dispose ( ) ;
959+ expect ( original . capability . getQueue ( reviewing . id ) ?. status ) . toBe ( "cancelled" ) ;
960+ expect ( original . capability . getQueue ( queued . id ) ?. status ) . toBe ( "cancelled" ) ;
961+ for ( let query = 0 ; query < 3 ; query ++ )
962+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "retired" ) ;
963+ expect ( bridge . forCaller ( "example.market" ) . getOwnerStatus ?.( ownerId ) ) . toBe (
964+ "retired" ,
965+ ) ;
966+ expect ( original . beginOperation ( review . queueId , review . token ) ) . toBeUndefined ( ) ;
967+ expect ( startReview ( original ) ) . toBeUndefined ( ) ;
968+ expect ( original . capability . queueUpdates ( [ token ] ) ) . toBeUndefined ( ) ;
969+ expect ( bridge . capability . getOwnerStatus ?.( nextOwnerId ) ) . toBe ( "unknown" ) ;
970+ expect (
971+ bridge . capability . getQueueRequest ( {
972+ ownerId,
973+ requestId : "historical-request" ,
974+ tokens : [ token ] ,
975+ } ) ,
976+ ) . toEqual ( { status : "unknown" } ) ;
977+
978+ unregisterReplacement ( ) ;
979+ replacement . dispose ( ) ;
980+ } ) ;
981+
982+ it . each ( [
983+ [ "finished" , "installed" ] ,
984+ [ "ended" , "failed" ] ,
985+ [ "cancelled" , "cancelled" ] ,
986+ [ "reconfirmed" , "failed" ] ,
987+ ] as const ) (
988+ "keeps a confirmed operation's provider unknown past disposal until it is %s" ,
989+ async ( completion , itemStatus ) => {
990+ const f = fixture ( ) ;
991+ const bridge = createPluginUpdateCapabilityBridge ( ) ;
992+ const original = createPluginUpdates ( f . manager , f . authorize ) ;
993+ bridge . register ( original ) ;
994+ const token = ( await bridge . capability . refresh ( ) ) . candidates [ 0 ] ?. token ;
995+ const ownerId = bridge . capability . ownerId ;
996+ if ( ! token || ! ownerId ) throw new Error ( "Expected a retained provider" ) ;
997+ const queue = bridge . capability . queueUpdates ( [ token ] ) ;
998+ let held = false ;
999+ const statusAtRelease = vi . fn ( ( ) =>
1000+ bridge . capability . getOwnerStatus ?.( ownerId ) ,
1001+ ) ;
1002+ const hold = ( ) => {
1003+ held = true ;
1004+ return ( ) => {
1005+ statusAtRelease ( ) ;
1006+ held = false ;
1007+ } ;
1008+ } ;
1009+ const review = original . startNextReview ( hold ) ;
1010+ if ( ! queue || ! review ) throw new Error ( "Expected a review" ) ;
1011+ const unconfirm = original . beginOperation ( queue . id , review . token ) ;
1012+ expect ( unconfirm ) . toEqual ( expect . any ( Function ) ) ;
1013+
1014+ const replacement = createPluginUpdates ( f . manager , f . authorize ) ;
1015+ const unregisterReplacement = bridge . register ( replacement ) ;
1016+ original . dispose ( ) ;
1017+ if ( completion === "finished" || completion === "ended" )
1018+ expect ( original . capability . cancelQueue ( queue . id ) ) . toBe ( true ) ;
1019+ expect ( original . getActiveReview ( ) ) . toBeDefined ( ) ;
1020+ expect ( held ) . toBe ( true ) ;
1021+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1022+ if ( completion === "finished" ) {
1023+ expect ( original . finishReview ( queue . id , review . token , "updated" ) ) . toBe (
1024+ true ,
1025+ ) ;
1026+ } else {
1027+ unconfirm ?.( ) ;
1028+ expect ( original . getActiveReview ( ) ) . toBeDefined ( ) ;
1029+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1030+ if ( completion === "ended" )
1031+ expect (
1032+ original . endReview ( queue . id , review . token , "install failed" ) ,
1033+ ) . toBe ( true ) ;
1034+ else if ( completion === "cancelled" )
1035+ expect ( original . capability . cancelQueue ( queue . id ) ) . toBe ( true ) ;
1036+ else
1037+ expect ( original . beginOperation ( queue . id , review . token ) ) . toBeUndefined ( ) ;
1038+ }
1039+
1040+ expect ( statusAtRelease ) . toHaveReturnedWith ( "unknown" ) ;
1041+ expect ( held ) . toBe ( false ) ;
1042+ expect ( original . getActiveReview ( ) ) . toBeUndefined ( ) ;
1043+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "retired" ) ;
1044+ expect ( original . capability . getQueue ( queue . id ) ?. items [ 0 ] ?. status ) . toBe (
1045+ itemStatus ,
1046+ ) ;
1047+ expect ( original . capability . queueUpdates ( [ token ] ) ) . toBeUndefined ( ) ;
1048+ expect ( original . startNextReview ( hold ) ) . toBeUndefined ( ) ;
1049+ expect ( held ) . toBe ( false ) ;
1050+ unregisterReplacement ( ) ;
1051+ replacement . dispose ( ) ;
1052+ } ,
1053+ ) ;
1054+
1055+ it ( "keeps live, unregistered, evicted and restarted provider lifetimes unknown" , async ( ) => {
1056+ const f = fixture ( ) ;
1057+ const bridge = createPluginUpdateCapabilityBridge ( ) ;
1058+ const original = createPluginUpdates ( f . manager , f . authorize ) ;
1059+ const ownerId = original . capability . ownerId ;
1060+ if ( ! ownerId ) throw new Error ( "Expected a provider identity" ) ;
1061+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1062+ const unregister = bridge . register ( original ) ;
1063+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1064+ unregister ( ) ;
1065+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1066+ original . dispose ( ) ;
1067+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "retired" ) ;
1068+ expect (
1069+ createPluginUpdateCapabilityBridge ( ) . capability . getOwnerStatus ?.( ownerId ) ,
1070+ ) . toBe ( "unknown" ) ;
1071+
1072+ const later : ReturnType < typeof createPluginUpdates > [ ] = [ ] ;
1073+ for ( let index = 0 ; index < 15 ; index ++ ) {
1074+ const next = createPluginUpdates ( f . manager , f . authorize ) ;
1075+ bridge . register ( next ) ( ) ;
1076+ next . dispose ( ) ;
1077+ later . push ( next ) ;
1078+ }
1079+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "retired" ) ;
1080+ const newest = createPluginUpdates ( f . manager , f . authorize ) ;
1081+ const unregisterNewest = bridge . register ( newest ) ;
1082+ expect ( bridge . capability . getOwnerStatus ?.( ownerId ) ) . toBe ( "unknown" ) ;
1083+ const laterIds = later . map ( ( next ) => next . capability . ownerId ) ;
1084+ expect ( laterIds ) . not . toContain ( undefined ) ;
1085+ for ( const id of laterIds )
1086+ if ( id ) expect ( bridge . capability . getOwnerStatus ?.( id ) ) . toBe ( "retired" ) ;
1087+ unregisterNewest ( ) ;
1088+ newest . dispose ( ) ;
1089+ } ) ;
1090+
9361091it ( "does not replay an ambiguous update request across checker lifetimes" , async ( ) => {
9371092 const f = fixture ( ) ;
9381093 const first = createPluginUpdates ( f . manager , f . authorize ) ;
0 commit comments