You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 8230222
Browse filesBrowse the repository at this point in the historyBrowse files
## Why
Pasting a sentence with an inline image could drop every labelled link.
Buzz discarded image alt text, then rejected the HTML because it no
longer matched the clipboard's plain text.
Related: [AIDA-2425](https://linear.app/squareup/issue/AIDA-2425). This
fixes the reproduced inline-image case; the original Slack report still
needs its own clipboard capture.
## What
Keep image alt text and safe link destinations when pasting external
HTML. Keep plain-text paste, the text-match guard, and URL filtering
unchanged.
## How
Replace images with text nodes before stripping HTML attributes in the
existing external-paste converter. Cover images beside links, images
inside labels, empty alt text, unsafe destinations, mismatched text, and
undo.
## Risk
This changes external HTML paste in the shared composer. Clipboards
whose text still differs fall back to plain text. No image loading or
attachment behavior is added.
## Testing
Independent review of `a7fb6366e3f93b92a62fea9c5e657f2e9efd8abf` found
no blocking correctness or security issue. Final head
`4eba754c5d05fbde15eaf0f09cd188ec44116aff` rebases onto
`b621738454064985fe42de0c077e8d381ca0037b`. The only conflict was
adjacent help-guide additions; both the upstream `/leave` instructions
and paste guidance are retained. Paste implementation and tests are
unchanged from the reviewed commit.
Opened [the sample
page](https://buzz.block.builderlab.xyz/media/59bc1610cb9bd97da4ce9bb95c301be2134f0c43a2aca6b8267db3e58b303123.html)
in Chromium on macOS. Copied each sample, pressed ordinary ⌘V in the
actual composer, and sent each draft through the fixture relay. Both
kept the labelled URL; the image sample kept `:wave:`. The independent
reviewer repeated this successfully at the rebased commit.
Browser cases added/removed: 0/0. The existing external-link journey
includes an inline image and checks the composer and published message.
The independent reviewer ran the complete paste file on the rebased
commit: 8 passed, 2 existing platform skips across Chromium and WebKit.
The case matrix stays in the mounted editor tests.
All mandatory push hooks passed at `a7fb6366e` after rerunning with one
test worker. Following the author's request to push, the final
documentation-conflict rebase skipped the long TypeScript/related-test
lane; design and push-policy hooks still passed. Current-head CI is
pending.
Validation limits: the first rebased push-hook run failed 9 tests across
retained-page, ChannelsPage.conversion, useConversationTabs.panels,
huddle/composer, and MessageEdit.integration. Most failures were
timeouts; their cause is unverified. A separate exploratory full
frontend run was interrupted after reporting three agent-service
failures and one MessageComposer timeout, so it is not a completed
full-suite result. Earlier full-suite failures and old-head CI failures
are not established baseline defects. Installed Tauri, Slack Desktop,
and human acceptance remain unverified.
Generated with Codex
Signed-off-by: Ravneet Arora <[email protected]>
Co-authored-by: BuzzPRReviewAssistant1 <a581a7e8115222acdc32ffb14bfce55d48c24478d98e155f8eba126b69b83c7b@buzz.block.builderlab.xyz>
0 commit comments