You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 7ae9be9
Browse filesBrowse the repository at this point in the historyBrowse files
fix(messages): resolve "N others" names only while the list is open
The "N others" list built every member's profile button whenever its
membership row rendered, even with the list closed: an npub encode plus
the host's canOpenLink per member, about 3.75 ms per pass for a 602-member
burst and repeated on each memo miss while the burst's profiles load. The
list moves into a MembershipPeople component inside PopoverPopup, whose
portal mounts it only while the list is open.
The list's scrollport clipped its entries: each .link overhangs by
space-half, so the hover fill lost 2px on the left and the 2px-offset
keyboard ring was cut on the left of every entry and the top of the first.
Following DESIGN.md "Focus recipes", the scrollport gains space-half of
inline padding (offset by a matching negative margin, so names stay aligned
with the title) and the entries' ring is inset with outline-offset: -2px.
Member names now rest at currentColor instead of text-subtle. Row names
still inherit the caption's text-subtle, while listed names take the
popover's text-standard rather than reading dimmer than the plain entries
around them. Hover and keyboard focus keep the inline-reference colour. The
comment no longer says medium weight is the only resting cue; the .link
underline stays.
Tests: the "N others" RTL case asserts that a closed list asks the host
about its lead name only, which fails against the inline map. The
join-burst journey checks that a resting entry matches the list's colour,
Tabs to the first name, asserts its drawn ring fits inside the scrollport
and saves a focus screenshot. The colour and clip assertions fail before
their fixes (rgb(82, 82, 82) vs rgb(15, 15, 15); 6px clipped).
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>
0 commit comments