Repository navigation
Commit 721189f
test(composer): label control-character cases by code point
Addresses the review of 666d1c6e.
The rightArrowCharacters table in EditableInput.test.tsx held the bare
characters U+001D and U+F703, so the "never runs a typed conversion"
case interpolated a glyphless character with %s and the two generated
names read identically, the failing run reporting "never runs a typed
conversion for the control character " with nothing after it. The
"either form" loop above it and the MessageComposer caret-key case
passed the raw character as the expect message, so a failure there
could not say which form broke either.
rightArrowCharacters is now a labelled-tuple table in the shape of
controlKeys, "Right Arrow's layout translation U+001D" and "Right
Arrow's function-key character U+F703", and both consumers destructure
it: the it.each case name becomes "never runs a typed conversion for
%s committed as text" and the loop passes the label as each assertion's
message, including the waitFor expectation that had none. The
MessageComposer loop iterates the same labelled pairs and names the
form on the prevented check and on the three assertions after it. The
browser spec already stringified its message and is unchanged. No
assertion, input or expected value changes.
Both composer suites pass (2 files, 264 tests), the four relabelled
cases reporting distinct names; tsc --noEmit is clean; biome check
--error-on-warnings passes, reporting only its pre-existing note that
biome.json names schema 2.5.12 while 2.5.14 is installed.
Co-Authored-By: Claude Fable 5.1 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>1 parent 06b1a54 commit 721189f
2 files changed
Lines changed: 27 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1238 | 1238 | | |
1239 | 1239 | | |
1240 | 1240 | | |
1241 | | - | |
1242 | | - | |
| 1241 | + | |
| 1242 | + | |
| 1243 | + | |
| 1244 | + | |
| 1245 | + | |
| 1246 | + | |
| 1247 | + | |
1243 | 1248 | | |
1244 | 1249 | | |
1245 | 1250 | | |
| |||
1391 | 1396 | | |
1392 | 1397 | | |
1393 | 1398 | | |
1394 | | - | |
| 1399 | + | |
1395 | 1400 | | |
1396 | | - | |
1397 | | - | |
1398 | | - | |
1399 | | - | |
1400 | | - | |
| 1401 | + | |
| 1402 | + | |
| 1403 | + | |
| 1404 | + | |
| 1405 | + | |
| 1406 | + | |
| 1407 | + | |
1401 | 1408 | | |
1402 | 1409 | | |
1403 | 1410 | | |
| |||
1407 | 1414 | | |
1408 | 1415 | | |
1409 | 1416 | | |
1410 | | - | |
1411 | | - | |
| 1417 | + | |
| 1418 | + | |
1412 | 1419 | | |
1413 | 1420 | | |
1414 | 1421 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
804 | 804 | | |
805 | 805 | | |
806 | 806 | | |
807 | | - | |
808 | | - | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
809 | 813 | | |
810 | 814 | | |
811 | 815 | | |
| |||
818 | 822 | | |
819 | 823 | | |
820 | 824 | | |
821 | | - | |
822 | | - | |
823 | | - | |
824 | | - | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
825 | 829 | | |
826 | 830 | | |
827 | 831 | | |
| |||
0 commit comments