Skip to content

Commit 6ff11d2

Browse files
tulsi-builderBasilBotclaude
committed
fix(inbox): keep Solo chats under All, not DMs
The sidebar keeps Solo chats and direct messages in separate sections, so the DMs filter now shows only direct messages. Solo flat rows still appear under All and still reopen there after Archive. Co-authored-by: BasilBot <399581b6165ab01343e3a1324774b1024d76942aea563468f93c975e5ee5193c@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: tulsi <[email protected]>
1 parent c892fe1 commit 6ff11d2

4 files changed

Lines changed: 7 additions & 9 deletions

File tree

‎docs/buzz-help.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ that agent in Buzz; they do not notify the external app through this connection.
130130
add at least one project folder; the form shows a message beside Folders
131131
until you add one or turn worktree mode off.
132132
- **Inbox** collects DMs, ordinary responses in Solo chats, mentions of you, and replies in threads you started,
133-
replied in, or follow. Solo chats appear under All and DMs; their nested threads stay separate. Agent-only
133+
replied in, or follow. Solo chats appear under All, not DMs; their nested threads stay separate. Agent-only
134134
coordination stays out.
135135
- **Communities** have their own channels, people, and agents. Switching
136136
communities changes the available context. A channel reopens where you

‎docs/inbox.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ outbox retain their existing ownership. No projects, approvals or reminders.
1616

1717
### Archive conversations
1818

19-
Archive in the row button or row context menu removes that conversation from the active Inbox. The Archive shortcut (⌃⌘A on Apple platforms, Ctrl+Shift+E elsewhere; rebindable in Settings → Shortcuts) archives the last opened conversation, or restores it in the archived view, including from the composer. The filter menu groups Type, From, and Status, followed by Drafts. Status switches between Inbox and Archived using the same single-choice highlight as Type; activity and sender selections stay in effect in either view. The existing Unread only toggle stays independent. Status, activity, sender and attention choices are saved on this device for the current account and community, with each missing or invalid choice using its own default. Older saved combined status falls back to Inbox. The toolbar wraps on narrow screens. Choosing Archived opens the archived view, where Restore returns a conversation to Inbox. Archive/Restore row buttons appear on hover or keyboard focus and remain visible without a hover pointer; row actions do not open or mark an unselected conversation read. Archiving the open conversation, from its row, context menu or the shortcut, closes its tab and opens the next visible conversation (or the preceding one at the end), marking it read as a normal selection would; with none remaining, focus returns to the list. Archiving any other row moves focus to the next visible row. Incoming replies and mentions preserve an open archived conversation and its composer draft. When a Type, From or Unread only choice leaves the list empty, Clear filters resets those three and keeps Status; an empty Archived view without them offers Show Inbox. Either returns focus to the filters. Archive records a timestamp watermark, the later of the archive time and the conversation's newest evidence, and the message IDs already observed. A fresh incoming participating-thread reply, Solo top-level response or DM message at or beyond that watermark returns the conversation to its ordinary activity views (Threads or DMs, and All activity); Mentions still requires a fresh explicit mention. DM arrivals reopen the conversation whether they are replies or top-level messages. Already observed replies and replayed older mentions do not reopen it. An archive saved for part of a session's merged top-level row hides that row only when archives cover all of its messages. Reply reopening persists without discarding the mention cutoff, so bounded evidence eviction cannot hide the reopened conversation or resurface its older mentions. A fresh explicit mention retires the saved cutoff; manual Restore clears it in every activity view. Sending a reply does not archive or restore a conversation; Inbox reuses the unchanged shared composer. Archive/filter/selection policy lives entirely in the Inbox plugin. The shared unread evidence owner supplies verified conversation-member facts (`id`, `createdAt`, `mentioned`) through the existing injected `session.unread.inbox()` capability, available to any plugin requesting `relay`. The Inbox plugin uses those facts to retire superseded archive intent; the shared contract contains no Archive state or cutoff policy.
19+
Archive in the row button or row context menu removes that conversation from the active Inbox. The Archive shortcut (⌃⌘A on Apple platforms, Ctrl+Shift+E elsewhere; rebindable in Settings → Shortcuts) archives the last opened conversation, or restores it in the archived view, including from the composer. The filter menu groups Type, From, and Status, followed by Drafts. Status switches between Inbox and Archived using the same single-choice highlight as Type; activity and sender selections stay in effect in either view. The existing Unread only toggle stays independent. Status, activity, sender and attention choices are saved on this device for the current account and community, with each missing or invalid choice using its own default. Older saved combined status falls back to Inbox. The toolbar wraps on narrow screens. Choosing Archived opens the archived view, where Restore returns a conversation to Inbox. Archive/Restore row buttons appear on hover or keyboard focus and remain visible without a hover pointer; row actions do not open or mark an unselected conversation read. Archiving the open conversation, from its row, context menu or the shortcut, closes its tab and opens the next visible conversation (or the preceding one at the end), marking it read as a normal selection would; with none remaining, focus returns to the list. Archiving any other row moves focus to the next visible row. Incoming replies and mentions preserve an open archived conversation and its composer draft. When a Type, From or Unread only choice leaves the list empty, Clear filters resets those three and keeps Status; an empty Archived view without them offers Show Inbox. Either returns focus to the filters. Archive records a timestamp watermark, the later of the archive time and the conversation's newest evidence, and the message IDs already observed. A fresh incoming participating-thread reply, Solo top-level response or DM message at or beyond that watermark returns the conversation to its ordinary activity views (Threads or DMs, and All activity; a Solo chat's flat row returns to All); Mentions still requires a fresh explicit mention. DM arrivals reopen the conversation whether they are replies or top-level messages. Already observed replies and replayed older mentions do not reopen it. An archive saved for part of a session's merged top-level row hides that row only when archives cover all of its messages. Reply reopening persists without discarding the mention cutoff, so bounded evidence eviction cannot hide the reopened conversation or resurface its older mentions. A fresh explicit mention retires the saved cutoff; manual Restore clears it in every activity view. Sending a reply does not archive or restore a conversation; Inbox reuses the unchanged shared composer. Archive/filter/selection policy lives entirely in the Inbox plugin. The shared unread evidence owner supplies verified conversation-member facts (`id`, `createdAt`, `mentioned`) through the existing injected `session.unread.inbox()` capability, available to any plugin requesting `relay`. The Inbox plugin uses those facts to retire superseded archive intent; the shared contract contains no Archive state or cutoff policy.
2020

2121
Archive applies only to conversations admitted by the shared Inbox projection; it does not override channel visibility policy or change channel archive state. Archive is personal view intent saved on this device, partitioned by the relay session's community and viewer scope. It persists across reloads and reconnects, with the same-window subscription and cross-window storage notifications as other view intent. Failed saves leave the conversation visible and expose Retry. Archive choices do not synchronize across devices or change unread or notification policy. It does not delete messages or claim a task has finished. The archived view uses the same bounded verified conversation evidence as Inbox, so it is not a permanent full-history archive browser.
2222

@@ -29,7 +29,7 @@ Rows retain exact IDs and current names while `inboxFeed.incomplete` marks only
2929

3030
The list is the Inbox page's first tab, in the host tab workspace behind `conversation.ui.Tabs`. Opening a row shows its conversation beside the list in the side tab pane, with the same reader and composer as Channels tabs: a thread at its exact message, revealed even outside the newest bounded page, or a whole DM or session conversation where its Channels tab would open. A plain open replaces the tab the previous one added, so one tab follows the selection; a tab moved to the main pane stays. The tab's right-click menu offers Open in channel, which opens its conversation in Channels; a thread opens there at the same message. A thread also names its conversation above its original message, as the rows do (`#channel` or `DM · names`); that name is a link that does the same. The pane resizes, closes and handles Escape as Channels' does. A late verified root can regroup a conversation without changing its open tab. Inbox tabs do not enter a channel visit, so showing one preserves forced-unread intent. Reading is saved by the shared unread owner, through the reader's dwell and the row's explicit read. As in a plain channel visit, the visible selected side tab reads while focus stays anywhere on the page, such as on the row that opened it; a tab moved to the main pane reads only by its own focus. Failed read actions retain their captured Retry unless access, the session or a newer intent retires it. A DM Retry reuses the original channel cutoff and manual-clear keys, not the retry-time clock or later arrivals. Re-clicking the selected row reselects its tab without repeating its read. Closing the tab ends the selection, so reopening the row reads it again. Archiving the selected conversation's channel, or its room becoming a Huddle, closes its tab and returns focus it held to the filters, and restoring the channel does not reopen it; other retained tabs follow Channels' unavailable placeholder, and focus their reader held moves to the tab. Re-clicking the selected row reveals its current message in its tab; a session mention that regrouped into a thread reselects its timeline tab. Context menus allow device-local Mark unread. Row accessible descriptions reuse the visible safe preview or incomplete placeholder; Show more follows the filtered result count. `NavigationItem` owns selected styling and `aria-current`. No Inbox-owned session, parallel fold, composer or outbox.
3131

32-
Solo chats include ordinary incoming top-level messages, excluding agent-only coordination and system events. Their flat rows appear under All and DMs; nested threads stay separate. Reading in Channels or Inbox clears the same evidence.
32+
Solo chats include ordinary incoming top-level messages, excluding agent-only coordination and system events. Their flat rows appear under All, not DMs, matching the sidebar's separate Solo and Direct messages sections; nested threads stay separate. Reading in Channels or Inbox clears the same evidence.
3333

3434
### Open Inbox with a filter
3535

‎src/bundled/inbox/InboxPage.test.tsx‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3797,7 +3797,7 @@ it("Inbox Solo chat activity shared with a person sends without a tag", async ()
37973797
expect(h.published[0]?.tags.filter(([name]) => name === "p")).toEqual([]);
37983798
});
37993799

3800-
it("a Solo chat row includes ordinary agent responses under DMs, keeping threads separate", async () => {
3800+
it("a Solo chat row includes ordinary agent responses under All, not DMs, keeping threads separate", async () => {
38013801
const h = fixture({ soloChannel: true, memberAgents: 1 });
38023802
const progress = message(h.agent, "room", "Agent progress", 30);
38033803
h.addEvent(progress);
@@ -3807,9 +3807,9 @@ it("a Solo chat row includes ordinary agent responses under DMs, keeping threads
38073807
await waitFor(() => expect(rows()[0]).toHaveTextContent("Agent progress"));
38083808
expect(rows()[1]).toHaveTextContent("A thread update");
38093809
expect(screen.queryByText("Please review this")).not.toBeInTheDocument();
3810+
// The sidebar keeps Solo chats apart from direct messages; so does Inbox.
38103811
await chooseFilter("DMs");
3811-
expect(rows()).toHaveLength(1);
3812-
expect(rows()[0]).toHaveTextContent("Agent progress");
3812+
expect(screen.queryByText("Agent progress")).not.toBeInTheDocument();
38133813
});
38143814

38153815
it("Inbox keeps an open Solo chat timeline when a late reply regroups its mention", async () => {

‎src/bundled/inbox/InboxPage.tsx‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -483,9 +483,7 @@ function InboxList({
483483
activity,
484484
list.channels.some(
485485
(channel) =>
486-
channel.id === item.channelId &&
487-
(channel.channelType === "dm" ||
488-
(channel.channelType === "solo" && !item.thread)),
486+
channel.id === item.channelId && channel.channelType === "dm",
489487
),
490488
),
491489
)

0 commit comments

Comments
 (0)