Skip to content

Commit 656a203

Browse files
committed
Polish Canvas-backed Todos panel and recovery
Signed-off-by: Arjun Mahanti <[email protected]>
1 parent b61b39a commit 656a203

15 files changed

Lines changed: 712 additions & 303 deletions

File tree

‎docs/plugin-architecture.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -351,8 +351,8 @@ not cross-version capability negotiation.
351351

352352
Todos (`buzz.todos`) is bundled **off by default** in browser and desktop. Enable
353353
it under Settings → Plugins. Its channel-header ListChecks button opens a right-hand
354-
side panel, grouping items as To do, Doing and Done, with add, a per-item Doing
355-
toggle, check/uncheck, one optional assignee per item, automatic
354+
side panel, grouping items as To do, In progress and Done, with add, a per-item status
355+
selector, check/uncheck, one optional assignee per item, automatic
356356
saving after each action, and explicit Refresh. It uses shared controls and theme
357357
tokens; Channels still owns panel geometry, responsive placement and selection. Terminal remains in the bottom drawer.
358358

‎src/bundled/channels/Channels.module.css‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,11 @@
5050
--sidenav-emoji-size: 0.8125rem;
5151
padding-inline: var(--sidebar-padding) var(--sidebar-padding-end);
5252
}
53-
.conversation [data-tab-pane-toggle][aria-expanded="true"] {
53+
.conversation
54+
:is(
55+
[data-tab-pane-toggle],
56+
[data-channel-panel-toggle]
57+
)[aria-expanded="true"] {
5458
/* An open pane shares the selected tab fill, rather than a held press. */
5559
--interaction-pressed: var(--affordance-subtle);
5660
}

‎src/bundled/todos/TodoChoice.tsx‎

Lines changed: 78 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
1+
import type { ReactElement } from "react";
2+
import { IconButton } from "../../shared/design-system/ui/IconButton";
3+
import { ChoiceRow } from "../../shared/design-system/ui/ChoiceRow";
4+
import {
5+
MenuRoot,
6+
MenuTrigger,
7+
MenuPopup,
8+
MenuGroup,
9+
MenuGroupLabel,
10+
MenuRadioGroup,
11+
MenuRadioItem,
12+
} from "../../shared/design-system/ui/Menu";
13+
14+
/** The two row choices share compact triggers, with full labels in the menu. */
15+
export function TodoChoice({
16+
id,
17+
label,
18+
title,
19+
icon,
20+
variant = "ghost",
21+
menuTitle,
22+
value,
23+
disabled,
24+
options,
25+
onValueChange,
26+
}: {
27+
id: string;
28+
label: string;
29+
title: string;
30+
icon: ReactElement;
31+
variant?: "ghost" | "avatar";
32+
menuTitle: string;
33+
value: string;
34+
disabled: boolean;
35+
options: {
36+
value: string;
37+
label: string;
38+
icon: ReactElement;
39+
disabled?: boolean;
40+
}[];
41+
onValueChange(value: string): void;
42+
}) {
43+
return (
44+
<MenuRoot>
45+
<MenuTrigger
46+
render={
47+
<IconButton
48+
id={id}
49+
size="sm"
50+
variant={variant}
51+
aria-label={label}
52+
aria-description={title}
53+
title={title}
54+
icon={icon}
55+
disabled={disabled}
56+
/>
57+
}
58+
/>
59+
<MenuPopup align="end">
60+
<MenuGroup>
61+
<MenuGroupLabel>{menuTitle}</MenuGroupLabel>
62+
<MenuRadioGroup value={value} onValueChange={onValueChange}>
63+
{options.map((option) => (
64+
<MenuRadioItem
65+
closeOnClick
66+
key={option.value}
67+
value={option.value}
68+
disabled={option.disabled}
69+
>
70+
<ChoiceRow leading={option.icon} label={option.label} />
71+
</MenuRadioItem>
72+
))}
73+
</MenuRadioGroup>
74+
</MenuGroup>
75+
</MenuPopup>
76+
</MenuRoot>
77+
);
78+
}

‎src/bundled/todos/Todos.module.css‎

Lines changed: 45 additions & 44 deletions
Original file line numberDiff line numberDiff line change
@@ -7,16 +7,11 @@
77
color: var(--text-standard);
88
container-type: inline-size;
99
}
10-
.heading {
11-
display: flex;
12-
align-items: baseline;
13-
gap: var(--space-2);
14-
min-width: 0;
15-
}
16-
.heading > span {
10+
.channel {
1711
overflow: hidden;
1812
text-overflow: ellipsis;
1913
white-space: nowrap;
14+
min-width: 0;
2015
}
2116
.scroll {
2217
flex: 1;
@@ -26,24 +21,26 @@
2621
.content {
2722
max-width: 45rem;
2823
margin-inline: auto;
29-
padding: var(--space-4) var(--space-6);
24+
padding: var(--space-6);
3025
display: grid;
31-
gap: var(--space-4);
26+
gap: var(--space-6);
3227
}
3328
.add {
3429
display: grid;
3530
grid-template-columns: minmax(0, 1fr) auto;
3631
gap: var(--space-2);
3732
align-items: center;
3833
}
39-
.empty {
40-
display: grid;
41-
gap: var(--space-1);
42-
padding-block: var(--space-3);
34+
.groupHeading {
35+
display: flex;
36+
align-items: baseline;
37+
gap: var(--space-2);
38+
}
39+
.groupCount {
40+
opacity: 0.5;
4341
}
4442
.group {
4543
display: grid;
46-
gap: var(--space-2);
4744
}
4845
.list {
4946
list-style: none;
@@ -52,51 +49,38 @@
5249
}
5350
.row {
5451
display: grid;
55-
grid-template-columns: minmax(0, 1fr) auto fit-content(42%);
52+
grid-template-columns: minmax(0, 1fr) auto;
5653
align-items: center;
5754
gap: var(--space-2);
58-
padding-block: var(--space-1);
55+
padding-block: var(--space-3);
5956
border-bottom: 1px solid var(--border-standard);
6057
}
58+
.row:first-child {
59+
padding-block-start: var(--space-2);
60+
}
6161
.row:last-child {
62+
padding-block-end: 0;
6263
border-bottom: 0;
6364
}
65+
.rowDetails {
66+
display: flex;
67+
align-items: center;
68+
gap: var(--space-1);
69+
min-width: 0;
70+
}
71+
.status {
72+
flex-shrink: 0;
73+
}
6474
.label {
6575
overflow-wrap: anywhere;
6676
}
6777
.label[data-completed] {
6878
text-decoration: line-through;
6979
}
70-
.footer {
71-
display: flex;
72-
flex-wrap: wrap;
73-
align-items: center;
74-
justify-content: space-between;
75-
gap: var(--space-3);
76-
padding: var(--space-3) var(--space-6);
77-
border-top: 1px solid var(--border-standard);
78-
}
79-
.summary {
80-
display: grid;
81-
gap: var(--space-half);
82-
flex: 1;
83-
min-width: 8.75rem;
84-
}
85-
.actions {
86-
display: flex;
87-
gap: var(--space-2);
88-
}
8980
@container (max-width: 30rem) {
9081
.content {
91-
padding: var(--space-2) var(--space-3);
92-
gap: var(--space-2);
93-
}
94-
.footer {
95-
padding: var(--space-2) var(--space-3);
96-
gap: var(--space-2);
97-
}
98-
.summary {
99-
min-width: 0;
82+
padding: var(--space-4);
83+
gap: var(--space-6);
10084
}
10185
}
10286

@@ -107,3 +91,20 @@
10791
margin: 0;
10892
min-width: 0;
10993
}
94+
95+
.inProgress {
96+
color: var(--icon-status-progress);
97+
}
98+
.done {
99+
color: var(--icon-status-complete);
100+
}
101+
.feedback {
102+
display: flex;
103+
flex-wrap: wrap;
104+
align-items: center;
105+
gap: var(--space-3);
106+
}
107+
.feedback p {
108+
flex: 1 1 16rem;
109+
margin: 0;
110+
}

0 commit comments

Comments
 (0)