Skip to content

Commit 6565eea

Browse files
mahanticodex
andauthored
Unify agent activity with incoming message previews (#1729)
Agent work now stays on the incoming side of the conversation, moving from typing dots to tool details and recorded steps without a second floating indicator. Completed and superseded activity leaves the message flow; its history remains available in Activity. - Working indicators open an Activity popover with a full-activity link and per-request Stop controls when available. Steering retires the old tool-call bubble while the new request remains visible. - Use content-sized, outlined bubbles for work updates. Active text shimmers; initial thinking uses 4px dots. Expanded helper history stays inside one outline, with up to three agents in the group avatar. - Share the same activity presentation across channels, threads, and media comments. Match live activity to its triggering request so unrelated work is not hidden or shown twice. Remote/public typing uses the same incoming presentation with short explanations when details are unavailable. - Keep human typing above the composer. Preserve message grouping, exact-message navigation, and saved reading positions when activity history expands or collapses. - Reuse the message frame, Avatar, ShimmerText, TypingDots, and existing activity stores. Agent execution, protocol, persistence, and identity behavior are unchanged. The development playground and replay modules are preserved locally and excluded from this PR. ## Validation - Independent review completed for the activity lifecycle, focus, accessibility, and scroll fixes. Regression checks reproduced the original defects before their repairs. - Updated existing browser journeys for incoming activity bubbles, the Activity popover, grouped avatars, and hidden completed steps. No browser journeys were added or removed. Native geometry, focus, hit-testing, navigation, draft retention, Stop, and image-decoding assertions remain covered. - The affected browser files passed across Chromium and WebKit in focused runs, including the nested activity scroll regression. The full media-controls file passed all 22 cases. Thread-history cases now pass with one conversation live region. - The final two component files passed 64 tests, and TypeScript passed. The four files adjusted after the full gate passed another 508 tests. Mandatory push-check results are reported in the update comment for the pushed commit. - The existing own-send regression confirms that an unchanged activity tail stays visible after sending; both browser engines passed. ## Draft limitations - Fresh hosted CI and reviewer/code-owner approval are pending. - Final native desktop scroll/focus behavior, retained dialogs, enlarged text, and explicit human acceptance remain pending. No review-completion attestation is claimed. - The human typing indicator can overlap the live-recovery banner; this separate known layout case remains open. Media frame-control overlap is fixed. - Missing activity signals cannot distinguish cancellation, disconnection, or failure. Missing details do not establish which host is running the agent. --------- Signed-off-by: Arjun Mahanti <[email protected]> Co-authored-by: OpenAI Codex <[email protected]> Co-authored-by: OpenAI Codex <[email protected]>
1 parent 67f6229 commit 6565eea

83 files changed

Lines changed: 6343 additions & 1700 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎docs/agents.md‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1074,6 +1074,25 @@ beyond 30 seconds or disconnect makes work unknown, not stopped. Terminal state
10741074
retains a monotonic evidence timestamp through clock rollback and bounded eviction.
10751075
There is no agent-global sequence gate: producer sequences reset, skip and interleave.
10761076

1077+
### Activity updates in the conversation
1078+
1079+
Conversation visibility is separate from execution status. Activity updates use
1080+
explicit immediate reply IDs and activity message IDs to select request lifecycle
1081+
evidence; a nearby human message or a shared thread root is not proof of a turn.
1082+
Consecutive updates from different requests or threads remain separate groups.
1083+
Known waiting, working, failed, or uncertain work stays visible even after a public
1084+
reply. Once every represented agent has settled successfully, stopped, or been
1085+
superseded, the updates leave the conversation flow. History and exact message
1086+
links remain available.
1087+
1088+
When lifecycle evidence is missing (including historical conversations after a
1089+
reload), the next public reply can retire older updates from the same request
1090+
if its author participated in the exchange or received the helper's last update.
1091+
This is a display fallback, not a claim that execution completed. It never
1092+
overrides available pending, failed, or uncertain lifecycle evidence. Durable
1093+
cross-host completion would require retained request/turn relationships and
1094+
terminal events; the current live-only feed does not provide that guarantee.
1095+
10771096
### Try with an existing owner account
10781097

10791098
Use the [public-pin/Keychain setup](contributing.md#live-relay-development) and run

‎docs/buzz-help.md‎

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -268,6 +268,12 @@ available rather than silently discarding it.
268268
transcripts in the agent's profile. A turn's **Thread** or **Channel** label
269269
opens that conversation. Working indicators describe current work,
270270
not a guarantee that an agent is available or that a message was delivered.
271+
Expand grouped work updates to read each message; the collapsed excerpt names
272+
its speaker. Thread work appears inside its thread; the channel’s reply summary
273+
still shows when an agent is working there. Expand recorded work to
274+
open its transcript or **Stop** the running request; before any work updates
275+
arrive, those controls appear on the live indicator. Stop availability depends
276+
on the agent type.
271277
- When a request to an agent running on this device fails, the activity under
272278
the message offers **Retry**, which asks the agent again, and **Dismiss**,
273279
which hides the failure.

‎src/app/pages.integration.test.mjs‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -287,7 +287,7 @@ test("the app runtime exposes ready bundled pages and removes them on disable",
287287
.snapshot()
288288
.map(({ id, placement }) => [id, placement]),
289289
[
290-
["activity", "message"],
290+
["activity", "response"],
291291
["typing-presentation", undefined],
292292
],
293293
);

‎src/bundled/agent-activity/ActivityAccessory.module.css‎

Lines changed: 7 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
.root {
2-
margin-block-start: var(--space-1);
2+
margin-block-start: var(--space-half);
33
min-width: 0;
44
flex-shrink: 0;
55
}
@@ -8,19 +8,6 @@
88
flex-direction: column;
99
gap: var(--space-1);
1010
}
11-
/* Dismiss and Stop are sibling actions, never buttons nested in NavigationItem. */
12-
.row {
13-
display: flex;
14-
align-items: center;
15-
gap: var(--space-1);
16-
}
17-
.row > :first-child {
18-
min-width: 0;
19-
flex: 1;
20-
}
21-
.row > :not(:first-child) {
22-
flex-shrink: 0;
23-
}
2411

2512
/* One glanceable line each, ending in an ellipsis; the profile's Activity tab
2613
* has the full text. NavigationItem's label truncation applies per line. */
@@ -44,16 +31,18 @@
4431
color: var(--text-subtle);
4532
display: inline-flex;
4633
align-items: center;
47-
flex-wrap: wrap;
34+
flex-wrap: nowrap;
4835
gap: var(--space-1);
4936
min-width: 0;
5037
}
5138

5239
.summaryGroups {
40+
min-width: 0;
41+
max-width: 100%;
5342
display: inline-flex;
5443
align-items: center;
5544
gap: var(--space-1);
56-
flex-wrap: wrap;
45+
flex-wrap: nowrap;
5746
}
5847
.failure {
5948
color: var(--text-danger);
@@ -68,6 +57,8 @@
6857
}
6958

7059
.action {
60+
align-self: center;
61+
flex-shrink: 0;
7162
display: inline-flex;
7263
align-items: center;
7364
gap: var(--space-1);

0 commit comments

Comments
 (0)