You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 17a82a6
Browse filesBrowse the repository at this point in the historyBrowse files
fix(identity): let Buzz copies that share an FI session sign in and out
Buzz copies of one debug/release flavour share each sign-in server's
Keychain item, whatever their app identifier, like the human key. That
sharing stays. But a running copy read the item only once, and its
compare-and-swap writes then failed whenever another copy had written
since. With Buzz and Buzz Staging both using the public server, or two
debug worktrees:
- Sign-in in the stale copy failed with "Sign-in did not finish. Try
again." after a full browser trip, and kept failing until restart.
- Sign-out in the stale copy showed "Couldn't sign out of ...", although
the session was already gone, and its Try again could delete the other
copy's newer session.
A signed-out copy now reads the item again before a browser sign-in. If
another copy saved a session, it restores and verifies that session
instead, with no browser. An empty item or a failed read starts the
browser sign-in as before. A sign-out whose removal finds the session
already ended or replaced now finishes signed out. The stale record's
refusal marker stays, so a record put back later cannot restore, and
the newer session is left alone.
No migration: service, account, index folder and the Sign out of Buzz
wipe are unchanged. The store and docs/identity.md now say the session
is shared across copies, and docs/buzz-help.md tells people what that
means for sign-in and sign-out.
Tests cover adopting another copy's session at sign-in and a stale
sign-out (session emptied or replaced); both fail without this change.
A store test pins that a stale removal keeps its refusal marker and the
newer session.
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Matt Toohey <[email protected]>
0 commit comments