Skip to content

fix(mobile): drop the iOS share extension from the build until it's signed - #9489

Merged
brow merged 1 commit into
mainfrom
revert-share-extension-target
Nov 14, 2026
Merged

brow merged 1 commit into
mainfrom
revert-share-extension-target

Conversation

@brow

@brow brow commented Nov 13, 2026 •

Copy link
Copy Markdown
Collaborator

iOS release builds of main fail at export with "No profiles for xyz.block.buzz.dogfood.mobile.ShareExtension were found" (buzz-mobile-releases build 62). #9433 iOS share sheet added a ShareExtension target, and the release signing setup has no app ID or provisioning profile for it yet.

This unhooks the ShareExtension target from the Xcode project (target, embed step and build settings) so the app builds and signs as it did before #9433. Nothing else changes:

  • The extension's sources stay in mobile/ios/ShareExtension/, so restoring it once the profiles exist is a revert of this commit.
  • The app's share hand-off code and outgoing share suggestions stay. Without the extension, Buzz just doesn't appear in the share sheet, as before feat(mobile): share into Buzz from the iOS share sheet #9433, and the hand-off never runs.

Regressions

  • Sharing into Buzz from the iOS share sheet goes away until the profiles are registered. That's the point of this PR.
  • The app still donates INSendMessageIntent after a send. iOS only shows those as share suggestions for an app whose share extension declares the intent, so they stay invisible until the extension returns.

Validation

  • iOS simulator debug build of the app succeeds with the target removed.
  • No other target referenced ShareExtension (it had no target dependencies).
  • Automated full-app run skipped: this only removes a build target, and the app code is unchanged.

The release signing setup has no provisioning profile for the
ShareExtension target added in #9433, so iOS release builds fail at
export. Unhook the target from the Xcode project until the profiles are
registered. The extension sources, the app's share hand-off and its
share suggestions stay in place; without the extension the hand-off
never runs.

Signed-off-by: Tom Brow <[email protected]>
@brow
brow marked this pull request as ready for review November 13, 2026 23:34
@brow
brow requested a review from a team as a code owner November 13, 2026 23:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T23:35:20.869128Z 82017f7 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brow
brow deployed to codex-review November 13, 2026 23:34 — with GitHub Actions Active
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 13, 2026
@github-actions

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: bf422ac8e1a34893e15c91bfc86a74d990547feb...82017f71415857240ba92a63d6763d3d8547de9d
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

No concrete findings. The change consistently removes the iOS share extension from the Xcode project without leaving dangling target references or changing other targets.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only inspection. Builds, tests, and signing export were not executed.

Generated by Codex Security Review |
Requested by: @brow |
Workflow run

@brow
brow enabled auto-merge (squash) November 13, 2026 23:43

@wesbillman wesbillman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.

No blockers. Reviewed at 82017f7.

  • The diff is the exact inverse of #9433's ShareExtension portion of project.pbxproj: diffing this head against #9433's parent leaves only the four ShareSuggestions.swift lines for the Runner target. Nothing outside mobile/ios/ShareExtension/ references the target, and Runner.entitlements is unchanged, so the app signs with the same capabilities it had before #9433.
  • Mobile Swift (Release) and Mobile Swift (Native) CI are green.
  • Gap: the release export and signing config live outside this repo, so the real proof is the next buzz-mobile-releases build exporting successfully.

@brow
brow merged commit abca3cd into main Nov 14, 2026
101 of 102 checks passed
@brow
brow deleted the revert-share-extension-target branch November 14, 2026 00:09
wpfleger96 added a commit that referenced this pull request Nov 14, 2026
* origin/main: (24 commits)
  docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493)
  test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442)
  test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440)
  fix(mobile): drop the iOS share extension from the build until it's signed (#9489)
  chore(release): release Buzz Desktop version 0.5.30 (#9491)
  perf(mobile): parse each event's thread reference once (#9460)
  perf(mobile): load only the directory when search opens (#9466)
  perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459)
  perf(mobile): ask typing subscriptions only for the typing window (#9454)
  perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448)
  perf(mobile): download the identity archive list only when it changed (#9445)
  perf(mobile): don't treat a Control Center pull as a resume (#9443)
  fix(mobile): keep a superseded roster read out of the offline snapshot (#9452)
  perf(mobile): read channel bot roles from the member list (#9451)
  perf(mobile): read Activity once per reconnect (#9455)
  fix(mobile): offer role controls for agents (#9475)
  perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458)
  perf(mobile): keep verified-name batches open as people are added (#9450)
  perf(mobile): read only changed custom emoji sets on reconnect (#9446)
  perf(mobile): keep latest-message times on a directory load (#9457)
  ...

Signed-off-by: Will Pfleger <[email protected]>

# Conflicts:
#	crates/buzz-cli/src/desktop_provider.rs
bostonaholic added a commit that referenced this pull request Nov 14, 2026
…eaction-recipients

* origin/main: (111 commits)
  perf(acp): avoid repeated observer batch serialization (#9483)
  docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493)
  test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442)
  test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440)
  fix(mobile): drop the iOS share extension from the build until it's signed (#9489)
  chore(release): release Buzz Desktop version 0.5.30 (#9491)
  perf(mobile): parse each event's thread reference once (#9460)
  perf(mobile): load only the directory when search opens (#9466)
  perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459)
  perf(mobile): ask typing subscriptions only for the typing window (#9454)
  perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448)
  perf(mobile): download the identity archive list only when it changed (#9445)
  perf(mobile): don't treat a Control Center pull as a resume (#9443)
  fix(mobile): keep a superseded roster read out of the offline snapshot (#9452)
  perf(mobile): read channel bot roles from the member list (#9451)
  perf(mobile): read Activity once per reconnect (#9455)
  fix(mobile): offer role controls for agents (#9475)
  perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458)
  perf(mobile): keep verified-name batches open as people are added (#9450)
  perf(mobile): read only changed custom emoji sets on reconnect (#9446)
  ...

Signed-off-by: Matthew Boston <[email protected]>

This branch was successfully deployed

1 active deployment
codex-review — 82017f71 Deployed Nov 13, 2026 by brow via Run Codex Security Review #15121
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants