Repository navigation
fix(mobile): drop the iOS share extension from the build until it's signed - #9489
Conversation
The release signing setup has no provisioning profile for the ShareExtension target added in #9433, so iOS release builds fail at export. Unhook the target from the Xcode project until the profiles are registered. The extension sources, the app's share hand-off and its share suggestions stay in place; without the extension the hand-off never runs. Signed-off-by: Tom Brow <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
wesbillman
left a comment
There was a problem hiding this comment.
🤖 Carl, an automated reviewer, commenting via Wes's GitHub account.
No blockers. Reviewed at 82017f7.
- The diff is the exact inverse of #9433's ShareExtension portion of
project.pbxproj: diffing this head against #9433's parent leaves only the fourShareSuggestions.swiftlines for the Runner target. Nothing outsidemobile/ios/ShareExtension/references the target, andRunner.entitlementsis unchanged, so the app signs with the same capabilities it had before #9433. Mobile Swift (Release)andMobile Swift (Native)CI are green.- Gap: the release export and signing config live outside this repo, so the real proof is the next
buzz-mobile-releasesbuild exporting successfully.
* origin/main: (24 commits) docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493) test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442) test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440) fix(mobile): drop the iOS share extension from the build until it's signed (#9489) chore(release): release Buzz Desktop version 0.5.30 (#9491) perf(mobile): parse each event's thread reference once (#9460) perf(mobile): load only the directory when search opens (#9466) perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459) perf(mobile): ask typing subscriptions only for the typing window (#9454) perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448) perf(mobile): download the identity archive list only when it changed (#9445) perf(mobile): don't treat a Control Center pull as a resume (#9443) fix(mobile): keep a superseded roster read out of the offline snapshot (#9452) perf(mobile): read channel bot roles from the member list (#9451) perf(mobile): read Activity once per reconnect (#9455) fix(mobile): offer role controls for agents (#9475) perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458) perf(mobile): keep verified-name batches open as people are added (#9450) perf(mobile): read only changed custom emoji sets on reconnect (#9446) perf(mobile): keep latest-message times on a directory load (#9457) ... Signed-off-by: Will Pfleger <[email protected]> # Conflicts: # crates/buzz-cli/src/desktop_provider.rs
…eaction-recipients * origin/main: (111 commits) perf(acp): avoid repeated observer batch serialization (#9483) docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493) test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442) test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440) fix(mobile): drop the iOS share extension from the build until it's signed (#9489) chore(release): release Buzz Desktop version 0.5.30 (#9491) perf(mobile): parse each event's thread reference once (#9460) perf(mobile): load only the directory when search opens (#9466) perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459) perf(mobile): ask typing subscriptions only for the typing window (#9454) perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448) perf(mobile): download the identity archive list only when it changed (#9445) perf(mobile): don't treat a Control Center pull as a resume (#9443) fix(mobile): keep a superseded roster read out of the offline snapshot (#9452) perf(mobile): read channel bot roles from the member list (#9451) perf(mobile): read Activity once per reconnect (#9455) fix(mobile): offer role controls for agents (#9475) perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458) perf(mobile): keep verified-name batches open as people are added (#9450) perf(mobile): read only changed custom emoji sets on reconnect (#9446) ... Signed-off-by: Matthew Boston <[email protected]>
iOS release builds of main fail at export with "No profiles for
xyz.block.buzz.dogfood.mobile.ShareExtensionwere found" (buzz-mobile-releases build 62). #9433 iOS share sheet added a ShareExtension target, and the release signing setup has no app ID or provisioning profile for it yet.This unhooks the ShareExtension target from the Xcode project (target, embed step and build settings) so the app builds and signs as it did before #9433. Nothing else changes:
mobile/ios/ShareExtension/, so restoring it once the profiles exist is a revert of this commit.Regressions
INSendMessageIntentafter a send. iOS only shows those as share suggestions for an app whose share extension declares the intent, so they stay invisible until the extension returns.Validation