Repository navigation
perf(mobile): load only the directory when search opens - #9466
Conversation
Opening search on a loaded list now reads only the kind:39000 directory and merges it into the current list. Joined channels keep their entries, and non-member open channels are rebuilt with the same visibility rules as a full refresh. The first load still takes the full path. A directory-only load does not retire an in-flight membership refresh. A refresh that merged an older directory re-applies the newer one before it installs its list, a newer directory load wins over an older one, and a scope switch discards the response. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Signed-off-by: Tom Brow <[email protected]>
|
@codex review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
A directory-only search load kept its ownership marker after a community or identity switch retired it. On returning to the first community, the list refresh treated the abandoned loading status as owned by a live load and left it in place, so search never loaded the directory again. A scope switch now retires directory-only loads too: it advances the directory generation and clears the marker. Tests cover returning both while the old request is in flight and after it ended. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Signed-off-by: Tom Brow <[email protected]>
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
kazemek21
left a comment
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes and approved without comments.
Posted by Codex (gpt-6.1-sol) on behalf of kylez.
* origin/main: (24 commits) docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493) test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442) test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440) fix(mobile): drop the iOS share extension from the build until it's signed (#9489) chore(release): release Buzz Desktop version 0.5.30 (#9491) perf(mobile): parse each event's thread reference once (#9460) perf(mobile): load only the directory when search opens (#9466) perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459) perf(mobile): ask typing subscriptions only for the typing window (#9454) perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448) perf(mobile): download the identity archive list only when it changed (#9445) perf(mobile): don't treat a Control Center pull as a resume (#9443) fix(mobile): keep a superseded roster read out of the offline snapshot (#9452) perf(mobile): read channel bot roles from the member list (#9451) perf(mobile): read Activity once per reconnect (#9455) fix(mobile): offer role controls for agents (#9475) perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458) perf(mobile): keep verified-name batches open as people are added (#9450) perf(mobile): read only changed custom emoji sets on reconnect (#9446) perf(mobile): keep latest-message times on a directory load (#9457) ... Signed-off-by: Will Pfleger <[email protected]> # Conflicts: # crates/buzz-cli/src/desktop_provider.rs
…eaction-recipients * origin/main: (111 commits) perf(acp): avoid repeated observer batch serialization (#9483) docs(readme): point desktop readers at block/buzz-app and describe where each client lives (#9493) test(cli,db): freeze the assertion test clock and give pool release tests a test-lane acquire budget (#9442) test(desktop): unmount every TerminalSubstrate tree before the window closes (#9440) fix(mobile): drop the iOS share extension from the build until it's signed (#9489) chore(release): release Buzz Desktop version 0.5.30 (#9491) perf(mobile): parse each event's thread reference once (#9460) perf(mobile): load only the directory when search opens (#9466) perf(mobile): stop rebuilding Home's channel list when a route covers it (#9459) perf(mobile): ask typing subscriptions only for the typing window (#9454) perf(mobile): skip avatar URL parsing for non-HTTP URLs (#9448) perf(mobile): download the identity archive list only when it changed (#9445) perf(mobile): don't treat a Control Center pull as a resume (#9443) fix(mobile): keep a superseded roster read out of the offline snapshot (#9452) perf(mobile): read channel bot roles from the member list (#9451) perf(mobile): read Activity once per reconnect (#9455) fix(mobile): offer role controls for agents (#9475) perf(mobile): stop rebuilding the native nav bar on every scrolled frame (#9458) perf(mobile): keep verified-name batches open as people are added (#9450) perf(mobile): read only changed custom emoji sets on reconnect (#9446) ... Signed-off-by: Matthew Boston <[email protected]>
Opening search on a list that is already loaded refreshed the whole channel list to get the open-channel directory: the membership rosters (kind 39002), member channel metadata, hidden DMs, Huddle starts, DM names and the latest messages of every joined channel, then the directory pages. Only the directory was what search needed; everything else was already in the list and kept current by live updates.
Search now reads only the directory pages and merges them into the current list: every channel you are not a member of is rebuilt from the fresh directory (latest revision per channel, open and non-DM only, the same rules as a full refresh), and joined channels keep their entries untouched. When the list has not loaded yet, the full refresh runs as before.
Races:
Results
iPhone 12 mini, profile build, Builderlab account. Typing a query into search on a loaded list, more than 30 seconds after the last directory load (two runs each, same numbers both times):
Unjoined open channels still appear in results with their Open badge.
Regressions
The tradeoff we accept: on a search open, joined channels' member counts, unread badges and latest-message times are not re-read; they show what the last full refresh found, as updated by live events since. Live join and leave notices, metadata changes and new messages still apply as they arrive, and the next ordinary refresh (launch, reconnect, resume, pull to refresh) re-reads everything. The case that differs is a change that live delivery missed on a healthy connection (for example a roster change made while a live chunk was briefly refused): before, opening search happened to repair it; now the next ordinary refresh does.
Nothing else changes: open channels are listed under the same visibility rules, a failed directory load still reports its error to search and keeps the cached discovery, and the first load is unchanged.
Testing
flutter analyzeclean.