Repository navigation
fix(mobile): keep shared Solo chats listed while filing loads - #9419
Merged
ebroderick merged 1 commit intoNov 12, 2026
Merged
Conversation
Shared and agent-created Solo chats left Team unconditionally, but the Me page and its unread set waited on the optional filing record. With no usable record (fresh sign-in, offline without a Me cache), those chats were listed and badged nowhere. Build both from the channel list and show the record's status above the unfiled list instead. Signed-off-by: Tom Brow <[email protected]> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
brow
marked this pull request as ready for review
November 12, 2026 20:56
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
ebroderick
pushed a commit
that referenced
this pull request
Nov 12, 2026
## Summary Fix for a blocking review finding on #9348 ([review thread](buzz://message?channel=95213a25-483a-458b-9bc3-71891fa5aef6&id=8ad087852227b50d614760eb4778734e306faf70df77e0ecd16cb5816b865bbc)). **Wait, what?** #9348 removes shared and agent-created Solo chats from Team as soon as the channel list loads, but the Solo list and its unread badges waited for the separate encrypted filing record. With no usable record (fresh install or sign-in before it arrives, offline without a Me cache), those chats were listed and badged nowhere. Before #9348 they were reachable under Team. **Now:** Solo builds its chat list and unread set from the channel list alone. While the filing record loads or fails, its spinner or "Try again" shows as the first item above an unfiled "Chats" list, with no project sections and no "No chats yet" empty state. Legacy (pre-label) chats and project filing join when the record arrives. New chat / New project stay disabled until then, and nothing is written from the unavailable state. **Nothing gets worse:** with the record loaded, the page renders exactly as before. The only visible change is in the loading/error state, where the status moves from replacing the list to sitting above it. ### Testing Added tests: - `me_page_test`: Home with an ordinary chat and a labelled shared chat, filing record failing or still loading. The shared chat is listed under Solo, the ordinary one under Team, and the status (retry or spinner) is shown. Both fail on #9348's head. - `me_unread_test`: a labelled shared chat with a new message is counted before the record loads, and a legacy id joins once it arrives. Fails on #9348's head. The existing "unavailable preferences show retry instead of empty state" test still passes. Full mobile suite and `mobile-check` pass locally. Signed-off-by: Tom Brow <[email protected]> Co-authored-by: Tom Brow <[email protected]> Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Signed-off-by: Evan Broderick <[email protected]> Co-authored-by: coder <e509b66797ba43fd355dc12801a0c1ba376b06924147c65abdafa7ababcf8e2e@buzz.block.builderlab.xyz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for a blocking review finding on #9348 (review thread).
Wait, what? #9348 removes shared and agent-created Solo chats from Team as soon as the channel list loads, but the Solo list and its unread badges waited for the separate encrypted filing record. With no usable record (fresh install or sign-in before it arrives, offline without a Me cache), those chats were listed and badged nowhere. Before #9348 they were reachable under Team.
Now: Solo builds its chat list and unread set from the channel list alone. While the filing record loads or fails, its spinner or "Try again" shows as the first item above an unfiled "Chats" list, with no project sections and no "No chats yet" empty state. Legacy (pre-label) chats and project filing join when the record arrives. New chat / New project stay disabled until then, and nothing is written from the unavailable state.
Nothing gets worse: with the record loaded, the page renders exactly as before. The only visible change is in the loading/error state, where the status moves from replacing the list to sitting above it.
Testing
Added tests:
me_page_test: Home with an ordinary chat and a labelled shared chat, filing record failing or still loading. The shared chat is listed under Solo, the ordinary one under Team, and the status (retry or spinner) is shown. Both fail on fix(mobile): show shared chats under Solo #9348's head.me_unread_test: a labelled shared chat with a new message is counted before the record loads, and a legacy id joins once it arrives. Fails on fix(mobile): show shared chats under Solo #9348's head.The existing "unavailable preferences show retry instead of empty state" test still passes. Full mobile suite and
mobile-checkpass locally.