Repository navigation
fix(mobile): hide clipped section rows from semantics while opening - #9416
Merged
michaelfransen merged 1 commit intoNov 12, 2026
Merged
Conversation
The lazy section body clips painting during the expand animation but did not report that clip to the semantics compiler, so rows still under the clip were reachable by screen readers until the animation finished. Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz> Signed-off-by: Tom Brow <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for a regression found in review of #9401 lazy section rows. This PR targets that PR's branch.
While a channel section opens,
CollapsibleSliverBodyclips painting to the revealed extent, but its render object didn't report that clip to the semantics compiler (RenderProxySliverinheritsdescribeApproximatePaintClip => null). Every mounted row under the clip, including rows drawn beneath the following section, stayed a reachable screen-reader node until the 220 ms animation finished. The oldClipRect-based body reported its clip, so those rows were excluded.The fix reports the same rect that
paintclips to while the section is animating, and nothing once it's fully open.Pareto: accessibility returns to the pre-#9401 behavior during the expand animation; painting, layout and hit testing are unchanged, and the fully open and collapsed states produce the same semantics tree as before.
Validation
collapsible_sliver_body_test.dartopens a 10-row section and, one frame in, checks that screen readers reach exactly the rows above the painted extent (rows 0 to 3), then that all ten are reachable once open. It fails without the override (Row 4 reachable while drawn below the clip).just mobile-checkpass locally.