Skip to content

fix(mobile): keep shortcut taps and the member picker from wedging - #9388

Merged
brow merged 1 commit into
mainfrom
mobile-shortcut-hardening
Nov 12, 2026
Merged

fix(mobile): keep shortcut taps and the member picker from wedging#9388
brow merged 1 commit into
mainfrom
mobile-shortcut-hardening

Conversation

@brow

@brow brow commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Follow-up to review notes on #9360 Home Screen shortcuts. These are fixes for rare races, with no visible change.

  • The member picker can't wedge. UIKit ignores a dismiss that arrives mid-transition (the sheet still animating in, or during an interactive swipe-down) and never runs its completion. The picker coordinator queues every later present behind that completion, so New DM and Add members then opened nothing for the rest of the session. Dismiss now waits for the transition to finish, then dismisses whatever is still presented.
  • A shortcut tap reaches Dart once. The native bridge both buffered a tap and sent it, so a tap during cold launch could arrive twice and run again after Home had already handled it. Now a tap is buffered only until Dart first takes the pending one, and after that it is sent directly.
  • Signing out drops a waiting tap. Removing Home clears a tap that is still waiting (for example on a Bestie that is still loading), so it can't run in the next account's Home.

Not included: carrying the Bestie's pubkey in the shortcut item, so a stale "Message Alice" falls back to Agents rather than opening the current Bestie. It's optional, and it would change the bridge's payload shared with the lock screen widgets in #9373 lock screen widgets.

Validation

  • The Home shortcut journey gains a step: a tap waiting while the app is inactive is cleared when Home goes away. The step fails with the teardown guard removed.
  • Automated simulator run (iPhone 17 Pro, iOS 27, signed in to a Builderlab test community), driving the app icon's quick actions on the Home Screen:
    • New DM from a conversation opens the picker. New DM again, with the picker already open, replaces it. New chat over the picker closes it and opens a draft, and New DM after that opens the picker again (it doesn't get stuck).
    • Message (Bestie) opens the Bestie conversation.
    • Cold launch through New chat opens exactly one New chat screen. Back returns to Messages.

buzz-review-completed

@square-tomb @claude
fix(mobile): keep shortcut taps and the member picker from wedging
ee214ea 
Follow-up to review notes on the Home Screen shortcuts.

- The member picker's dismiss waits for an in-flight transition (the
  sheet still animating in, or an interactive swipe-down). UIKit ignores
  a dismiss mid-transition and never runs its completion, which held
  every later New DM or Add members present forever.
- Native shortcut taps reach Dart once: buffered until Dart first takes
  the pending tap, then sent directly, instead of both.
- Home's teardown drops a tap still waiting, so it can't run in the next
  account's Home.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Tom Brow <[email protected]>
@brow
brow marked this pull request as ready for review November 12, 2026 19:58
@brow
brow requested a review from a team as a code owner November 12, 2026 19:58
@brow
brow enabled auto-merge (squash) November 12, 2026 19:58
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T20:00:06.703897Z ee214ea Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brow
brow deployed to codex-review November 12, 2026 19:58 — with GitHub Actions Active
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: fc8c802253155fa8721bafb26e442cd3986ff303...ee214eac2d6d5dd1ae36d841006fa2f88f50800a
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.

Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability findings in the authorized PR range after tracing shortcut delivery, Home teardown, and member-picker dismissal through their callers.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source inspection. Builds, tests, and iOS runtime validation were not performed.

Generated by Codex Security Review |
Requested by: @brow |
Workflow run

kazemek21
kazemek21 approved these changes Nov 12, 2026
View reviewed changes

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle reviewed this PR and the Nexus review-tracker notes and approved without comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@brow
brow merged commit 60b7fb8 into main Nov 12, 2026
60 checks passed
@brow
brow deleted the mobile-shortcut-hardening branch November 12, 2026 22:09
ravarora2 added a commit that referenced this pull request Nov 12, 2026
@ravarora2
Merge remote-tracking branch 'origin/main' into rarora/media-handler-…
e2b3161 
…small

* origin/main:
  perf(acp): reduce observer CPU and lock overhead (#9381)
  ci: fix main — stale RunCause call sites and Playwright on ubuntu-26.04 (#9418)
  fix(mobile): keep shortcut taps and the member picker from wedging (#9388)
  fix(mobile/ios): close notification code blocks only at line-ending fences (#9349)
  fix(media): run thumbnail regeneration tests in CI and cap rebuild pixels (#9198)
  fix(mobile): never show emoji shortcodes in reaction pills (#9411)
  fix(mobile): isolate channel header scroll rebuilds (#9400)

Signed-off-by: Ravneet Arora <[email protected]>

This branch was successfully deployed

1 active deployment
codex-review — ee214eac Deployed Nov 12, 2026 by brow via Run Codex Security Review #14657
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazemek21 kazemek21 kazemek21 approved these changes

Assignees

No one assigned

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brow @kazemek21 @square-tomb