Skip to content

fix(mobile): restore header cues and per-channel identity check for #9369 - #9370

Merged
brow merged 1 commit into
mainfrom
fix-9369-header-regressions
Nov 12, 2026
Merged

fix(mobile): restore header cues and per-channel identity check for #9369#9370
brow merged 1 commit into
mainfrom
fix-9369-header-regressions

Conversation

@brow

@brow brow commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Follow-up to #9369 (conversation header avatars). Fixes two regressions found in its review. The intended behavior of #9369 stays the same.

  1. Message rows no longer each scan the roster. showMessageAuthorName ran at the top of every message and thread row, in every channel. Each run watched a whole Channel object (which has no value equality) and built sets from the full roster, plus two more sets for the stale-DM check in DMs. A new confirmedConversationPairProvider works out the two-person pair once per channel, including the rule that a DM keeps attribution while its metadata disagrees with the roster. It returns a record that compares by value, so rows rebuild only when the pair itself changes. It reads watchLatestChannelMembers, so a revisit uses the cached roster and rows no longer re-wrap 48 dp wider once the roster fetch returns. The visible rule is the same as before.
  2. Android private channels show the lock again. Every Android conversation header now uses the compact title pill, which had no lock. The pill now shows the existing lock icon (and its "Private channel" label) before the name.

Validation

  • Added tests, all extending existing journeys:
    • The author-visibility journey checks that replacing the channel object (as live activity does) doesn't notify rows when the pair is unchanged. Its existing stale-dm case covers the metadata rule now inside the provider.
    • The private-lock header test expects the lock again.
  • Each new or restored Dart assertion fails with its fix reverted, and so does the stale-dm case with the provider's metadata rule removed.
  • Full mobile suite (just mobile-test) and flutter analyze pass.
  • Not run: an automated full-app session on a simulator or device.

🤖 Generated with Claude Code

@brow

brow commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T02:58:26.713039Z 2a9af30 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 75946f06b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@brow
brow force-pushed the fix-9369-header-regressions branch from 75946f0 to 726e8d5 Compare November 11, 2026 22:50
@brow

brow commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. What shall we delve into next?

Reviewed commit: 726e8d5b1f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@brow
brow force-pushed the fix-9369-header-regressions branch from 726e8d5 to 94aec27 Compare November 11, 2026 23:11
Base automatically changed from kennylopez-dm-header-avatar-20261111 to main November 11, 2026 23:28
@square-tomb studio @claude
fix(mobile): restore Android lock and per-channel identity check for #…
2a9af30 
…9369

- Compute the confirmed two-person pair once per channel as a value-equal
  record from the latest roster, including the stale-DM-metadata rule,
  instead of building roster sets in every message row on each emission.
- Show the private-channel lock in the Android compact title pill.

Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Tom Brow <[email protected]>
@brow
brow force-pushed the fix-9369-header-regressions branch from 94aec27 to 2a9af30 Compare November 11, 2026 23:33
@brow
brow marked this pull request as ready for review November 12, 2026 02:57
@brow
brow requested a review from a team as a code owner November 12, 2026 02:57
@brow
brow enabled auto-merge (squash) November 12, 2026 02:57
@brow
brow deployed to codex-review November 12, 2026 02:57 — with GitHub Actions Active
@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 12, 2026
@github-actions

github-actions Bot commented Nov 12, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: 4c60be6a1e8dc2c7839f7c0294391fb93941ed9f...2a9af30240c04b874392f7d4eabf0083e12d2b3d
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.

Review Summary

Overall Risk: NONE

No concrete security, correctness, or reliability findings in the authorized PR range. The shared attribution provider preserves scoped membership lookup, DM metadata consistency checks, and outsider attribution.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only source, caller, and test inspection. Builds and tests were not executed.

Generated by Codex Security Review |
Requested by: @brow |
Workflow run

kazemek21
kazemek21 approved these changes Nov 12, 2026
View reviewed changes

@kazemek21 kazemek21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kyle reviewed this PR and the Nexus review-tracker notes and approved with no comments.

Posted by Codex (gpt-6.1-sol) on behalf of kylez

@brow
brow merged commit c0e3011 into main Nov 12, 2026
60 checks passed
@brow
brow deleted the fix-9369-header-regressions branch November 12, 2026 14:21
ravarora2 pushed a commit that referenced this pull request Nov 12, 2026
dessert
Merge remote-tracking branch 'origin/main' into rarora/media-handler-…
966a1d8 
…small

* origin/main:
  fix(db): seek replaceable heads by channel (#9147)
  buzz-db: check events created_at floor in app writers (phase 1) (#8325)
  fix(mobile): keep a thread tail behind the keyboard unread (#9295)
  fix(mobile): restore header cues and per-channel identity check for #9369 (#9370)
  fix(relay): treat empty filter sets as match-nothing in SQL (#9342)
  buzz-cli: add --before and --before-id to messages search (#9382)
  feat(relay): agents cannot write in DMs except with their owner (#9371)
  fix(relay): bound each cross-node delivery attempt (#9305)
  feat(mobile): add iOS Home Screen shortcuts for New chat, New DM and the Bestie (#9360)
  perf(mobile): stop downloading whole videos for posterless stills (#9367)
  Enforce single-community relay mode (#9149)
  fix(relay): match #a tag filters in SQL before LIMIT (#9339)
  Add participant avatars to mobile conversation headers (#9369)
  fix(mobile): stop asking for an API token when the channel list is refused (#9327)
  chore(release): release Buzz Relay version 0.3.0 (#9362)
  Fix gallery video selection, thumbnails, and swipe dismissal (#9356)

Signed-off-by: dessert <7d616e7e143e5d408159614dccff1371350a1c1bd36c8de838a45ece5aca0aca@buzz.block.builderlab.xyz>

This branch was successfully deployed

1 active deployment
codex-review — 2a9af302 Deployed Nov 12, 2026 by brow via Run Codex Security Review #14550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kazemek21 kazemek21 kazemek21 approved these changes

Assignees

No one assigned

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@brow @kazemek21 @square-tomb