Skip to content

fix(mobile): hand the channel list to the banner only on a refused read - #9358

Closed
brow wants to merge 1 commit into
larry/mobile-channels-signin-badgefrom
tomb/9327-signin-gate
Closed

brow wants to merge 1 commit into
larry/mobile-channels-signin-badgefrom
tomb/9327-signin-gate

Conversation

@brow

@brow brow commented Nov 11, 2026

Copy link
Copy Markdown
Collaborator

Fix for #9327, targeting its branch.

On a signed-out organization session, #9327 swaps in the sign-in copy and hides Retry for any error when the channel list fails to load cold. It should only do that for the 401 refusal. Organization relays can serve a read without the organization sign-in (the session still sends its key auth and leaves the decision to the relay), so on those relays a timeout or a server error could be recovered with Retry before. With #9327, the screen points to browser sign-in instead and has no Retry. The error view has no pull-to-refresh either.

  • The banner takes over only on a 401. Every other error keeps its real message and Retry.
  • The copy now reads "Use the prompt above to reconnect." The banner sits at the top of the screen, above the error view. The new wording without "sign-in" also fits the banner's other states (sign-in in progress, access denied, could not connect).

Nothing gets worse: the refused-read case behaves as #9327 intended, and other errors return to their behavior before #9327.

Validation

  • Extended the existing "ended organization sign-in" widget test with a non-401 error on a signed-out organization session: the real message and Retry show. That step fails without the gate change.
  • Full mobile check and test suite: format and analysis clean, 4,615 main tests passed (92 skipped), plus the no-gateway and crypto-package tests.
  • No simulator run. The change is two strings and a condition on a cold-load error view that the widget test renders directly.

🤖 Generated with Claude Code

A signed-out organization session hid Retry for every cold-load error,
including timeouts and server errors on a relay that serves the read
without the organization sign-in. Gate the handoff on the 401 refusal,
and point to the prompt above, where the banner actually sits.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
loganj added a commit that referenced this pull request Nov 11, 2026
The ended-sign-in copy and the hidden Retry now apply only when the relay
refuses the read with a 401. Organization relays can serve a read without
the organization sign-in, so a timeout or server error keeps its message and
Retry, as before this PR. The copy points up: the sign-in prompt sits at the
top of Home.

From #9358.

Co-authored-by: Tom Brow <[email protected]>
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Logan Johnson <[email protected]>
@brow brow closed this Nov 11, 2026
@brow
brow deleted the tomb/9327-signin-gate branch November 11, 2026 20:58
loganj added a commit that referenced this pull request Nov 11, 2026
The ended-sign-in copy and the hidden Retry now apply only when the relay
refuses the read with a 401. Organization relays can serve a read without
the organization sign-in, so a timeout or server error keeps its message and
Retry, as before this PR. The copy points up: the sign-in prompt sits at the
top of Home.

From #9358.

Co-authored-by: Tom Brow <[email protected]>
Co-authored-by: Larry <627498bd4bd1f281a16431e3c6cce3b5c25b6692798c78672298aefbf2f8f8b5@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Logan Johnson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants