Repository navigation
perf(mobile): reuse the owned agent directory for Codex voice - #9289
Merged
klopez4212 merged 3 commits intoNov 9, 2026
Merged
Conversation
An agent DM already loads the owner's agent directory, with each agent's runtime, for mentions. Derive Codex voice eligibility from it instead of two more inventory reads per evaluation and reconnect. Drop the unused runtime filter on loadMeAgentInventory. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 740bc1e7c0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
klopez4212
approved these changes
Nov 9, 2026
Voice admission now waits on this read, so a relay that never ends pagination must fail it rather than hang. Use the 50-page budget the inventory loader already had. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
Call start, recovery and the invite confirmation rechecked the owned directory but kept a cached archive list, so a newly archived agent could still be invited. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Tom Brow <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Targets
mobile-codex-huddle-20261108(#9269).Opening a one-to-one agent DM already loads the owner's agent directory (
ownedAgentDirectoryProvider, used by the compose bar and mention candidates). It reads the kind 30177 inventory, verifies each registration and profile, and keeps each agent'sruntime. The Codex voice check added a second and third inventory read on top of that:loadMeAgentInventorywith a runtime filter, then a forced refresh ofmeAssistantsProvider, which reads the inventory again plus profiles and the archive list. Each one ran again on every reconnect.This derives Codex voice eligibility from the directory that's already loaded, minus desktop's known-archived agents (the cached
meArchivedAgentsProvider, as before). Voice adds no inventory read.runtime:filter onloadMeAgentInventoryhas no caller left, so it's removed and that file matchesmainagain.Validation
mobiletest suite andflutter analyzepass.channel_detail_page_test.dartstill pass.🤖 Generated with Claude Code