Skip to content

fix(relay): set received_at in the system-channel fan-out test helper - #9214

Merged
TheSentinel454 merged 1 commit into
mainfrom
fix-main-channel-event-received-at
Nov 6, 2026
Merged

TheSentinel454 merged 1 commit into
mainfrom
fix-main-channel-event-received-at

Conversation

@TheSentinel454

Copy link
Copy Markdown
Contributor

Summary

buzz-relay lib tests fail to compile on main: error[E0063]: missing field received_at in initializer of buzz_pubsub::ChannelEvent at crates/buzz-relay/src/handlers/system_channel_postgres_tests.rs:1549.

This is a semantic merge conflict. #9195 added ChannelEvent::received_at, and #8519 merged a minute later with a test helper that builds a ChannelEvent without it. Neither PR's CI saw the other. This sets the field to tokio::time::Instant::now(), as every other initializer does.

It breaks clippy (Rust Lint) and the backend-integration test archive for every open PR, because CI builds the merge with main.

Testing

  • cargo fmt --check and cargo clippy -p buzz-relay --all-targets -D warnings on a cloud workstation at this head.

What got simpler

Nothing; a one-field compile fix.

🤖 Generated with Claude Code

#9195 added ChannelEvent::received_at and #8519 merged right after it
with a test helper that builds a ChannelEvent without the field, so
buzz-relay lib tests no longer compile on main.

Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Luke Tornquist <[email protected]>
@TheSentinel454
TheSentinel454 marked this pull request as ready for review November 6, 2026 19:54
@TheSentinel454
TheSentinel454 requested a review from a team as a code owner November 6, 2026 19:54

@wpfleger96 wpfleger96 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 One-line compile fix: sets received_at: tokio::time::Instant::now() in the fan_out_from_another_pod helper, matching the field's type in buzz_pubsub::ChannelEvent and every other initializer. Checked every ChannelEvent initializer at this head; this was the only one missing the field.

@github-actions github-actions Bot added the codex-security-review-current The posted Codex security review matches its recorded range. label Nov 6, 2026
@github-actions

github-actions Bot commented Nov 6, 2026

Copy link
Copy Markdown

🔐 Codex Security Review

Note: This is an automated, security-focused review generated by Codex.
Use it as a supplement to human review; false positives are possible.

Scope

  • Exact PR diff: e670b672b8b25dae5bc387d683cf2b4e28ea3092...9655a90419e62cf85aaa9ef562105b552dec9c5f
  • Model: gpt-6.1-sol

💡 Click "edited" above to see earlier reviews for this PR.


Review Summary

Overall Risk: NONE

The sole change initializes received_at in a test helper consistently with the production Redis subscriber. No concrete security, correctness, or reliability findings in the authorized PR range.

Findings

No concrete security, correctness, or reliability findings were identified.

Notes

  • Review used read-only inspection. Builds and tests were not run, as instructed.

Generated by Codex Security Review |
Requested by: @TheSentinel454 |
Workflow run

@TheSentinel454
TheSentinel454 enabled auto-merge (squash) November 6, 2026 19:58
@TheSentinel454
TheSentinel454 merged commit 6c3ffd1 into main Nov 6, 2026
96 of 97 checks passed
@TheSentinel454
TheSentinel454 deleted the fix-main-channel-event-received-at branch November 6, 2026 20:18
bradseiler added a commit that referenced this pull request Nov 6, 2026
* origin/main:
  fix(relay): set received_at in the system-channel fan-out test helper (#9214)
  feat(mobile): move Activity to a Home bell and align Home spacing (#9212)
  Allow operators to set initial NIP-FI policy on create (#9211)
  perf(loadgen): spread seed writes across channel creators (#9206)
  feat(relay): runtime-tunable history-read and AUTH concurrency caps via feature flags (#9170)

Signed-off-by: Brad Seiler <[email protected]>

This branch was previously deployed

1 inactive deployment
codex-review — 9655a904 Deployed Nov 6, 2026 by TheSentinel454 via Run Codex Security Review #13610
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex-security-review-current The posted Codex security review matches its recorded range.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants