Repository navigation
fix(relay): set received_at in the system-channel fan-out test helper - #9214
Conversation
#9195 added ChannelEvent::received_at and #8519 merged right after it with a test helper that builds a ChannelEvent without the field, so buzz-relay lib tests no longer compile on main. Co-authored-by: Elrond <28d6302a099e5225b02c4155ac4236e4912603df2ab08dbfc2f4fef08ce598c8@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: Luke Tornquist <[email protected]>
wpfleger96
left a comment
There was a problem hiding this comment.
🤖 One-line compile fix: sets received_at: tokio::time::Instant::now() in the fan_out_from_another_pod helper, matching the field's type in buzz_pubsub::ChannelEvent and every other initializer. Checked every ChannelEvent initializer at this head; this was the only one missing the field.
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
* origin/main: fix(relay): set received_at in the system-channel fan-out test helper (#9214) feat(mobile): move Activity to a Home bell and align Home spacing (#9212) Allow operators to set initial NIP-FI policy on create (#9211) perf(loadgen): spread seed writes across channel creators (#9206) feat(relay): runtime-tunable history-read and AUTH concurrency caps via feature flags (#9170) Signed-off-by: Brad Seiler <[email protected]>
Summary
buzz-relaylib tests fail to compile onmain:error[E0063]: missing field received_at in initializer of buzz_pubsub::ChannelEventatcrates/buzz-relay/src/handlers/system_channel_postgres_tests.rs:1549.This is a semantic merge conflict. #9195 added
ChannelEvent::received_at, and #8519 merged a minute later with a test helper that builds aChannelEventwithout it. Neither PR's CI saw the other. This sets the field totokio::time::Instant::now(), as every other initializer does.It breaks clippy (
Rust Lint) and the backend-integration test archive for every open PR, because CI builds the merge withmain.Testing
cargo fmt --checkandcargo clippy -p buzz-relay --all-targets -D warningson a cloud workstation at this head.What got simpler
Nothing; a one-field compile fix.
🤖 Generated with Claude Code