Skip to content

feat(mobile): move Activity to a Home bell and align Home spacing - #9212

Merged
brow merged 1 commit into
mainfrom
home-bell-ui
Nov 6, 2026
Merged

brow merged 1 commit into
mainfrom
home-bell-ui

Conversation

@brow

@brow brow commented Nov 6, 2026 •

Copy link
Copy Markdown
Collaborator

The UI-only part of #9193 by @klopez4212, split out so it can land without the Activity sync changes.

  • Activity moves from a row in the Home list to a bell button in the Home header, with an unread dot driven by the existing Activity feed and read state.
  • Home filter capsules match native iOS and Android widths, with a subtle outline on Android when the header collapses.
  • Home section spacing is tighter.

Left out: the reconnect rewrite in #9193's last commit (live events applied in place, no rebuild on reconnect, fatal fallback reads). The Activity provider is unchanged from main. Channel and Solo rows keep their bottom padding so they stay at the 44 pt minimum tap height.

Validation

  • Kenny's added tests: inbox_unread_provider_test (unread dot) and the Home page bell and filter width tests.
  • Full mobile suite: all pass except 11 push and notification-toggle tests that fail identically on an unchanged checkout in this environment.
  • Automated simulator run (iPhone 17 Pro, iOS 27) of a build combining this PR with its sibling split: Home rows measure 44 pt, the bell opens Activity and shows its dot after a row is marked unread, type/sender/Unread filters each narrow the feed, a row opens its conversation, Search results scroll under the fade, and filter labels fit at the largest text size. Screenshots are in Buzz rather than here because they show internal test data. Android was covered only by widget tests.

Before merge

  • Automated simulator run of Home, the bell, Activity and channel navigation, with screenshots.

🤖 Generated with Claude Code

UI-only subset of #9193. Moves the Inbox entry to a bell in the Home
header with an unread dot, sizes the Home filter capsules to match
native iOS and Android widths, and tightens section spacing. Leaves
the Activity data flow and reconnect handling unchanged, and keeps
channel and Solo rows at the 44 pt minimum tap height.

Co-authored-by: kenny lopez <[email protected]>
Co-authored-by: studio <dc2fc481343672df31a689840c09299972e704dac592e0da6f18486646a7ee3e@buzz.block.builderlab.xyz>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Signed-off-by: Tom Brow <[email protected]>
@brow

brow commented Nov 6, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@brow
brow marked this pull request as ready for review November 6, 2026 19:44
@brow
brow requested a review from a team as a code owner November 6, 2026 19:44
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 6, 2026 •

Copy link
Copy Markdown
Codex Review Summary: 🔄 Running

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review 🔄 Running since 2026-11-06T19:44:59.319781Z e54bf0c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e54bf0cc96

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread mobile/lib/features/home/home_page.dart Resolved
@brow
brow merged commit beec055 into main Nov 6, 2026
75 of 90 checks passed
@brow
brow deleted the home-bell-ui branch November 6, 2026 20:10
bradseiler added a commit that referenced this pull request Nov 6, 2026
* origin/main:
  fix(relay): set received_at in the system-channel fan-out test helper (#9214)
  feat(mobile): move Activity to a Home bell and align Home spacing (#9212)
  Allow operators to set initial NIP-FI policy on create (#9211)
  perf(loadgen): spread seed writes across channel creators (#9206)
  feat(relay): runtime-tunable history-read and AUTH concurrency caps via feature flags (#9170)

Signed-off-by: Brad Seiler <[email protected]>

This branch was previously deployed

1 inactive deployment
codex-review — e54bf0cc Deployed Nov 6, 2026 by brow via Run Codex Security Review #13602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants