Repository navigation
fix(media): run thumbnail regeneration tests in CI and cap rebuild pixels - #9198
Merged
Merged
Conversation
The external_infra_minio_tests in api::media are excluded from the PostgreSQL lane and no MinIO step selected them, so they never ran in CI. Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Signed-off-by: John Tennant <[email protected]>
Thumbnails rebuilt from a stored original skip upload validation, so the decoder could see an image over the upload-time pixel cap. Thumbnail generation now runs the same check before decoding. Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Signed-off-by: John Tennant <[email protected]>
A missing thumbnail of a stored 5001x5000 original stays a 404 and writes nothing. Signed-off-by: John Tennant <[email protected]> Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
They share one fixture image's storage keys, and nextest runs each in its own process, where their in-process lock can't order them. Signed-off-by: John Tennant <[email protected]> Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
Overwriting the shared fixture image's original broke the hash-at-key invariant for any test reading it concurrently. The non-image case shares the same helper. Signed-off-by: John Tennant <[email protected]> Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
No CI lane runs buzz-media's thumbnail unit tests, while the relay MinIO case covers the same cap through the media route and now runs in CI. Signed-off-by: John Tennant <[email protected]> Co-authored-by: Simone <0828be588d5c9c4d092c5b1cf01761d5aef63d6b104807fd8e8284d517dd1a99@buzz.block.builderlab.xyz> Co-Authored-By: Claude Opus 5.5 <[email protected]>
johnmatthewtennant
force-pushed
the
jtennant/simone/thumb-regen-followup
branch
from
November 6, 2026 20:21
7dba887 to
bae11ca
Compare
johnmatthewtennant
marked this pull request as ready for review
November 6, 2026 20:59
johnmatthewtennant
temporarily deployed
to
codex-review
November 6, 2026 21:00 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
the
codex-security-review-current
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
kazemek21
approved these changes
Nov 9, 2026
kazemek21
left a comment
kazemek21
left a comment
Contributor
There was a problem hiding this comment.
Kyle reviewed this PR and the Nexus review-tracker notes. Approved.
Posted by Codex (gpt-6.1-sol) on behalf of kylez
ravarora2
added a commit
that referenced
this pull request
Nov 12, 2026
…small * origin/main: perf(acp): reduce observer CPU and lock overhead (#9381) ci: fix main — stale RunCause call sites and Playwright on ubuntu-26.04 (#9418) fix(mobile): keep shortcut taps and the member picker from wedging (#9388) fix(mobile/ios): close notification code blocks only at line-ending fences (#9349) fix(media): run thumbnail regeneration tests in CI and cap rebuild pixels (#9198) fix(mobile): never show emoji shortcodes in reaction pills (#9411) fix(mobile): isolate channel header scroll rebuilds (#9400) Signed-off-by: Ravneet Arora <[email protected]>
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two gaps in the thumbnail regeneration from #9174:
api::media::tests::postgres_tests::external_infra_minio_testsis excluded from the PostgreSQL lane, which skipsexternal_infra*modules, and the backend integration job's only media MinIO step selects the admin tests. A sibling step now runs them against the same Postgres and MinIO.generate_image_metadata_sync, so that cap didn't apply. The check is now a sharedcheck_image_pixelsthat upload validation and thumbnail generation both run before decoding. On a rebuild, an oversized original gets the same 404 as any other regeneration failure.Related issue
Follow-up to #9174, from its review.
Testing
missing_thumbnail_is_not_regenerated_when_unsafenow stores a valid 5001x5000 PNG as an image original without thumbnails and requests one through the media route. Onmainthe relay rebuilds and serves it; with this change the request is a 404 and no thumbnail is written.external_infra_minio_testscases one at a time, since they share the fixture image's storage keys.🤖 Generated with Claude Code