Skip to content

fix(mobile): size reply labels correctly with Bold Text - #9013

Merged
brow merged 1 commit into
mainfrom
kennylopez-mobile-bold-reply-label
Nov 3, 2026
Merged

brow merged 1 commit into
mainfrom
kennylopez-mobile-bold-reply-label

Conversation

@klopez4212

Copy link
Copy Markdown
Contributor

System Bold Text made single-participant reply labels such as “12 replies” wrap or truncate: the handoff measured normal-weight glyphs, then rendered bold glyphs inside that narrower box. Resolve the inherited text style and platform bold override before measuring, and use that same style for rendering.

Addresses the fix-before-merge blocker identified by Tom's agent on #8987, specifically the Bold Text finding. Tom classified unloaded-root typing, legacy reply-only paging, and working-state label clipping as acceptable later follow-ups; those remain outside this patch.

Validation:

  • Regression loads the bundled Inter font (the default test font masks weight differences), toggles Bold Text off/on/off, and covers idle/working footers at 1x/2x scale. All four cases failed before the production fix.
  • Formatting and full analysis passed; 4,252 Flutter tests passed (44 skipped), plus 4 unconfigured-push tests. All 27 crypto tests passed. Mandatory push hooks passed.
  • Self-review found no blockers in this narrow change.

Draft pending app/human verification required by AGENTS.md. To verify: enable system Bold Text, open a channel with a single-participant thread, and confirm “12 replies” remains complete; repeat with enlarged text and toggle Bold Text off. No physical-device validation is claimed.

Co-authored-by: Terp <5856f6900e8e0a4e0ea1f4f8d2ee33e4753d2119bc122f94ecafc660b46c0511@buzz.block.builderlab.xyz>
Signed-off-by: kenny lopez <[email protected]>
@klopez4212
klopez4212 marked this pull request as ready for review November 3, 2026 19:24
@klopez4212
klopez4212 requested a review from a team as a code owner November 3, 2026 19:24
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T19:28:39.466582Z 063ad66 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@brow
brow merged commit 8312419 into main Nov 3, 2026
60 checks passed
@brow
brow deleted the kennylopez-mobile-bold-reply-label branch November 3, 2026 22:10

This branch was previously deployed

1 inactive deployment
codex-review — 063ad66a Deployed Nov 3, 2026 by klopez4212 via Run Codex Security Review #12229
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants