Repository navigation
Conversation
Signed-off-by: jm <[email protected]> Co-authored-by: Codex <[email protected]> Signed-off-by: jm <[email protected]>
Signed-off-by: jm <[email protected]> Co-authored-by: Codex <[email protected]>
Signed-off-by: jm <[email protected]> Co-authored-by: Codex <[email protected]>
Signed-off-by: jm <[email protected]>
Signed-off-by: jm <[email protected]>
* commit '9b16e43091672ff91692c17e5e9f2c2017f5148b': test(desktop): bind duplicate voice players to message IDs Signed-off-by: jm <[email protected]>
joahg
left a comment
joahg
left a comment
There was a problem hiding this comment.
🤖 Read the ingress lanes, source accounting and proxy trust logic; permits are held through detached APNs work and bookkeeping, and untrusted peers cannot spoof the client IP header. P2: trustedProxyCidrs defaults to empty, so a deployment behind an ingress that forgets to set it puts every client in one source bucket (20/min enroll, 120/min management, one revocation share of 2); consider having the chart fail or warn when an HTTPRoute/ingress is enabled without it. CI is red on the stack's security-review authorization gate, not this diff.
Signed-off-by: jm <[email protected]>
joahg
left a comment
joahg
left a comment
There was a problem hiding this comment.
🤖 Re-approving. This PR's diff against its base is byte-identical to the head I approved; only base merges came in. The current CI run's build and test checks pass, and the remaining failures are the stacked-PR Authorize Security Review gate and a cancelled superseded run.
Give enrollment, management, delivery, and revocation separate request limits. Keep delivery capacity until APNs and bookkeeping finish, even if the client disconnects. Reserve four revocation slots, with at most two per source, so one slow client cannot occupy them all. Use verified peer or proxy information, body limits, database timeouts, and chart configuration.
Validation: HTTP/1 and HTTP/2 cancellation, slow-upload, source-budget and proxy regressions; 89 default and 91 development-App-Attest gateway tests; clippy, formatting and file-size checks. Database timeout tests and Helm rendering were also checked.
Stack (merge in order): #8673 → #8703 → #8704 → #8705 → #8706 → #8707 → #8708.