Repository navigation
Simplify desktop release to tag-and-push - #185
Merged
Merged
Conversation
…d VERSION env var The publish scripts (DMG and updater) had readVersionFromConfig() fallbacks that read the version from tauri.conf.json. Under the new tag-driven release flow, the version in config files on main is not the release version — the git tag is. These fallbacks would silently return the wrong version if VERSION was unset. Replace with requireVersionEnv() that fails fast with a clear error message if VERSION is not provided. CI always sets this from RELEASE_VERSION; local use requires explicit VERSION=x.y.z. Co-Authored-By: Claude Opus 4.6 <[email protected]>
Move version bumping into CI so the release flow is just `git tag desktop/v<version> && git push`. CI extracts the version from the tag, patches package.json / tauri.conf.json / Cargo.toml, regenerates Cargo.lock, then builds, signs, and publishes. - Add set-version-from-tag.mjs (pure file-patcher, replaces bump-version.mjs) - Add RELEASE_VERSION job-level env var as single source of truth in CI - Add cargo generate-lockfile step after version patching - Simplify justfile: kill desktop-prepare, desktop-release is now tag+push - Add desktop-set-version and optional version arg to desktop-release-build - Rewrite RELEASING.md for the simplified flow Co-Authored-By: Claude Opus 4.6 <[email protected]>
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
tlongwell-block
added a commit
that referenced
this pull request
Mar 26, 2026
…imeout * origin/main: Fix desktop release updater signing flow (#187) Set the desktop release relay default (#186) Simplify desktop release to tag-and-push (#185) fix(desktop): align DM close button and unread indicator hover states (#184) fix(desktop): refresh DM sidebar in real-time when new messages arrive (#183) feat(desktop): add message editing support (#182) fix(desktop): ensure all agent dialogs scroll content and keep footer visible (#181)
BradGroux
pushed a commit
to BradGroux/buzz
that referenced
this pull request
Aug 23, 2026
Co-authored-by: Claude Opus 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git tag desktop/v<version> && git push(orjust desktop-release <version>)package.json,tauri.conf.json, andCargo.toml, regeneratesCargo.lock, then builds/signs/publishesdesktop-preparerecipe andbump-version.mjs— replaced byset-version-from-tag.mjs(pure file-patcher) and CI-side version extractionRELEASE_VERSIONenv var extracted once from tag; publish scripts now fail fast viarequireVersionEnv()instead of silently falling back to stale config filesChanges
.github/workflows/sprout-desktop-release.yml— addRELEASE_VERSIONjob-level env, version-set +cargo generate-lockfilestepsdesktop/scripts/set-version-from-tag.mjs— new pure file-patcher with semver validationdesktop/scripts/bump-version.mjs— deleted (replaced by above)desktop/scripts/publish-dmg-to-github-release.mjs—readVersionFromConfig()→requireVersionEnv()desktop/scripts/publish-updater-to-github-release.mjs— same treatment, removed dead importsjustfile— killdesktop-prepare, simplifydesktop-releaseto tag+push, adddesktop-set-versionand optional version arg todesktop-release-builddesktop/RELEASING.md— rewritten for simplified flowNew release flow
Or:
Test plan
desktop/v*tag pushpnpm install --frozen-lockfilesucceeds after version patching (Beth's medium note — pnpm checks dependency resolution, not rootversionfield)just desktop-set-version 0.3.0locallyjust desktop-release-build version=0.3.0locally🤖 Generated with Claude Code