Skip to content

refactor(desktop): split global styles and markdown renderers - #1361

Merged
wesbillman merged 8 commits into
mainfrom
pinky/break-up-globals-css
Jun 29, 2026
Merged

refactor(desktop): split global styles and markdown renderers#1361
wesbillman merged 8 commits into
mainfrom
pinky/break-up-globals-css

Conversation

@wesbillman

@wesbillman wesbillman commented Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • split desktop/src/shared/styles/globals.css into ordered global style partials while preserving cascade order
  • extract markdown renderer types/utilities into desktop/src/shared/ui/markdown/
  • extract small isolated markdown renderers: SpoilerInline, FileCard, MessageLinkPill, and InlineEmojiPopover
  • extract the markdown code block/Shiki renderer into CodeBlock.tsx
  • expand the desktop file-size guard to shared production source folders with exact temporary overrides for current shared UI offenders (with markdown.tsx ratcheted down after the code-block split)

Notes

  • Mechanical refactor only; public Markdown export remains unchanged.
  • Intentionally deferred the stateful image/lightbox and video-context seams to a follow-up slice.
  • Follow-up target: converge the remaining flat markdownUtils.ts / markdownFileCard.ts files into the markdown/ directory.
  • The file-size guard remains pass/fail only at the existing 1000-line hard limit; e2e/test harness files are intentionally left out for now.

Validation

  • pnpm --dir desktop check
  • pnpm --dir desktop build
  • pnpm --dir desktop test (1242/1242 pass after rebase)

Review

  • Reviewed in Buzz by Brain as equivalent/safe across the CSS split and markdown extractions.

wesbillman and others added 8 commits June 29, 2026 12:48
@wesbillman Pinky
refactor(desktop): split global styles into partials
0d5a48e 
Keep globals.css as the ordered import hub and move existing global styles into topic-based partials without changing cascade order.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown types and utilities
4309be6 
Move markdown renderer types and shared utility helpers into markdown submodules without changing their implementations.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown spoiler renderer
6455e45 
Move the spoiler inline renderer into the markdown submodule without changing its implementation.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown file card
122bc8a 
Move the generic attachment file card into the markdown submodule without changing its implementation.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown message link pill
ca8defd 
Move the message link pill renderer into the markdown submodule without changing its implementation.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown emoji popover
2b43c96 
Move the inline custom emoji popover renderer into the markdown submodule without changing its implementation.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
chore(desktop): expand file size guard coverage
a0da3f4 
Add shared production source folders to the desktop file-size guard and remove stale overrides for files that are back under the default limit.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman Pinky
refactor(desktop): extract markdown code block renderer
92cc305 
Move the markdown code block and Shiki highlighting renderer into the markdown submodule without changing its implementation.

Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Signed-off-by: Wes <[email protected]>
@wesbillman
wesbillman merged commit c27b425 into main Jun 29, 2026
25 checks passed
@wesbillman
wesbillman deleted the pinky/break-up-globals-css branch June 29, 2026 19:49
@wpfleger96 wpfleger96 mentioned this pull request Jun 30, 2026
Merged
@wpfleger96 wpfleger96 mentioned this pull request Jul 10, 2026
Merged
BradGroux pushed a commit to BradGroux/buzz that referenced this pull request Aug 23, 2026
@wesbillman Pinky
refactor(desktop): split global styles and markdown renderers (block#…
a285ea4 
…1361)

Signed-off-by: Wes <[email protected]>
Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
richardokonicha pushed a commit to fugoku/buzz that referenced this pull request Oct 23, 2026
@wesbillman Pinky
refactor(desktop): split global styles and markdown renderers (block#…
0727fdf 
…1361)

Signed-off-by: Wes <[email protected]>
Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesbillman