Description
Desktop Smoke E2E (2) failed on attempt 1 of the CI run for #6542 at 0d7b21b356c842ad167d54a874bc9f378fe3c706, failing all three Playwright attempts, then passed on a re-run of the same job at the same SHA with no code change.
- Failed job (attempt 1): https://github.com/block/buzz/actions/runs/32782601230/job/97607837104
- Passing re-run (attempt 2): https://github.com/block/buzz/actions/runs/32782601230/job/97614178241
Failure
tests/e2e/empty-edit-delete.spec.ts:74 — "cancelling the empty-edit delete keeps the message" — timed out waiting for the confirm dialog:
const dialog = page.getByRole("alertdialog");
await expect(dialog).toBeVisible({ timeout: 10_000 });
What the artifacts show
The empty-edit submit never reached the confirm dialog on that runner — the dialog did not appear and get dismissed:
- The CI error-context DOM snapshot has edit mode still live and never exited: "Editing message" and "Cancel edit" both present, composer empty. No
alertdialognode anywhere in the snapshot. - The trace confirms the gesture ran in the intended order: edit-message click →
edit-targetvisible → select-all → Backspace → empty assertion passes → Enter → wait foralertdialog.
So the state at failure is "editor cleared and Enter pressed, but the submit did not produce the dialog," not "dialog appeared and was lost."
Suspected mechanism
Async timing in the Tiptap clear→Enter sequence: the Enter keypress is dispatched before the editor's cleared state has propagated to whatever decides an empty submit routes to the delete confirmation, so the submit is treated as a no-op instead of an empty edit. Unconfirmed — it is consistent with the DOM evidence but I did not instrument the editor to prove it.
Not reproducible at this SHA
Checked at 0d7b21b356c842ad167d54a874bc9f378fe3c706 (git rev-parse HEAD confirmed in the same shell):
- The spec alone: passes 3/3.
- The exact CI shard,
--project=smoke --shard=2/4 --workers=1(336 tests):empty-edit-deletepassed. Two unrelated specs flaked in that run —huddle-transcription.spec.ts:759andinbox-live-update.spec.ts:281. - The CI job re-run alone, same SHA, no code change: pass (16m52s).
Scoped negative: I did not find a reproduction locally in the same shard, or on a CI re-run at that SHA. I am not claiming this is a previously-known flake — I did not search the history of this spec for earlier occurrences.
Not a #6542 regression
The failure appeared on a run of #6542 (agent activity cover drawer), which had just moved edit-adjacent code, so it was worth ruling out:
- The spec never opens a cover drawer or the agent surface.
- The rebase did not modify the empty-edit path. The relocated pending-main-edit effect still gates on
channelIsCovered(desktop/src/features/channels/ui/ChannelPane.tsx:551) withonEditunchanged. - Escape is not involved in this flow, so the cover drawer's Escape handling cannot reach it.
Ask
Evidence only, no fix here. If someone wants this hardened, it is a change to that spec's clear→Enter sequence (wait for the editor's empty state to settle before pressing Enter rather than asserting emptiness and immediately submitting) and should not ride along in an unrelated PR.
Activity
loganj commentedon Sep 11, 2026
@baxen — evidence only, as requested; no rerun or repair performed. This is another historical occurrence of the same spec failure.
Run 34541681561, job 103085688484 (Desktop Smoke E2E, shard 2/4), artifact 10178019853. Tested merge
fbba8065859b29757851b992a70555f350908ab5(b3b1256470ba032097642239131a8a08a8c85eccinto092c6a7277698bd373ccbc1d008fc1507094ae74; Desktop tree identical to both parents, so the links below apply to the tested merge).What the retry-1 trace shows. Backspace leaves the focused edit verifiably empty (
is-editor-emptyDOM), but the stale#generalchannel suggestion stays open. Enter ~56 ms later — inside the 120 ms debounce — inserts#generalas a chip instead of submitting. All three attempts end withEditing message, a#generalchip in the composer, and noalertdialog: the empty-edit delete dialog is never reached. The submit is not a no-op; Enter is routed to the suggestion.Source seam (lines at base
092c6a7…): detection and clearing ofchannelQueryare delayed 120 ms (useChannelLinks.ts L116-L145); Enter acceptance trusts the stale open-query state without re-validating latest text (useChannelLinks.ts L156-L204);submitOnEnterdefers while autocomplete is open (useRichTextEditor.ts L309-L328);detectPrefixQueryreturns null for empty text (L16-L80) — but that decision hasn't run when Enter lands.Suggestion (not implemented): invalidate a query immediately when its trigger no longer exists (including empty text), plus a real-editor regression — select-all → Backspace → Enter inside the debounce window — instead of a wait-only workaround (spec L23-L91).
Current main
813bbd14121edacc6cb4733301a3af12131aa10ewas not assessed. Requesting maintainer triage of this evidence.fix(desktop): fix the product races behind four E2E flakes
fix(desktop): fix the product races behind four E2E flakes (#8680)