Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: block/buzz
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: desktop-v0.5.19
Choose a base ref
...
head repository: block/buzz
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: desktop-v0.5.20
Choose a head ref
  • 6 commits
  • 46 files changed
  • 9 contributors

Commits on Aug 25, 2026

  1. chore(release): release Buzz Desktop version 0.5.19 (#6828)

    ## Buzz Desktop release v0.5.19
    
    - **Frozen main:** `ee6ca5fa28bce04dfecb6717de65b08a57f2ac47`
    - **Reviewed candidate:** `ab691bcdaeccaa6698a2199beaba3f6e93daae81`
    - **Previous desktop release:** `desktop-v0.5.18`
    - **Proposed immutable tag:** `desktop-v0.5.19`
    
    This PR may be **squash merged** after the Desktop Release Candidate
    check and all protected-branch checks pass. Merging authorizes
    publication of the exact reviewed candidate; later or unrelated changes
    on `main` cannot alter it.
    
    The checked-in changelog accounts for every non-merge commit in the
    release range. The Desktop tag points to the reviewed candidate commit,
    not the later squash commit. Publication remains bound to that immutable
    candidate tag.
    
    Signed-off-by: Wes <[email protected]>
    Co-authored-by: Wes <[email protected]>
    Co-authored-by: Release Automation <[email protected]>
    3 people authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    7a1b7d8 View commit details
    Browse the repository at this point in the history
  2. fix(ci): check out source in docker.yml merge job (#6833)

    ## Problem
    
    Every `docker.yml` run on `main` has failed since
    [#6781](#6781) merged. That PR added a
    "Create deployment eligibility predicate" step to the `merge` job, which
    runs `jq` against
    `$GITHUB_WORKSPACE/scripts/create-deployment-eligibility-predicate.jq`.
    But the `merge` job has no `actions/checkout` step — the workspace is
    empty, so `jq` can't open the file and exits `2` (`jq: Could not open
    ... No such file or directory`). The `build` and `qualify` jobs each
    check out the source; `merge` never needed one until this step was
    added.
    
    ## Fix
    
    - `.github/workflows/docker.yml`: add `actions/checkout` (same pinned
    SHA as the other jobs, `df4cb1c` / v6.0.3) as the first step of the
    `merge` job.
    - `scripts/test-relay-image-eligibility-workflow.sh`: guard the
    regression by asserting the `merge` job checks out the source before
    building the predicate.
    
    ## Verification
    
    CI cannot exercise the `merge` job on a pull request — the job is gated
    `if: github.event_name != 'pull_request'`, so it only runs on push to
    `main`. The proof is the root cause (missing checkout for a step that
    reads a repo file) plus the eligibility workflow test:
    `scripts/test-relay-image-eligibility-workflow.sh` passes with the fix
    and fails with the new guard's specific message (`merge job must check
    out the source before building the eligibility predicate`) when the
    checkout is removed.
    
    Signed-off-by: Will Pfleger <[email protected]>
    wpfleger96 authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    cae7f82 View commit details
    Browse the repository at this point in the history
  3. fix(release): attribute desktop candidates to the operator (#6831)

    The desktop release tooling hardcoded one contributor's personal
    identity into every release candidate commit.
    `scripts/prepare-desktop-release.sh` committed the candidate with a `git
    -c user.name='Wes' -c user.email='[email protected]'`
    override, and `scripts/desktop_release.py` `validate` required the
    candidate author to be exactly `Wes
    <[email protected]>` plus a matching `Signed-off-by`
    trailer. That leaked from Wes's working setup into the validation
    contract in #3568, so a release cut by any other operator was falsely
    attributed to and signed off by Wes (as happened on #6828).
    
    ## Change
    
    - `prepare-desktop-release.sh`: drop the `-c` identity overrides so `git
    commit -s` uses the operator's own configured identity to author and
    sign off the candidate. The automation `Co-authored-by` trailer is
    unchanged.
    - `desktop_release.py` `validate`: replace the exact-Wes checks with
    structural ones — the commit author must be non-empty, the body must
    contain a `Signed-off-by` trailer whose name and email match the commit
    author (honest DCO), and the existing automation `Co-authored-by` regex
    check stays. Failure messages remain specific.
    - `test-desktop-release-candidate.sh`: the fixture candidate now commits
    under the harness's own identity, and a new negative case rewrites the
    author to a mismatched identity and asserts the validator rejects it.
    
    Release authorization is bound to the merged PR via the GitHub API in
    `scripts/verify-desktop-release-merge.sh`, never the commit author
    field, so this does not weaken the trust model. `RELEASING.md` and
    `.github/workflows/desktop-release-candidate.yml` reference no author
    identity and need no change.
    
    Verified locally: `scripts/test-desktop-release-candidate.sh` passes,
    including the new sign-off/author-mismatch rejection.
    
    ---------
    
    Signed-off-by: Will Pfleger <[email protected]>
    Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
    wpfleger96 and Duncan authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    820a858 View commit details
    Browse the repository at this point in the history
  4. fix(desktop): respect automatic mention preference after send (#6837)

    **Category:** fix
    **User Impact:** Disabling automatic agent mentions now keeps one-time
    agent mentions out of the next message draft.
    
    **Problem:** A successfully sent inline agent mention was treated as
    eligible for post-send restoration even when **Automatically mention
    agents** was disabled, so the agent immediately reappeared in the
    composer. **Solution:** Gate the send-success restoration path on the
    live preference while leaving explicitly pinned agents and enabled
    automatic mentions unchanged.
    
    <details>
    <summary>File changes</summary>
    
    **desktop/src/features/messages/ui/MessageComposer.tsx**
    Skips the automatic post-send mention restoration path when the
    preference is disabled.
    
    **desktop/tests/e2e/persistent-agent-audience.spec.ts**
    Reproduces disabling the toggle before sending an inline agent mention
    and verifies the next composer is empty while the outgoing mention still
    reaches the agent.
    
    </details>
    
    ## Reproduction steps
    
    1. Enable **Automatically mention agents** in the composer mention
    options.
    2. Disable it again.
    3. Compose and send `@Agent test` using the inline mention picker.
    4. Confirm the message still mentions the agent, but the cleared
    composer does not repopulate `@Agent`.
    5. Re-enable the preference and repeat; confirm the mention is restored
    for the next message.
    
    ## Testing
    
    At `a179a2d00a6ac5cf0bc4a1c7c1ef3d5dfa9d0875`:
    
    - Full desktop unit suite: 5,501 passed.
    - Desktop check and typecheck passed in the pre-push hooks.
    - Desktop file-size ratchet passed in the pre-push hooks.
    - Full `persistent-agent-audience.spec.ts` Playwright file: 17 passed,
    including preference off (empty composer), preference on (restored
    mention), and the existing address-undo journey.
    
    ## Visual validation
    
    | Automatic mentions off | Automatic mentions on |
    | --- | --- |
    | After sending a one-time mention, the outgoing message is preserved
    and the next composer stays empty. | After sending, the agent remains
    addressed and is restored in the next composer. |
    | ![Automatic mentions disabled: empty composer after
    send](https://d24qwcpro867f5.cloudfront.net/repos/buzz/prs/6837/disabled-after-send.png)
    | ![Automatic mentions enabled: agent restored after
    send](https://d24qwcpro867f5.cloudfront.net/repos/buzz/prs/6837/enabled-after-send.png)
    |
    
    <details>
    <summary>Original regression</summary>
    
    With automatic mentions disabled, sending `@Alia test` still repopulated
    `@Alia` in the cleared composer.
    
    ![Original regression: the sent agent reappears in the
    composer](https://d24qwcpro867f5.cloudfront.net/repos/buzz/prs/6837/auto-mention-regression-before.png)
    
    </details>
    
    Signed-off-by: Taylor Ho <[email protected]>
    Co-authored-by: Rizz <302abe414ca6e3134763d2539bfcf145aea2a63fe5f8455204ed602fd40cf381@buzz.block.builderlab.xyz>
    tellaho and Rizz authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    e8cd751 View commit details
    Browse the repository at this point in the history
  5. feat(desktop): add KLIPY GIF search to composers (#5554)

    ## Summary
    
    - Supersedes #1913 with a KLIPY-hosted URL implementation.
    - Adds KLIPY GIF search and trending results to desktop message and
    forum composers.
    - Keeps selected GIFs hosted by KLIPY; Buzz stores only the external URL
    and media metadata (no imeta tag, since relays only accept hash-backed
    local `/media/` entries).
    - Aligns the Emoji/GIF picker with Buzz's standard segmented control,
    theme surfaces, and motion behavior.
    
    ## Relay-to-provider boundary
    
    - The relay proxies KLIPY search/share so the `BUZZ_KLIPY_API_KEY` never
    reaches the desktop; the key stays server-side behind a redacted `Debug`
    impl.
    - The dedicated GIF `reqwest` client sets `redirect::Policy::none()`.
    Because the API key rides in the request path, following a provider
    `3xx` could replay a key-bearing URL to an attacker-chosen host (an
    SSRF/key-disclosure primitive). With redirects disabled, a `3xx` returns
    as a non-success status that the handlers map to a generic `502`; the
    `Location` target is never read or forwarded.
    - Admission reuses the established NIP-98, membership, replay, and
    per-pubkey rate-limit gates, with an upstream response-size cap and
    allowlisting so KLIPY error bodies never cross the relay boundary.
    
    ## Accessibility
    
    - Under `prefers-reduced-motion: reduce`, the picker grid renders a
    static provider poster (a normalized `jpg` asset) instead of the
    animated preview, or a named static placeholder when no poster is
    available. It reacts to preference changes while mounted.
    `no-preference` keeps the animated preview.
    - Selected GIFs carry their title through `ImetaMedia`'s `displayLabel`,
    so the composer thumbnail, preview dialog, editor, lightbox, and remove
    control all derive one non-empty accessible name instead of an empty
    `Attachment ` label. Ordinary hashed uploads keep their existing
    hash-derived names.
    
    ---------
    
    Signed-off-by: kenny lopez <[email protected]>
    Signed-off-by: Kenny Lopez <[email protected]>
    Signed-off-by: Will Pfleger <[email protected]>
    Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
    Signed-off-by: Hayt <9e1c23a3fd83f61da34420e4e88ff1b16e45cafcc0cd9019eb07d4ecfa8ca9b0@buzz.block.builderlab.xyz>
    Co-authored-by: Princess Donut <b238ea756dee4d98afa5883fc7f1de61eeabe65bf700e3a5a5a80db5e42e2c2b@buzz.block.builderlab.xyz>
    Co-authored-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
    Co-authored-by: Will Pfleger <[email protected]>
    Co-authored-by: Hayt <9e1c23a3fd83f61da34420e4e88ff1b16e45cafcc0cd9019eb07d4ecfa8ca9b0@buzz.block.builderlab.xyz>
    5 people authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    8471049 View commit details
    Browse the repository at this point in the history
  6. chore(release): release Buzz Desktop version 0.5.20

    Co-authored-by: Release Automation <[email protected]>
    Signed-off-by: Will Pfleger <[email protected]>
    wpfleger96 and release-automation committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    95154be View commit details
    Browse the repository at this point in the history
Loading