You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit fe0970a
Browse filesBrowse the repository at this point in the historyBrowse files
fix(mobile): offer a new identity beside saved keys on unclaimed accounts (#9107)
## Summary
This fixes a dead end in mobile Builderlab sign-in. A new account
(unbound, with no backups) on a device that already had saved identities
could only pick one of those identities. Any saved key forced the
picker, and creating a key required the device to have none. If the
service then definitively rejected binding the chosen key, the app
showed "Let's try that again" with no way forward: the chosen key stayed
in the account's slot, so every retry and every launch re-sent the same
rejected bind.
For an unclaimed account, the picker now also offers **Create a new
identity**:
- Creation writes only this account's empty identity slot, so every
saved and device key is kept.
- Creation is offered only when every current device key was among the
choices shown, so a new identity never silently passes over a key the
user didn't see.
- Bound accounts, accounts with backups, pairing and pending import
never offer it.
When binding a chosen key is definitively rejected, the blocked screen
offers **Choose a different identity**:
- It appears only for a 400, 404, 409 or 422 from `/verify` in the
current attempt, for the current account and pubkey, and never during
pairing, whose transferred key is the only choice. Evidence from an
earlier attempt is cleared before each bind. A challenge rejection, a
403, a 503 or any other ambiguous failure offers nothing.
- Before releasing the slot, it rechecks the account: still unbound
(`/current` and status), no backups, the same subject, and a slot that
still holds that pubkey without a receipt.
- It releases the slot only when another durable copy of the same key
exists (the device inventory or another account slot), then verifies the
slot is empty. No key is deleted: only the account's pointer to the
rejected choice is cleared. A failed or refused release keeps the slot
and the choice, so it can be retried in place or after a restart.
- After release, the picker runs again and offers the saved keys plus
creation.
The recovery code lives in `hosted_flow_identity_recovery.dart`, a part
of `hosted_flow.dart`, to stay within the mobile file-size limit.
### Related issue
None found.
### Testing
**Physical iPhone, a signed release build of `1fb633d55` installed over
the existing app (keychain and saved identities kept):** a saved
identity was rejected, then Choose a different identity, the picker,
Create a new identity and Join your community. Joining then completed.
This head differs from `1fb633d55` only in the guards for leaving,
pairing and a failed or refused release listed below, which this journey
does not reach, and in no UI code. The status of that phone's original
rejection was not captured, so it is not confirmed to be one of the
rejections above. The 409 case is covered by tests.
**Tests (red on `main`, green here):**
- Identity service and store: creation beside offered keys; refusal for
unseen or partly offered device keys; release when another copy exists;
refusal for a sole copy, a binding, a backup, a receipt, another account
or an unusable recheck; failed delete and retry; a cancelled attempt.
- Onboarding journeys: create beside saved keys; select, rejected bind,
restart, choose a different identity, create and bind; ambiguous 503 and
403 failures; challenge rejection and stale evidence.
- Release boundaries: an account switch at `/current`, at status, or
between the recheck and the delete; cancelling between the recheck and
the delete; leaving the picker before a late creation; an unreadable
device inventory; leaving while a release is in flight; a failed delete
retried in place and after a restart; a release refused because the
inventory is unreadable, then retried in place; a rejected paired key.
Each keeps every key, leaves the new account's slot untouched and leaves
a cancelled flow idle, and a retry converges.
- Mutating the creation guard, the generation check, the binding
recheck, the store's receipt check, the account and cancellation checks
before the delete, or the device-inventory error handling fails a test.
#### Screenshots
Physical iPhone at `1fb633d55` (frames from a screen recording; saved
public keys redacted):
| Rejected bind | After Choose a different identity | After Create a new
identity |
| --- | --- | --- |
| 
| 
| 
|
Widget-test renders of the same screens (the real `HostedFlow` against a
mocked account service, with a fixture key; the square at the top left
is the test renderer's placeholder for an asset):
| Picker on an unclaimed account | Rejected bind |
| --- | --- |
| 
| 
|
🤖 Generated with [Claude Code](https://claude.com/claude-code)
---------
Signed-off-by: John Tennant <[email protected]>
Co-authored-by: Xander <ff30c859b96bd5233ffaf5d071200458f1274bd0dab03589214cf1055198491d@buzz.block.builderlab.xyz>
Co-authored-by: Claude Opus 5.5 <[email protected]>
(cherry picked from commit c848b6d)
Signed-off-by: Tom Brow <[email protected]>
Copy file name to clipboardExpand all lines: mobile/lib/features/onboarding/hosted_connect_sheet.dart
+12-1Lines changed: 12 additions & 1 deletion
Original file line number
Diff line number
Diff line change
@@ -99,7 +99,7 @@ class HostedConnectSheet extends HookConsumerWidget {
99
99
?'Choose a backed-up identity to connect to Builderlab. Your other backups and saved community keys will be kept. This app cannot change the selected Builderlab identity later.'
?'Use your Builderlab identity on this device? It differs from your saved community identities. Those keys and your cloud backups will be kept. This app cannot change the selected Builderlab identity later.'
102
-
:'Choose the identity to connect to Builderlab. It will be bound to your account and backed up. Existing keys will be kept. This app cannot change the selected Builderlab identity later.',
102
+
:'Choose the identity to connect to Builderlab${flow.canCreateIdentity ? ', or create a new one' : ''}. It will be bound to your account and backed up. Existing keys will be kept. This app cannot change the selected Builderlab identity later.',
103
103
HostedFlowStage.profile =>
104
104
'What should people in this community call you? You can add a photo in Settings.',
105
105
HostedFlowStage.acceptPolicy =>
@@ -161,6 +161,12 @@ class HostedConnectSheet extends HookConsumerWidget {
161
161
),
162
162
),
163
163
),
164
+
if (stage ==HostedFlowStage.chooseIdentity && flow.canCreateIdentity)
165
+
FilledButton(
166
+
style: actionStyle,
167
+
onPressed: flow.createIdentity,
168
+
child:constText('Create a new identity'),
169
+
),
164
170
if (stage ==HostedFlowStage.setupIdentity) ...[
165
171
if (flow.canCreateIdentity) ...[
166
172
FilledButton(
@@ -218,6 +224,11 @@ class HostedConnectSheet extends HookConsumerWidget {
0 commit comments